- Issue created by @Anas_maw
- 🇩🇪Germany dbielke1986
Amazing!!!!!🤩
Yes, we will add this information, of cause.
Great idea - I will have a look at this on Monday.BR
- Status changed to Postponed: needs info
11 months ago 7:39am 29 January 2024 - 🇩🇪Germany dbielke1986
@Anas_maw
Currently, the 2.x branch seems not to work correctly with this module.
Please let us know as soon as you have a stable release so that we can take a look at the module and link it in our description.I would like to link only stable releases and modules so that there are no problems on the systems.
BR
Daniel - 🇯🇴Jordan Anas_maw
@dbielke19886 can you please list what is the problem, I tried it and it's working as expected.
- 🇩🇪Germany dbielke1986
There are several issues:
- The help link leads to the attached error (help.png)
- The already defined templates are not shown/used after installing this module. See the attached image (templates.png)
- The configuration itself cannot be correct because we need the content of a svg (and only svg are supported as icons), not the path
These were only my initial tests. But I think there are some other issues also (using different template files, so the configured file of the main module is not used, even you can configure it,....)
Maybe you can take a look at this and create a stable release. Of course, if everything is working properly, we will link your module in our description!
BR Daniel
- 🇯🇴Jordan Anas_maw
@dbielke19886 regarding point number 2, our module creates a configuration entity for templates and overrides the path file method, that's why the existing templates will not appear, what do you think?
- 🇩🇪Germany dbielke1986
@Anas_maw
I think that breaks the logic a little.
The best case would be if an activated UI module would deactivate the path input in the template module (deactivate the field) and instead display a link/reference to the new configuration interface.It would also make sense to take over already configured templates so that a direct changeover would be possible without reconfiguration.
That would be the best and most logical way for me.
- 🇯🇴Jordan Anas_maw
Currently, the UI module disables the path input, adding a link to the configuration is a good idea.
Importing already existing templates can be done, but I'm not sure if it's the correct way, as this may confuse the users, if you list the UI module in your module page, people will install both modules together and they will not need to do the path configuration part from the first. - 🇩🇪Germany dbielke1986
Okay, I understand. I hadn't seen that the path would be disabled, please excuse that.
Here it would certainly be relevant whether you then allow both configurations (template file from the template module AND the configured templates from the UI module), or if you only use those of the UI module.
I would almost say that either of the variants should work:
So, if the UI module is active, then only from there. If only the template module is there, then the templates defined in the file.
This would also make deactivating the path logical, as it suggests to the user: "You don't need to do this here anymore, use the newly provided interface to configure your templates"But you're right:
The automatic takeover should perhaps not be done, but what do you think of a possibility (a button in the configuration interface of your UI module) to take over the templates already configured in the template file. This way it is not automatically adopted - but the user has the option of dragging them over.The fact is one thing:
As soon as the UI module is there and thus the configuration of the template file in the template module is deactivated, I would no longer offer these templates in the CK Editor, but only those created in the configuration of the UI module.What do you think about this?
- 🇯🇴Jordan Anas_maw
@dbielke1986, sorry for my late response, we can make enhancements to my module to support all the mentioned above, appreciate it if you could list my module in your project, so people can install it and help me in adding these features, until now 92 sites are using my module with yours without listing it in your project and this number is very good in this stage, which means that people finds it useful, please add it to your project so I can get some help from the community.
- 🇦🇹Austria maxilein
Thank you for both, this and the ui integration modules!
I have been waiting for a long time to see something like this.
Templates can greatly improve productivity!May I ask why templates need to by files and are not stored in the db?
- 🇩🇪Germany dbielke1986
Good question, indeed 😅
I can not give you a good reason for that- maybe we should consider to store this data in the db.Br
- 🇩🇪Germany vincent.hoehn Dresden, Germany
Hello everyone.
The aim of this module was to insert predefined content within the editor as easily as possible.
The easiest way was therefore to read a JSON file. I don't see the point of additionally storing the templates in a database. - 🇦🇹Austria maxilein
Thank you for all the answers!
Since I am only using the UI: problem solved. No custom configuration can be forgotten ... - 🇯🇴Jordan Anas_maw
Could you please list the ckeditor_templates_ui module on the module page?
- Status changed to Fixed
6 months ago 11:22am 8 July 2024 - 🇩🇪Germany dbielke1986
@Anas_maw
I have added your module to the module page, just like the ckeditor_templates module does.
BR
Daniel Automatically closed - issue fixed for 2 weeks with no activity.