🇩🇪Germany @dbielke1986

Is working fine! No errors anymore.

Thank you for the quick fix and release @smustgrave

Yes, updatedb was running successfully.
Can I provide you any further information to get the issue analyzed?

dbielke1986 → created an issue.

Can you please create a new release? This is the only module what blocks the D11 upgrade.

Yes, PLEASE!!!

@andrew.wang

Of course, but that's exactly what this post is about: implementing a nice link experience, like LinkIt has.
This is certainly an enrichment of the core and should therefore also go into it, without the need for a Contrib module.

Hello dunodunott,

Thank you for reporting this issue.
I already fixed the spelling mistake.

Br
Daniel

This would be great because the last stable release was on 23 Sep 2016.
Thank you for your feedback!

Is there any update on this?
It would be nice to get an official, non-beta-release....

Did you try version 1.0.8?
In version 1.0.6 we had a problem with specific Drupal versions.

BR

Is already D11 ready

@crow

Of course, we can. But I have no idea how to do a proper implementation :-(
This post explains the problem best:

https://github.com/ckeditor/ckeditor5/issues/10220

If you, or anyone, has a good suggestion - it is highly appreciated.

+1 for an official release

Is working for me. Can we have an official release to get the D11 support?

Shipped with version 7.1.3

Of cause! Thank you for the MR!

dbielke1986 → created an issue.

Can we get a new, official release for the D11 compatibility, please?

Fixed with version 7.1.2

dbielke1986 → created an issue.

Fixed with version 7.1.1

It still seems to work that way. I still don't know why we ran into this deadlock.
After importing the tape backup and trying again, everything worked - with this very code.

Sorry for the noise...

dbielke1986 → created an issue.

Still a big problem with v2.3.x

I've also ran into this issue when trying to upgrade from v2.3 to v3.3.

@vincent:

Can you take a look at this, please?

Great, thank you. We will test this in our testing environment and provide feedback.

BR

When the Contrib module is activated, the module from the core is also active.

I have two questions about this:
1) Can the core module then simply be deactivated?
2) Will the configuration (content types, blocks ... ) and the created content be retained?

But idea is you can download the module and drop in and that's it. No migration or anything but would test heavily just to be sure.

That's a really great idea. Hopefully it works exactly as described.
I will report back...

Thank you very much for your work and the time you have invested here.

@vincent

Can you take a look at the MR, please?
It makes sense to me if the full path is passed at this point, as this is also checked in validate.

In *.js, only the path is taken from the input, without the Drupal.root.
Can you check again whether this is perhaps the reason why it is not always pulled directly?

But I'm not 100% sure, hence the question.

Can we get this in version 2.2.* or 2.3.*, please?
We are preparing the upgrade to D11 and need to update the group module, too.

So, next to D11 support, it will be great to have this patch also applied.

BR

@dolszewski:

Great work because now we can switch to this module, which is perfect.
The only thing I may would prefer is to move from px to em:

.cke5-custom-block-indent-1 {
  margin-left: 40px;
}

vs

.cke5-custom-block-indent-1 {
  margin-left: 2em;
}

What do you think about this?

Fixed -> Development version: 7.1.x-dev updated 8 Aug 2024 at 15:12 UTC

Thank you @radheymkumar for the fix and @Shubh02 for testing.
Will be part of the next release.

dbielke1986 → made their first commit to this issue’s fork.

I would not take the absolute path to the template.json because it could be a security risk.
We should wait and take care of this issue in the core:

https://www.drupal.org/project/drupal/issues/1792310 🐛 Wrong DRUPAL_ROOT with non-standard code structure Needs work

The feature doesn't really seem to be in demand in the community.
I would now close this feature request.

If someone wants it after all, or has an MR for it, please feel free to (re)open it.

@Anas_maw

I have added your module to the module page, just like the ckeditor_templates module does.

BR
Daniel

@zterry95

I closed the MR because you need to create a MR against the 7.1.x branch, please

dbielke1986 → changed the visibility of the branch 3458456-compitable-with-simpleoauth to hidden.

@porchlight

You are absolutely right. All the points mentioned are correct and must be taken into account.
And you are also right to say that this is a CKEditor issue that we cannot solve on the module side.

The

is a WorkAround that at least helps to get out of the

Hi porchlight,

Can you please check the linked items? I already mentioned the following answer in issue 3402691 💬 Inserted HTML template goes wrong Closed: works as designed .

The reason for this is a standard behavior of the CKEditor. If you insert the heading, you remain in the current DIV.

You can reproduce this by simply switching to a new line after inserting the first heading and continuing to write there. Here you remain in the current DIV. The following template is therefore also inserted within the first DIV.

You can solve this by adapting your templates as follows (add the "<p>&nbsp;</p>" after the template-div):

[
    {
        "title": "Heading2",
        "icon": "<svg xmlns=\"http://www.w3.org/2000/svg\" width=\"24\" height=\"24\" viewBox=\"0 0 24 24\"><path d=\"M8 16h8v2H8zm0-4h8v2H8zm6-10H6c-1. 1 0-2 .9-2 2v16c0 1.1.89 2 1.99 2H18c1.1 0 2-.9 2-2V8l-6-6zm4 18H6V4h7v5h5v11z\"/></svg>",
        "description": "Insert heading2 tags for this site.",
        "html": "<div class=\"o-title__border\"><h2 class=\"o-title__xl\">Heading2</h2></div><p>&nbsp;</p>"
    },
    {
        "title": "Heading3",
        "icon": "<svg xmlns=\"http://www.w3.org/2000/svg\" width=\"24\" height=\"24\" viewBox=\"0 0 24 24\"><path d=\"M8 16h8v2H8zm0-4h8v2H8zm6-10H6c-1. 1 0-2 .9-2 2v16c0 1.1.89 2 1.99 2H18c1.1 0 2-.9 2-2V8l-6-6zm4 18H6V4h7v5h5v11z\"/></svg>",
        "description": "Insert heading3 tags for this site.",
        "html": "<div class=\"o-title__border2\"><h3 class=\"o-title__l\">Headingr3</h3></div><p>&nbsp;</p>"
    } 
] 

@sfm1977:

Great! But what I haven't quite understood yet:
Is the problem solved now, or do we have to change something in the code?

Was it the linked item, or was the json as such faulty that you included?

BR

@justcaldwell

Unfortunately, I cannot confirm this. I used the dev version of “Development version: 3.0.x-dev updated 20 Dec 2023 at 17:25 UTC” and the name=" tag is removed.

Is working for me since a few months.
I think we can change to RTBC

alpha2 is not working for us.
The name attribute will be removed as soon as the Anchor Link Module is activated :-(

I would also be interested in testing this upgrade path.
We will do some tests as soon as Drupal 10.3 is released, and you give us the go to test.

Thank you so much @shelane.

The fix and the new release is working great!

Hi sfm1977,

could this be related to 3438983 🐛 Call to template json file broken if site is in sub-directory Active ?
I think the problem is the template file, which could not be found/resolved in the given path.
Did you change the delivered example json?

BR
Daniel

dbielke1986 → made their first commit to this issue’s fork.

Just created a fork and an MR with the changes of #2 ✨ Set the default filter to "Strip Tags" Needs review

Please review and test.

I see it the same way. Completely removing the content is fatal for many use cases.

Regarding the actual problem, please take a look at the linked items.

Good question, indeed 😅
I can not give you a good reason for that- maybe we should consider to store this data in the db.

Br

Great! Then everything should be fine ☺️

Already discussed here:

https://www.drupal.org/project/ckeditor5_template/issues/3402691 💬 Inserted HTML template goes wrong Closed: works as designed

Fixed in dev, will be provided with the next release.

Great!

Are you really using version 8.x-6.0?
Can you please check with the latest dev version of 7.0.0? That should resolve the problem.

Version 8.x-6.0 is a version that is no longer supported

Maybe related to #3420524 🐛 Error when the theme logo is not set Fixed

Can you please test the latest dev version?

Great! Thanks - is merged to dev and will be available with the next release.

Fixed with version 1.0.5

Fixed with version 1.0.5

Fixed with version 1.0.5

Great! Is working with the dev version.

By the way:
The decision whether to use "CKEditor" or "CKEditor5" or "CKEditor 5" is based on the following official article:
https://www.drupal.org/docs/core-modules-and-themes/core-modules/ckeditor-5-module/upgrading-modules-extending-ckeditor-4-to-support-ckeditor-5 →

It refers to the following starter package:
CKEditor 5 Dev Tools →

The info.yml contains:
package: CKEditor 5

So we will go with this package name.

It is not working as expected because the button is getting the class, but not the div next to it.
I am on it.

dbielke1986 → made their first commit to this issue’s fork.

@mnico,

Yes, you are absolutely correct. This will be done by @vincent.hoehn.

I just sent the changed code to him so that he can check and pack afterwards.

Br

https://ckeditor.com/docs/ckeditor5/latest/api/module_ui_dropdown_button...

I'm not really sure if this will resolve the issue, so I changed the status to "Needs review".

@vincent.hoehn:
Can you please review and check the changes I made?

Thanks for reporting. I can reproduce this issue and will fix this immediately.

+1 - would be great to get this feature in a stable release :-)