- Issue created by @ravi kant
- 🇩🇪Germany vincent.hoehn Dresden, Germany
Hi @ravi kant,
I have just checked the other modules. All other modules have "CKEditor 5" as package definition, we have "CKEditor5".
So the correct definition would be "CKEditor 5" and not "CKEditor"?
Best regards,
Vincent - First commit to issue fork.
- Assigned to nitin_lama
- 🇮🇳India nitin_lama India
Updated package definition. MR created. Please review.
- Issue was unassigned.
- Status changed to Needs review
11 months ago 1:11pm 7 February 2024 - 🇩🇪Germany vincent.hoehn Dresden, Germany
Hi @nitin_lama,
Thanks for the prompt fix and the merge request!
Before I close the MR, I'm waiting for an opinion from other contributors regarding the package naming.
Best regards,
Vincent - 🇮🇳India ravi kant Jaipur
I have confirmed by checking out the MR !12 and it is working as accepted.
- First commit to issue fork.
-
dbielke1986 →
committed 72b32268 on 1.0.x
Merge branch '3419695-is-possible-to' into '1.0.x' #3419695: Updating...
-
dbielke1986 →
committed 72b32268 on 1.0.x
-
dbielke1986 →
committed dc76235e on 1.0.x authored by
nitin_lama →
Issue #3419695: Is possible to add this block in 'ckEditor Group'...
-
dbielke1986 →
committed dc76235e on 1.0.x authored by
nitin_lama →
- Status changed to Fixed
9 months ago 7:36am 19 March 2024 - 🇩🇪Germany dbielke1986
By the way:
The decision whether to use "CKEditor" or "CKEditor5" or "CKEditor 5" is based on the following official article:
https://www.drupal.org/docs/core-modules-and-themes/core-modules/ckeditor-5-module/upgrading-modules-extending-ckeditor-4-to-support-ckeditor-5 →It refers to the following starter package:
CKEditor 5 Dev Tools →The info.yml contains:
package: CKEditor 5
So we will go with this package name.
Automatically closed - issue fixed for 2 weeks with no activity.