Create D11 compatible version

Created on 31 October 2024, 4 months ago

Problem/Motivation

Here are the problems reported by upgrade_Status

File name Line Error
web/modules/contrib/ckeditor_templates_ui/src/CkeditorTemplatesUi.php 30 Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

web/modules/contrib/ckeditor_templates_ui/src/Form/CkeditorTemplateForm.php 163 Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

web/modules/contrib/ckeditor_templates_ui/ckeditor_templates_ui.info.yml 8 Value of core_version_requirement: ^10 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.

web/modules/contrib/ckeditor_templates_ui/composer.json 1 The drupal/core requirement is not compatible with the next major version of Drupal. Either remove it or update it to be compatible. See https://www.drupal.org/docs/develop/using-composer/add-a-composerjson-fi... .

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Active

Version

2.0

Component

Code

Created by

🇦🇹Austria maxilein

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @maxilein
  • First commit to issue fork.
  • Merge request !6Resolve #3484837 "Create d11 compatible" → (Open) created by JeroenT
  • Pipeline finished with Success
    4 months ago
    Total: 175s
    #344384
  • Pipeline finished with Success
    4 months ago
    Total: 134s
    #344398
  • Pipeline finished with Success
    4 months ago
    Total: 136s
    #344471
  • Pipeline finished with Canceled
    4 months ago
    Total: 85s
    #344476
  • Pipeline finished with Success
    4 months ago
    Total: 135s
    #344481
  • Pipeline finished with Success
    4 months ago
    Total: 137s
    #344489
  • Pipeline finished with Success
    4 months ago
    Total: 140s
    #344491
  • 🇧🇪Belgium JeroenT 🇧🇪

    I wrote a MR, which adds D11 compatibility and fixes all validation tasks:
    https://git.drupalcode.org/issue/ckeditor_templates_ui-3484837/-/pipelin...

  • 🇯🇴Jordan Anas_maw

    Thanks, I will review, and waiting for the feedback from community

  • Status changed to Needs review 2 months ago
  • First commit to issue fork.
  • Pipeline finished with Success
    2 months ago
    Total: 235s
    #381821
  • 🇮🇳India sheshsharma

    MR!6 Makes this module compatible with Drupal 11. Functionality is working as expected.
    RTBC +1

  • 🇮🇳India manishvaity

    MR!6 Makes this module compatible with Drupal 11. Functionality is working as expected.

    RTBC +1

  • 🇵🇰Pakistan hamza_niazi

    Error: Call to a member function setClass() on null in ckeditor_templates_ui_ckeditor5_plugin_info_alter() (line 40 of modules/contrib/ckeditor_templates_ui/ckeditor_templates_ui.module).
    I got this error previously i was using the 8.x-1.5 and i have update to the dev version and implemented this patch MR!6 and on form i got this error

  • 🇧🇪Belgium JeroenT 🇧🇪

    #3484837-10: Create D11 compatible version seems unrelated to the Drupal 11 update and can be handled in a separate issue.

    Also, I don't think it's necessary to drop Drupal 10 support, so I would also keep that version in the core_version_requirement property and in composer.json.

  • 🇺🇦Ukraine trishen Kharkiv

    the current MR touches files that are not related to the module

  • First commit to issue fork.
  • Pipeline finished with Success
    about 1 month ago
    Total: 142s
    #414747
  • Pipeline finished with Success
    29 days ago
    Total: 142s
    #415663
  • 🇮🇳India arjak-mondal

    Removed all the compatibility checks as per the update status module.

  • 🇷🇴Romania Cracu

    backward compatibility should include also a change in composer.json.
    That should help upgrades from D10 to D11 in one go.

  • Pipeline finished with Success
    17 days ago
    Total: 142s
    #427398
  • 🇦🇹Austria maxilein

    Cannot apply it to the current or current dev version.
    There seems to be a lot of new code in ckeditor_templates_ui.module that the patch requires ...

Production build 0.71.5 2024