Entity operations for menu links are hardcoded in edit menu form

📌 Provide helpful editing links on "admin/structure/block" for deriver blocks (menu, views, block content, etc.) Needs review is doing something very similar.

getOperations() {
1. Should be typehinted as a new function

getResetRoute()
2. ditto

Typehint should be added for new functions in all spots.

Very nice work though!

Oh will need a change record also.

- Added type hints in the necessary methods.
- Added a change record here https://www.drupal.org/node/3338898 → (first one from me 🎉)
Tests are passing on local.

Thank you!

Overall looks good, but a couple of nits:

1. +++ b/core/lib/Drupal/Core/Menu/MenuLinkBase.php
   @@ -160,6 +167,38 @@ public function getTranslateRoute() {
    
   +  public function getOperations(): array {
   +    $operations = [];
   +
   

   This is missing phpdoc.

2. +++ b/core/lib/Drupal/Core/Menu/MenuLinkInterface.php
   @@ -228,4 +238,16 @@ public function getEditRoute();
   +   */
   +  public function getOperations(): array;
   +
   

   OK it is because the interface method is added here. 1-1 rule so method addition is fine.

3. +++ b/core/modules/menu_link_content/src/Plugin/Menu/MenuLinkContent.php
   @@ -185,23 +192,50 @@ public function getDescription() {
       */
      public function getTranslateRoute() {
   +    // TODO get link from ListBuilder values?
        return $this->getEntity()->toUrl('drupal:content-translation-overview');
      }
   

   Should this todo be resolved by this issue?

Addressed #39

- Attempting to fix the third suggestion in comment #39
Pulling translate link from operations.
I run all the test cases of `menu_link_conten` module on local and those are passing now.

The last submitted patch, 41: 2684577-41.patch, failed testing. View results →

Moving back to Needs review since last failure was un-related and was from CkEditor5 module.
I triggered re-test and it is passing now.

Both of those look good!

I did some formatting and minor text changes to the Change record.

Committed f693212 and pushed to 10.1.x. Thanks!

CR published

Automatically closed - issue fixed for 2 weeks with no activity.

There's a subtle API change here that broke a test in token module. Unlike the hardcoded logic before, the list builder checks access and doesn't return the edit route if the current user doesn't have access to it. The token tests didn't test this token with a logged in user, see 📌 Fix test fail on Drupal 10.1 Fixed .

I am leaving a comment for reference and awareness. During today's usability meeting 📌 Drupal Usability Meeting 2024-02-16 Active we were discussing ✨ Warn user when entity delete will cause menu item re-parenting Needs review . During the testing we've noticed the following issue i've created a followup issue for: 🐛 Menu links created by a view have a visually and functionally broken delete option Active . During the meeting we've tested on a install of Drupal 11.x. While writing up the followup I've tested on a install of Drupal 10.1.0 - the problem already existed there as well.