Support enclosure field in Views RssFields row plugin

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Fixed failed commands on #52
Attached patch against Drupal 10.1.x

Got this error "Call to undefined function Drupal\views\Plugin\views\row\file_create_url()" :'( file_create_url depreciated in drupal 10.0

For the CC failure.

Also with the schema change will need an upgrade path.

Thanks.

parisek → closed merge request !1387

Seems really hard to rebase MR for current branch so closed it.

Found one issue - enclosure field is not translated we just get default language, probably we should implement EntityTranslationRenderTrait (like web/core/modules/views/src/Plugin/views/row/EntityRow.php)

Its seems to be validation issue This feed does not validate.

line 15, column 4: url must be a full URL: http://localhost:50654/sites/default/files/2023-10/point_3.png (5 occurrences) [help]

^

I've attached a patch modified from #56 which fixes the D10 deprecation errors when using the file_create_url() method.

Works with D10.1

Imporved patch to have correct dependency injection and better support for getAbsoluteUrl

Add missing param description

Correct naming

I've tested the patch at #67 and it's working for me on D10.1.6

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

while patch from #67 fixes the issue and enclosure tag with image can be provided, there are no such things possible for the enclosure field as rewriting results or no results behavior.

I was in need to provide a second field as a callback for the enclosure in case the first field is empty.

I have therefore amended the patch to optionally configure a second enclosure field as fallback.

I do not want to endorse this as a clean solution, so I am hiding the patch, but provide it here in case someone might be need of something similar and also to remind us, that maybe more flexibility with enclosure field would be great.

Thanks stefan for your latest patch and thoughts. It sounds like we need to make a decision on whether the current patch is acceptable or if an approach inspired by yours that is more flexible needs to be done.

Personally, I am ok with the simpler, existing approach but defer to the Views maintainers and broader community.

I've updated the remaining tasks section with my understanding of where to go from here.

kekkis → changed the visibility of the branch 11.x to hidden.

I have now created two new branches, one based on 11.x and another on 10.2.x. Attaching patch for 10.2.x too (applies cleanly to 10.1.x as well). Leaving as NW since I haven't (yet) had time to add tests.

I made the choice to continue work on the patch at #70 instead of #67 since it seemed to be the more complete solution.

gfbarbosa → changed the visibility of the branch 2511878-support-enclosure-field to active.

gfbarbosa → changed the visibility of the branch 11.x to active.

gfbarbosa → changed the visibility of the branch 11.x to hidden.

gfbarbosa → changed the visibility of the branch 2511878-support-enclosure-field to hidden.

gfbarbosa → changed the visibility of the branch 10.3.x to hidden.

I created a new updated branch for 10.3.x with previous commits from #76 ✨ Add support for enclosure field in Views RssFields row plugin so that posts can include media items Needs work .

Added "Needs subsystem maintainer review" based on the summary and #70

In my opinion we shouldn't provide a fallback field, it's not like we provide one for any of the other fields, right? So I would opt to keep this as simple as possible and just stick to one field
Just my opinion, so feel free to ignore, but consider this reviewed by a subsystem maintainer

Alright, agreed.

I've removed the fallback alt option from #82 and created a new patch for 10.3. If this is the satisfied approach I can also updated the existing MR's or create new ones. Not sure whats where the right approach because if the existing MR's are updated the fallback functionality is removed and some people could depend on them.

@timohuisman's page (#85) works for me. Thank you.

May be the first one of referenced entities may be we can add reset to get the first one

$referenced_entities = reset($enclosure->referencedEntities());
$file = $referenced_entities->get('thumbnail')->entity;

here the new patch