🇬🇧United Kingdom @Hebl

Hey @saschaeggi,

I've checked this on both 8.x-3.x and 4.0x and all looks good. Added a new boolean field and that updates as expected.

MacOS
Firefox version: 126.0.1

I've attached a video showing the test results.

Cheers

Hey @saschaeggi,

This looks good to me. I've attached a video showing the feature working nicely.

Tested on:

• Chrome: Version 126.0.6478.115
• MacOS 14.3.1

Also tested editing an article on an iPhone SE, and whilst this feature isn't active on mobile - can't see any bugs that have been introduced.

Thanks for the work on this.

Thanks for the response @very_random_man, much appreciated.

trees:lion, trees:dog, trees:maple, trees:oak
to
animals:lion, animals:dog, trees:maple, trees:oak

Doing this is exactly what I need to do, but within the event subscriber (at least in the version I'm working with), every active facet item is always showing as trees:maple, trees:dog, trees:oak, trees:fish.

On the items where we'd need to change it from trees:dog => animals:dog, there is no identifier in there for me to identify that the facet belongs to animals.

I'll keep digging, thanks again for your help. :)

Hey @very_random_man,

Thanks a lot for your code and explanation. Not sure if something has changed in the module code since you did it, but I'm struggling to work out which facet the selected facet item comes from.

All of the facet appears to have the original ID of XXXXX, even if it comes from a YYYYY facet block.

I'm having the same issue as @hexabinaer and @dantesinferno.

Also seeing an issue with facets being combined when two content types share the same taxonomy reference.

In my case, the combination of the terms are shown in the filter block, but results only show when the filter term is from the original facet (the one I've selected "combine facets" on.

If I select a filter term from one of the combined facets, even if the term shows 4 results i.e Newsletter (4), when selecting the facet there are no results shown.

Hey @mably,

One very minot change requested.

Thanks

Hey,

I can also confirm that the changes in #19 and MR !88 fixed this issue for our case.

Changing status to RTBC.

Thanks to @KurtTrowbridge for your work on this.

Thanks @saschaeggi, I've tested the update and fix is applied. :)

Not sure whether this is the best fix, but setting the position attribute of the table to be "relative", before it's then set to "sticky" appears to remove the unwanted horizontal scroll for me in Chrome. See screenshot attached.

Hey @saschaeggi,

The table scrolls horizontally as expected both when in sticky mode and not in sticky mode. So that's all good.

However, I'm experiencing a horizontal scroll outside of the table too. I'll upload a screen recording showing what I mean. [gin-roles-horizontal-scroll.mp4]

Macbook 15", Chrome.

My mistake, the issue was coming from a patch for another issue which I've now re-rolled.

https://www.drupal.org/project/field_config_cardinality/issues/3274567#c... 🐛 CardinalityMediaLibraryWidget does not work with base field RTBC

Hey,

I've re-rolled the patch in #3 to add back the type casting to the $cardinality variable.

This is needed to stop a failure in type comparison on line 473 of /core/modules/media_library/src/Plugin/Field/FieldWidget/MediaLibraryWidget.php.

Thanks

Luke

Hebl → created an issue.

I can confirm what @jrochate said above.

Using these versions:
- Drupal 10.2.2
- Quick Node Clone 1.17
- Layout Paragraphs 2.0.4
- Paragrapghs 1.17

...Patch #14 by @DamienMcKenna works, and paragraphs within sections are now being cloned correctly.

I'm not sure what the next steps are here regarding getting it merged. The code in the patch suggests it should ideally live in the layout_paragraphs module

Thanks to @DamienMcKenna for the patch :)

Hello,

I've installed and tested this and it's working as expected my end.

Have you checked your JavaScript console to check if any other errors are blocking the execution of this module code?

Hebl → created an issue.

I've applied the patch provided by @mihaiprodann and can confirm that the password strength checks are now being made when no roles are selected in the config.

Moving to RTBC.

Closing, not needed.

Hey @sanduhrs,

Thanks a lot for adding the fix into 8.x-1.x, much appreciated.

Removing the user_password() does not cause a fatal (for me anyway). Having it left in on Drupal 10 however did cause the fatal error.

Thanks again!

I've added a patch which removes the password addition line for those who want to use the 8.x-1.3 version.

I've attached a patch modified from #56 which fixes the D10 deprecation errors when using the file_create_url() method.

Works with D10.1

Hey @saschaeggi,

Would you mind taking another look at this now it's been fixed and tested by the community?

Thanks

Luke

Hey @saschaeggi,

I've added a small change to the existing MR which corrects the previous issue with the focus being cut off.

I've checked this on both the horizontal and vertical toolbar.

Please could you take another look? Thanks!

Ooops, didn't spot that. Sorry @saschaeggi. Will take a look for a fix this afternoon.

+1 LGTM, moving to RTBC

Nice work @bnjmnm!

Hebl → created an issue.

LGTM

ipwa → credited Hebl → .

@smustgrave,

Didn't comments #7 and #8 update the requirements of the task to something different to the issue summary?

Hey @smustgrave,

Ran the tests again and they’ve passed this time.

Is this ready for review now?

Understood, apologies. Don't have much experience with tests and failures but will take a look.

Reviewed the patch. looks good to me!

Maybe something like this:

Notice.
Due to the deprecation of the V1 Twitter API the functionality in this module is limited to posting new tweets only.

The Twitter v2 API is much more limited in what it can do on a free plan.

The v1 API was deprecated and shut down on 29th June 2023.

Currently v2 only allows login to an account and to post tweets, so a lot of this module will not be functional.

With this in mind and given this is a Drupal 7 module I'm not sure it's worth anyones time rewriting for the v2 API?

Perhaps we could update the module description at least to warn people of the API changes?

@smustgrove, Unless I'm mistaken, it looks to me like @bharath-kondeti has added a new commit to the original MR, which addresses the issue: Merge request !4128.

Hey guys, I wasn't sure whether the changes to "Administrative summary" was agreed for all of the fields in the table in the original description. Or whether it was just for the two Menu and custom block.

I've added an MR which addresses the Custom block.

Happy to take another look if we want to change for all of the rows in the table. Cheers!

Hebl → made their first commit to this issue’s fork.

Hey @smustgrave,

Completely missed that other line, apologies! I've created a new MR which removes both lines. Thanks!

Hey,

I've removed the trailing comma in MR19.

Please could somebody take a look?

Thanks!

Hebl → made their first commit to this issue’s fork.

Reviewed and looks good to me!

LGTM, but unsure whether the variable should be used.

Changing to needs review.

Reviewed patch and MR. LGTM

Thanks a lot for your contribution @Ranjit1032002. I tested the changes and can confirm they work.

I made a few really small tweaks to change a few characters to uppercase, but otherwise all good.

Thanks also to @ipwa for assistance with the testing.

Thanks again!

Hebl → made their first commit to this issue’s fork.

Looks good to me. Updating status.

Hi,

I've uploaded a suggested logo for the config split module. Let me know if you would like any changes.

Thanks

Hey,

I've attached a potential logo for the Security Kit module. It's 512px x 512px and optimised.

Let me know if you'd like any changes, thanks.

I've uploaded a logo which is 512px x 512px which has been optimised. Let me know if it works and/or if any changes are required. Thanks

Proposed description:

"The Scheduler module allows content editors to schedule the publishing and/or unpublishing of content pages at a future date and time."

Hey guys, is there a timescale for when the new D10 ready version is published?

I can see the changes have been committed to 2.0.

Thanks!

Hebl → created an issue.