Unnecessary comma leads to exception

Created on 23 June 2023, about 1 year ago
Updated 26 June 2023, 12 months ago

Hello,

the latest update (alpha9) brought a syntax error in EntityAnalyser.php:

public function __construct(
    EntityTypeManagerInterface $entity_type_manager,
    RendererInterface $renderer,
    MetatagManagerInterface $metatag_manager,
    RouterInterface $router,
    ?ThemeManagerInterface $theme_manager = NULL,
    ?ThemeInitializationInterface $theme_initialization = NULL,
    ?ConfigFactoryInterface $configFactory = NULL,
  ) {

Note the trailing comma after ?ConfigFactoryInterface $configFactory = NULL. This leads to the following error when opening a node edit form:

The website encountered an unexpected error. Please try again later.
ParseError: syntax error, unexpected ')', expecting variable (T_VARIABLE) in Composer\Autoload\{closure}() (line 91 of modules/contrib/yoast_seo/src/EntityAnalyser.php).
Composer\Autoload\{closure}('/var/www/html/app/web/modules/contrib/yoast_seo/src/EntityAnalyser.php') (Line: 433)
Composer\Autoload\ClassLoader->loadClass('Drupal\yoast_seo\EntityAnalyser')
spl_autoload_call('Drupal\yoast_seo\EntityAnalyser') (Line: 259)
Drupal\Component\DependencyInjection\Container->createService(Array, 'yoast_seo.entity_analyser') (Line: 177)
Drupal\Component\DependencyInjection\Container->get('yoast_seo.entity_analyser') (Line: 55)
Drupal\yoast_seo\Form\AnalysisFormHandler::createInstance(Object, Object) (Line: 269)
Drupal\Core\Entity\EntityTypeManager->createHandlerInstance('Drupal\yoast_seo\Form\AnalysisFormHandler', Object) (Line: 258)
Drupal\Core\Entity\EntityTypeManager->getHandler('node', 'yoast_seo_preview_form') (Line: 171)
Drupal\yoast_seo\Plugin\Field\FieldWidget\YoastSeoWidget->formElement(Object, 0, Array, Array, Object) (Line: 353)
Drupal\Core\Field\WidgetBase->formSingleElement(Object, 0, Array, Array, Object) (Line: 220)
Drupal\Core\Field\WidgetBase->formMultipleElements(Object, Array, Object) (Line: 111)
Drupal\Core\Field\WidgetBase->form(Object, Array, Object) (Line: 183)
Drupal\Core\Entity\Entity\EntityFormDisplay->buildForm(Object, Array, Object) (Line: 121)
Drupal\Core\Entity\ContentEntityForm->form(Array, Object) (Line: 127)
Drupal\node\NodeForm->form(Array, Object) (Line: 106)
Drupal\Core\Entity\EntityForm->buildForm(Array, Object)
call_user_func_array(Array, Array) (Line: 536)
Drupal\Core\Form\FormBuilder->retrieveForm('node_clinic_edit_form', Object) (Line: 283)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
πŸ› Bug report
Status

Fixed

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024