defcon0 → created an issue.
Works for me.
Ah, I searched for issues but didn't find that one. Yes, then it can be closed.
An example hook implementation would be:
/**
* Add content moderation actions as sticky actions.
*/
#[Hook('gin_extend_sticky_form_actions')]
public function ginExtendStickyFormActions(array $actions): array {
foreach (array_keys($this->config_factory->get('workflows.workflow.content_moderation')->get('type_settings.states')) as $state) {
$actions[] = 'moderation_state_' . $state;
}
return $actions;
}
defcon0 → created an issue.
I just integrated this in a new project and stumbled upon an open issue concerning the latest patch:
Having a setup where Media entities are translatable as well as the file itself. Now we have a media entity with the default language and a translation with another one. Both translations have the same file, only the description text differs.
Deleting the original language works as desired as both languages are deleted.
But after deleting the non-original translation, we get a problem: then it deletes the linked file although it's still linked to the original translation and now we have a media record without a real file associated :/
Maybe in this case we just "fail" silently and skip deleting the associated file?
OK, just created MR 603 adding search_block_form in addition to 'workflow-transition-'. Now also working for our use case.
Having such an inflexible form_id black list doesn't seem to be a good solution though.
defcon0 → changed the visibility of the branch 3464716-ignore_workflow_transition_form to active.
defcon0 → changed the visibility of the branch 3464716-ignore_workflow_transition_form to hidden.
Problem still persists here. For us it's Search coming from somewhere:
After restoring the function from 3.0.0-rc14, it works well again:
https://git.drupalcode.org/project/gin/-/blob/8.x-3.0-rc14/includes/form...
Duplicate of https://www.drupal.org/project/config_split/issues/3492375 📌 Nullable types must be explicit Active
I still get warnings after using cex in a php 8.4/drupal 11 environment:
PHP Deprecated: Drupal\symfony_mailer\Processor\OverrideManager::getInfo(): Implicitly marking parameter $filterId as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/symfony_mailer/src/Processor/OverrideManager.php on line 153
Deprecated: Drupal\symfony_mailer\Processor\OverrideManager::getInfo(): Implicitly marking parameter $filterId as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/symfony_mailer/src/Processor/OverrideManager.php on line 153
PHP Deprecated: Drupal\symfony_mailer\Processor\OverrideManagerInterface::getInfo(): Implicitly marking parameter $filterId as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/symfony_mailer/src/Processor/OverrideManagerInterface.php on line 62
Deprecated: Drupal\symfony_mailer\Processor\OverrideManagerInterface::getInfo(): Implicitly marking parameter $filterId as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/symfony_mailer/src/Processor/OverrideManagerInterface.php on line 62Seems like we need to change the type hint, as well:
public function getInfo(string $filterId = NULL);
to
public function getInfo(?string $filterId = NULL);
Should I create a new patch/mr?
defcon0 → created an issue.
Rerolled #79 for simple_sitemap 4.2.2
Ah, I see, it needs to be in a theme not in a module. Sadly the module contains nearly zero documentation :(
Mhm, for some reason the hook isn't called in my module (but other hooks are):
function m_module_csp_policy_alter(\Drupal\csp\Csp $policy, \Symfony\Component\HttpFoundation\Response $response) {
// Add nonce value to CSP.
/** @var \Drupal\csp\PolicyHelper $policy_helper */
$policy_helper = \Drupal::service('csp.policy_helper');
$policy_helper->appendNonce($policy, 'style', ['unsafe-inline']);
$policy_helper->appendNonce($policy, 'script', ['unsafe-inline']);
}
Am I doing something wrong?
defcon0 → created an issue.
Rerolled #73 for simple_sitemap 4.2.1
Defcon0 → created an issue.
If that's a relevant info: I have gin theme installed.
Defcon0 → created an issue. See original summary → .
Reroll for v1.3.1
At first, thanks for the patch, works great so far :) One thing still not working is that if the field references a media element containing an image file upload, in the translation record I can't delete the referenced item but only edit it.
Not sure if this only applies to referenced media entities but also for other ones.
Does anyone else have this behavior?
Sorry for the late answer, I didn't receive notification mails although activated :/
In the translation there is no such link as you describe.
Only in the default language there is.
@saschaeggi Do you have an advice where to start debugging?
Defcon0 → created an issue.
@danflanagan8
The release doesn't contain the fix even though in the git repo it is. Strange. Please check the ZIP on
https://www.drupal.org/project/viewfield/releases/8.x-3.0-beta8 →
Defcon0 → created an issue.
Defcon0 → created an issue.
Don't know whether it would be better to create a new issue for this, but I created a simple cron in the module for deleting messages older than 30 days as a cron.
Sorry, first one didn't have the correct paths.
New patch for 10.2.5
Rerolled #71 for simple_sitemap 4.1.9 fixing the issue
PHP Fatal error: Cannot redeclare simple_sitemap_update_8408() (previously declared in /var/www/html/app/web/modules/contrib/simple_sitemap/simple_sitemap.install:942) in /var/www/html/app/web/modules/contrib/simple_sitemap/simple_sitemap.install on line 967
Rerolled #72 for simple_sitemap 4.1.9 fixing the issue
PHP Fatal error: Cannot redeclare simple_sitemap_update_8408() (previously declared in /var/www/html/app/web/modules/contrib/simple_sitemap/simple_sitemap.install:942) in /var/www/html/app/web/modules/contrib/simple_sitemap/simple_sitemap.install on line 967
Ah, I just noted that the problem is a patch referenced in https://www.drupal.org/project/simple_sitemap/issues/3080541 ✨ Exclude content with a "noindex" robots meta tag Closed: won't fix . I comment there
Defcon0 → created an issue.
Defcon0 → created an issue.
Defcon0 → created an issue.
I just compared version 2.1.3 with the previous 2.1.2. The line that causes the issue is
https://git.drupalcode.org/project/stage_file_proxy/-/compare/2.1.2...2....
If I revert that to what it was before, it works again. I created a patch for that for the meantime.
Defcon0 → made their first commit to this issue’s fork.
Defcon0 → created an issue.
At first a big thanks to this new feature. Made parts of our custom implementation obsolete :)
Only one thing bothers me: why is the replacement character only trimmed at the right side of the filename and not on the left one, as well?
https://github.com/drupal/core/blob/10.2.x/modules/file/src/EventSubscri...
I think filenames like -some-filename.png are not so nice. What has been the reason to implement it that way? Couldn't find info in this issue log.
OK, now it works. I needed to regenerate the node access using /admin/reports/status/rebuild . Would've been cool if that was stated somewhere :-/ Found it in a very old video.
I just installed the module and it's quite great. Only thing bothering me is that export config is stored per user and not in yml config. This is not practicable in a multi user setup. A default config on a node type basis would be highly appreaciated.
I rerolled #71 for a setup with metatags v2 replacing the unserialize() calls by json_decode().
Defcon0 → created an issue.
Same here.
Defcon0 → created an issue.
@camvertiz : Why does your match contain much less code than the Merge request (https://git.drupalcode.org/project/simple_sitemap/-/merge_requests/52.patch)?
Defcon0 → created an issue.
One thing maybe to consider is also checking rewrites/redirects. In my current setup I have some URLs in the sitemap leading to nodes having noindex set. Is there reasonable any way to avoid that?