- Merge request !23Issue #3080541: Exclude content with a "noindex" robots meta tag โ (Closed) created by s_leu
- Merge request !52Issue #3080541 by gbyte: Exclude content with a "noindex" robots meta tag โ (Closed) created by d70rr3s
One thing maybe to consider is also checking rewrites/redirects. In my current setup I have some URLs in the sitemap leading to nodes having noindex set. Is there reasonable any way to avoid that?
- last update
over 1 year ago 32 pass - ๐ฆ๐ทArgentina camvertiz
This patch is working for v4.1.2. I updated the return statement for the
getMetatagFieldFor
method which was given a PHP warning for content types that don't have any field of type "metatag". @camvertiz : Why does your match contain much less code than the Merge request (https://git.drupalcode.org/project/simple_sitemap/-/merge_requests/52.patch)?
- last update
over 1 year ago 5 pass, 2 fail - ๐ฉ๐ชGermany uniquename Berlin
Find a patch attached, that applies against 4.1.6
The last submitted patch, 62: simple_sitemap-add_noindex_support-3080541-62.patch, failed testing. View results โ
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs work
over 1 year ago 11:04am 7 July 2023 - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago PHPLint Failed - last update
over 1 year ago PHPLint Failed - ๐ฎ๐ณIndia samiksha.gupta008
Resolved Fatal error: Cannot redeclare simple_sitemap_update_8407() (previously declared modules/contrib/simple_sitemap/
simple_sitemap.install:948) - ๐ณ๐ฑNetherlands Lendude Amsterdam
Metatag 2.x now uses JSON data, so the unserialize needs to be changed to json_decode if you want this to work with Metatag 2.x. This is exactly why this should probably be in its own module.
- Status changed to Closed: won't fix
about 1 year ago 8:29am 17 August 2023 - ๐ฉ๐ชGermany gbyte Berlin
Given the wide ranging code changes, the performance hit, metatag's flaky API and given that several people agree this should be worked on in a 3rd party glue module, I'm closing this issue. Anyone interested please create a sandbox and let us know in this here issue. Thanks for all of your input!
- ๐บ๐ธUnited States mariacha1
Rerolling the patch from #67 without the double reference to
$entityFieldManager;
- ๐บ๐ธUnited States mariacha1
Last patch still had a duplicate function in it.
I rerolled #71 for a setup with metatags v2 replacing the unserialize() calls by json_decode().
Rerolled #72 for simple_sitemap 4.1.9 fixing the issue
PHP Fatal error: Cannot redeclare simple_sitemap_update_8408() (previously declared in /var/www/html/app/web/modules/contrib/simple_sitemap/simple_sitemap.install:942) in /var/www/html/app/web/modules/contrib/simple_sitemap/simple_sitemap.install on line 967
Rerolled #71 for simple_sitemap 4.1.9 fixing the issue
PHP Fatal error: Cannot redeclare simple_sitemap_update_8408() (previously declared in /var/www/html/app/web/modules/contrib/simple_sitemap/simple_sitemap.install:942) in /var/www/html/app/web/modules/contrib/simple_sitemap/simple_sitemap.install on line 967