🇪🇸Spain @d70rr3s

d70rr3s → created an issue.

I've refactored the AiAgentBase class and updated Module and Webform since they were in part implementing the plugin factory pattern. Tests and probably more work needs to be done.

I've stop on this recently. Even though this under heavy development right now I will go and work on this weekend and provide a MR updating all the system to be compatible with the Plugin API.

Thrilled to participate in this session.

d70rr3s → created an issue.

d70rr3s → created an issue.

d70rr3s → created an issue.

This only introduces minimal changes to be dowloaded and enabled. Write now the .install contains leftover code from a previous refactor and I sincerely doubt that the module will work out of the box with D10+. I will open another issue to work on that.

Running drupal-rector

[file] /var/www/html/web/modules/contrib/certificatelogin/certificatelogin.install
[file] /var/www/html/web/modules/contrib/certificatelogin/certificatelogin.module
[file] /var/www/html/web/modules/contrib/certificatelogin/src/Annotation/CaSignatureVerificationPlugin.php
[file] /var/www/html/web/modules/contrib/certificatelogin/src/Controller/CertificateLoginController.php
[file] /var/www/html/web/modules/contrib/certificatelogin/src/Form/CertificateLoginSettingsForm.php
[file] /var/www/html/web/modules/contrib/certificatelogin/src/Form/ConfirmForm.php
[file] /var/www/html/web/modules/contrib/certificatelogin/src/Form/LoginForm.php
[file] /var/www/html/web/modules/contrib/certificatelogin/src/Plugin/Block/CertificateLoginBlock.php
[file] /var/www/html/web/modules/contrib/certificatelogin/src/Plugin/CaSignatureVerificationPlugin/PHPSecLib.php
[file] /var/www/html/web/modules/contrib/certificatelogin/src/Plugin/CaSignatureVerificationPluginBase.php
[file] /var/www/html/web/modules/contrib/certificatelogin/src/Plugin/CaSignatureVerificationPluginInterface.php
[file] /var/www/html/web/modules/contrib/certificatelogin/src/Plugin/CaSignatureVerificationPluginManager.php
[file] /var/www/html/web/modules/contrib/certificatelogin/src/Plugin/Menu/LoginLogoutMenuLink.php
[file] /var/www/html/web/modules/contrib/certificatelogin/src/Service/LoginRegisterService.php
[file] /var/www/html/web/modules/contrib/certificatelogin/tests/src/Functional/LoadTest.php

1 file with changes
===================

1) web/modules/contrib/certificatelogin/tests/src/Functional/LoadTest.php:12

    ---------- begin diff ----------
@@ @@
 class LoadTest extends BrowserTestBase {

   /**
+   * {@inheritdoc}
+   */
+  protected $defaultTheme = 'stark';
+
+  /**
+   * {@inheritdoc}
+   */
+  protected $defaultTheme = 'stark';
+
+  /**
    * Modules to enable.
    *
    * @var array
    */
-  public static $modules = ['certificatelogin'];
+  protected static $modules = ['certificatelogin'];

   /**
    * A user with permission to administer site configuration.
@@ @@
   /**
    * {@inheritdoc}
    */
-  protected function setUp() {
+  protected function setUp(): void {
     parent::setUp();
     $this->user = $this->drupalCreateUser(['administer site configuration']);
     $this->drupalLogin($this->user);
    ----------- end diff -----------

Applied rules:
 * FunctionalTestDefaultThemePropertyRector
 * ProtectedStaticModulesPropertyRector
 * AddReturnTypeDeclarationRector


 [OK] 1 file would have been changed (dry-run) by Rector                                                                

Running upgrade_status analyse

================================================================================
Certificate Login, --
Scanned on Sat, 10/05/2024 - 16:01

FILE: web/modules/contrib/certificatelogin/tests/src/Functional/LoadTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 13   Drupal\Tests\BrowserTestBase::$defaultTheme is required. See
                    https://www.drupal.org/node/3083055, which includes         
                    recommendations on which theme to use.                      
--------------------------------------------------------------------------------
Check manually 20   Property                                                    
                    Drupal\Tests\certificatelogin\Functional\LoadTest::$modules 
                    property must be protected.                                 
--------------------------------------------------------------------------------

FILE: web/modules/contrib/certificatelogin

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    The 'certificatelogin' extension is not installed. Cannot   
                    check deprecated library use.                               
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/certificatelogin/src/Plugin/Block/CertificateLoginBlock.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 39   The 'certificatelogin/certificatelogin' library is not      
                    defined because the defining extension is not installed.    
                    Cannot decide if it is deprecated or not.                   
--------------------------------------------------------------------------------

FILE: web/modules/contrib/certificatelogin/certificatelogin.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 5    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

d70rr3s → created an issue.

+1

+1

+1

d70rr3s → created an issue.

Ah, I see. @sonfd explains it in here 📌 Copy block configuration from admin theme when enabling an admin theme Active , is how the block module behaves when installing a new theme :/

Just to shed some light on the matter. I'm facing the same issue in this case with GIn theme but, I don't have a gin: * in my recipe. This is my actual code:

name: Admin UI
type: Standard
description: Sets up a nice administrative theme and navigation.
install:
  - coffee
  - gin
  - gin_login
  - gin_toolbar
  - navigation
config:
  import:
    coffee:
      - coffee.settings
    gin:
      - gin.settings
    gin_login:
      - gin_login.settings
    navigation: "*"
  actions:
    system.theme:
      simple_config_update:
        admin: gin

Probably blocks by Gin are getting imported even if you explicitly ask for it. Probably a bug somehow?

+1

Worth adding to the proposed solution a way to validate those schema against real YAML files in Drupal core. I would say that we could have CI pipeline that triggers tests like this, this Grunt task takes the schema definition and it's test sample file (a YAML of a config entity for example) and checks if the YAML matches the schema.

+1

I can volunteer as backend developer from Spain.

Thanks, now I can edit the page.

d70rr3s → created an issue.

Sorry, for some reason I read the git log wrong and thought I pushed the new branch.

Rebased from 11.x into 2916876-11.x, but not getting the MR button on the issue page

d70rr3s → changed the visibility of the branch 10.1.x to hidden.

d70rr3s → changed the visibility of the branch 9.2.x to hidden.

d70rr3s → changed the visibility of the branch 11.x to hidden.

d70rr3s → made their first commit to this issue’s fork.

The patch is not correct, it changes implementation's signature directly without any research.

The interface in core Drupal\ckeditor5\Plugin\CKEditor4To5UpgradePluginInterface::mapCKEditor4ToolbarButtonToCKEditor5ToolbarItem have changed to current signature `public function mapCKEditor4ToolbarButtonToCKEditor5ToolbarItem(string $cke4_button, HTMLRestrictions $text_format_html_restrictions): ?array` which is the same implemented by the module.

The interface was changed on core 9.4 and 10.0.x and backported to 9.3, check this comment here → .

The signature displayed on the error message dates back to 9.3 initial release, check this commit.

Also cannot reproduce the error using the issue with the proposed versions.

Speakers I'm aware of:

• * OpenEuropa (OE) components: OE Link Lists by Daniel Sipos
• * Un "core" para gobernarlos a todos: Búsquedas distribuidas con Solr y Drupal by Daniel Cimorra
• * La IA como copiloto en Drupal by Dennis Torres
• * Transformación Ágil a Escala: Liderando +150 Expertos en Drupal en Proyectos Globales by Adrián Marin & Alex Arnau
• * No me hagas pensar: UX/UI para desarrolladores by Sergio Llorente

Please, @rescudero, use MR1!, instead of creating a new one. To do so, use the "Get push access" button from the Issues fork section above. When you're ready, close MR4!

d70rr3s → made their first commit to this issue’s fork.