Fix integration with content moderation in multi-lingual scenarios

#11 is in
tnx

The patch #8 creates /src/Tests/ContentModerationTranslationTest.php. ContentModerationTranslationTest extends InlineEntityFormTestBase which is not defined in this namespace.

This breaks automatic tests on the 2.0.x branch:

PHP Fatal error: Uncaught Error: Class "Drupal\inline_entity_form\Tests\InlineEntityFormTestBase" not found in /var/www/html/modules/contrib/inline_entity_form/src/Tests/ContentModerationTranslationTest.php:12

See this result for example: https://www.drupal.org/pift-ci-job/2666453 →

The test in ContentModerationTranslationTest.php and InlineEntityFormTestBase require some refactoring, as InlineEntityFormTestBase extends WebDriverTestBase.

ContentModerationTranslationTest.php requires a use Drupal\Tests\inline_entity_form\FunctionalJavascript\InlineEntityFormTestBase; and the deprecated calls to drupalPostAjaxForm(..) need to replaced with drupalPostForm.

See https://www.drupal.org/docs/automated-testing/converting-simpletests-to-... → .

https://www.drupal.org/pift-ci-job/2668244 →

> Drupal\Core\Composer\Composer::upgradePHPUnit
PHP Fatal error:  Declaration of Drupal\inline_entity_form\Tests\ContentModerationTranslationTest::setUp() must be compatible with Drupal\Tests\inline_entity_form\FunctionalJavascript\InlineEntityFormTestBase::setUp(): void in /var/www/html/modules/contrib/inline_entity_form/src/Tests/ContentModerationTranslationTest.php on line 30

setUp() must be defined as protected function setUp(): void {

I also see some other errors when I open ContentModerationTranslationTest.php in Vscode:

Undefined method 'drupalPostAjaxForm'
Undefined method 'drupalPostAjaxForm'
Undefined method 'assertTrue'

Thank you @shivam_tiwari. Did not run a test but code looks good to me now.

@podarok, could you please merge and run a test?

merged
checking

run https://www.drupal.org/pift-ci-job/2668358 →

Automatically closed - issue fixed for 2 weeks with no activity.

Bulk reopen.

For me some fields where not hidden when they should've been hidden. Updated the patch from #11 to fix that.

At first, thanks for the patch, works great so far :) One thing still not working is that if the field references a media element containing an image file upload, in the translation record I can't delete the referenced item but only edit it.

Not sure if this only applies to referenced media entities but also for other ones.

Does anyone else have this behavior?