[a11y] Focus state not visible for "Home" icon in toolbar.

Created on 11 July 2023, over 1 year ago
Updated 19 August 2023, over 1 year ago

Problem/Motivation

All the other toolbar items have a nice focus outline, but the home link does not.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.
  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

Sign in to follow issues

Comments & Activities

  • Issue created by @bnjmnm
  • @bnjmnm opened merge request.
  • Status changed to Needs review over 1 year ago
  • 🇺🇸United States bnjmnm Ann Arbor, MI

    The changes in the MR makes it so the focus state matches that of the other items in the toolbar.

  • 🇮🇳India Harish1688 India

    Hi,

    Tested the MR !272 to address the issue where the focus outline was not appearing on the home link. it's now works perfectly fine in both vertical and horizontal views.

    Testing Steps:
    1. Install the Drupal 10.0.x version and enable gin 8.x.
    2. switch to MR and verified the changes.

    attached the screen for references.

    Looks Good for RTBC

  • Status changed to RTBC over 1 year ago
  • 🇬🇧United Kingdom hebl

    +1 LGTM, moving to RTBC

    Nice work @bnjmnm!

  • Status changed to Needs work over 1 year ago
  • 🇨🇭Switzerland saschaeggi Zurich

    Moving this back to needs work as the focus cuts off when using the vertical toolbar.

  • 🇬🇧United Kingdom hebl

    Ooops, didn't spot that. Sorry @saschaeggi. Will take a look for a fix this afternoon.

  • Status changed to Needs review over 1 year ago
  • 🇬🇧United Kingdom hebl

    Hey @saschaeggi,

    I've added a small change to the existing MR which corrects the previous issue with the focus being cut off.

    I've checked this on both the horizontal and vertical toolbar.

    Please could you take another look? Thanks!

  • 🇮🇳India lokeshsahu Delhi

    Reviewing this issue.

  • Status changed to RTBC over 1 year ago
  • 🇮🇳India lokeshsahu Delhi

    I have tested the recent MR #7 to verify the issue mentioned in #6 and it is working fine without getting cut off while on focus on the vertical toolbar. The MR works totally fine for the horizontal toolbar as well. I am attaching a screenshot for reference after applying the MR.
    Looks Good for RTBC++

  • 🇬🇧United Kingdom hebl

    Hey @saschaeggi,

    Would you mind taking another look at this now it's been fixed and tested by the community?

    Thanks

    Luke

  • 🇨🇭Switzerland saschaeggi Zurich

    Great work, thanks 👏

  • Status changed to Fixed over 1 year ago
  • 🇨🇭Switzerland saschaeggi Zurich
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024