- Issue created by @bnjmnm
- @bnjmnm opened merge request.
- Status changed to Needs review
over 1 year ago 5:31pm 11 July 2023 - 🇺🇸United States bnjmnm Ann Arbor, MI
The changes in the MR makes it so the focus state matches that of the other items in the toolbar.
- 🇮🇳India Harish1688 India
Hi,
Tested the MR !272 to address the issue where the focus outline was not appearing on the home link. it's now works perfectly fine in both vertical and horizontal views.
Testing Steps:
1. Install the Drupal 10.0.x version and enable gin 8.x.
2. switch to MR and verified the changes.attached the screen for references.
Looks Good for RTBC
- Status changed to RTBC
over 1 year ago 1:11pm 14 July 2023 - Status changed to Needs work
over 1 year ago 1:29pm 14 July 2023 - 🇨🇭Switzerland saschaeggi Zurich
Moving this back to needs work as the focus cuts off when using the vertical toolbar.
- 🇬🇧United Kingdom hebl
Ooops, didn't spot that. Sorry @saschaeggi. Will take a look for a fix this afternoon.
- Status changed to Needs review
over 1 year ago 11:30am 17 July 2023 - 🇬🇧United Kingdom hebl
Hey @saschaeggi,
I've added a small change to the existing MR which corrects the previous issue with the focus being cut off.
I've checked this on both the horizontal and vertical toolbar.
Please could you take another look? Thanks!
- Status changed to RTBC
over 1 year ago 8:32am 18 July 2023 - 🇮🇳India lokeshsahu Delhi
I have tested the recent MR #7 to verify the issue mentioned in #6 and it is working fine without getting cut off while on focus on the vertical toolbar. The MR works totally fine for the horizontal toolbar as well. I am attaching a screenshot for reference after applying the MR.
Looks Good for RTBC++ - 🇬🇧United Kingdom hebl
Hey @saschaeggi,
Would you mind taking another look at this now it's been fixed and tested by the community?
Thanks
Luke
-
saschaeggi →
committed fce0b5fe on 8.x-3.x authored by
bnjmnm →
Issue #3373964: Focus state not visible for "Home" icon in toolbar.
-
saschaeggi →
committed fce0b5fe on 8.x-3.x authored by
bnjmnm →
- Status changed to Fixed
over 1 year ago 6:37pm 19 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.