- Issue created by @Prachi6824
- Assigned to Prachi6824
- Status changed to Needs review
over 1 year ago 1:33pm 28 June 2023 - 🇮🇳India Prachi6824
Hello,
I have created a patch to solve the errors related to t() calls .
Please review and apply it .
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 3:39pm 28 June 2023 - 🇺🇸United States montag64
Will get to this as soon as we can, thanks everyone!
- 🇮🇳India Raveen Kumar
@Prachi,
a) I have reviewed the code in the patch. The warning message you mentioned is related to Drupal coding standards and best practices. In Drupal, when working with translations, it is recommended to use the $this->t() method instead of the global t() function within classes.b) By using $this->t() instead of t() within classes, you ensure that the translation service is properly injected and available for use. It also improves the testability and maintainability of your code.
Your MR! is good to go. And Thank you.
- 🇮🇳India Prachi6824
Thank you @Raveen Thakur for you valuable feedback and reviewing my patch.
- @prachi6824 opened merge request.
- 🇮🇳India Harshita mehra
Hi, @prachi6824 MR !1 is mergeable and looks good.
Thanks! - 🇮🇳India Prachi6824
Thank you @Raveen Thakur for informing me . Now,i have added the commit in my MR.
-
allun55 →
committed 090ee8f2 on 1.0.x authored by
prachi6824 →
Resolve #3371046 "T()calls should be avoided"
-
allun55 →
committed 090ee8f2 on 1.0.x authored by
prachi6824 →
- Status changed to Fixed
over 1 year ago 3:32pm 3 July 2023 Patch has been merged. Thanks to everyone for the patch and for reviewing it.
- Status changed to Fixed
over 1 year ago 3:33pm 3 July 2023