🇮🇳India @Prachi6824

scott_euser → credited prachi6824 → .

prachi6824 → created an issue.

I have worked on this issue on now providing the patch to resolve this issue.
Please do review it and apply it.

Also,providing the after-patch screenshot.

prachi6824 → created an issue.

Thank you all for your contribution.

prachi6824 → created an issue.

Thanks for your contribution.

prachi6824 → made their first commit to this issue’s fork.

Thanks @djsagar @Bhupendra_Raykhere for reviewing my theme and contributing to it .

Hello @alok_singh,

I appreciate your effort you had put on to review my theme
but, I think this issue might be from your side only because
till now no such issue has been seen on other's site.
So, I'm gonna close this issue .

Hello @djsagar,

I have tested your patch it was applied successfully.
Hence changing the status to RTBC.

For reference attaching the screenshot:

Hello @Krati Arya ,

I have tested your patch .
It's working fine for me and I confirm that this patch has resolved this issue.
So, changing its status to RTBC.

For reference attaching the screenshot:

Hello @Krati Arya ,

I have tested your patch .
It's working fine for me and I confirm that this patch has resolved this issue.
So, changing its status to RTBC.

For reference attaching the screenshot:

Hello @djsagar,

I have also reviewed the patch#4 but that is not working as required.
As one of the header title field checkbox is still not working.
So, updating status to needs work.

Hello @djsagar,

I have tested your patch . It was applied cleanly and have resolved all the issues reported by phpcs --standard=Drupal,DrupalPractice command.

For reference providing the screenshot below.

prachi6824 → created an issue.

Hello VijaySharma_89,

I have worked on this issue and have created a patch to resolve it.
Please do review and apply it .

For Reference please look at the screenshot below which is taken after patch.

prachi6824 → created an issue.

Thanks for contributing to my theme.

I won't be fixing this issue as it is a part of theme design.

Thank you for your contribution.

Hello everyone thanks for you contribution.

Thank you for your contribution.

prachi6824 → made their first commit to this issue’s fork.

prachi6824 → created an issue.

I have worked on this issue and have created a patch to resolve it.

Please do review it and apply it .

prachi6824 → created an issue.

Ok @apaderno I will update the issue summary and will try elaborate the issue in a more precised way.

Hello @apaderno,

Thank for your suggestions Regarding patch contribution.
I 'll take care of such things and will not be going to repeat such mistakes from next time.

Hello @Abh1shek Chauhan,

Thank you for reviewing my patch .

Hello @Abh1shek Chauhan,

Thank you for testing my patch .

Hello @djsagar,

Actually, by mistake i skipped to assign you the credit.
I appreciate your efforts and time you had put on to test the patch and reviewing my theme.
Thank you for your contribution.

prachi6824 → made their first commit to this issue’s fork.

Hello @Akshay kashyap,

I have tested and applied your patch #6 and I confirmed
that your patch has fixed all the issues reported by PHP code sniffer.

Please look at the screenshot for your reference.

Hello @VijaySharma_89,

I have tested your patch and its working fine for me.
Please look at the screenshot for your reference

Thank you.

prachi6824 → created an issue.

Thank you @apaderno for reviewing my issue and your advice.
I will surely focus on the process of creating issues from next time .

Hello,

I have created a patch to solve this issue .
Please review and apply it .

Let me work on it and create a patch file to solve the issue .

prachi6824 → created an issue.

Hello,

I have created a patch to solve the issue.

Please review and apply it .

I will create a patch to solve the issue .

prachi6824 → created an issue.

Hello,

I have created a patch to solve the issue.

Please review and apply it .

I will create a patch to solve the issue .

prachi6824 → created an issue.

Hello,

I have created a patch to solve the issue.

Please review and apply it .

I will create a patch to solve the issue .

prachi6824 → created an issue.

Ok @apaderno I will work on the patch again and will recreate the patch to solve the issues.
Thank You.

Hello @bpstr,
I have created a merge request to merge the code for fixing the issue.
Thank You.

Updated issue summary again.

Hello,

I have created a patch to solve the issue.

Please review and apply it .

Let me work on the issue .

prachi6824 → created an issue.

Thank you @priyanka_angadi for reviewing my patch.

Problem/Motivation

There are issues found in the .module file which are reported by PHP code sniffer.
All the issues are mentioned above in the #1 comment issue summary.

Steps to reproduce:

1) Install the module.

2) Run this php code standard command to detect the errors reporeted by the php code sniffer.
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml /path/to/drupal/example_module

3) Mention the proper path of the .module file or the file in which you want to detect the error.

4) After running the command start solving the issues which are given by going to the line no. mentioned in the error.

5) For further better understanding of the issue please do refer the following link which tells @deprecated PHPdoc tag format :

https://www.drupal.org/about/core/policies/core-change-policies/drupal-d... →

Proposed resolution:

Edit the code and solve the issue by implementing the correct code format.

Hello @apaderno,

I will go through my summary again and will update it with more clarifications.
Thank you for reviewing my summary.

Hello @allun55,
I have created a merge request to merge the code for fixing the issue.
Thank You.

Hello @allun55,
I have created a merge request to merge the code for fixing the issue.
Thank You.

Thank you @Jaspreet-Kaur @Jay Jangid for reviewing my patch.

Hello,

I have created a patch to solve all the errors related to phpcs code standard issues .
Also, for the phpcs Drupal practice issues.

FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------
54 | WARNING | Unused variable $source_code.
68 | WARNING | Unused variable $source_code.
---------------------------------------------------------------------------------

Please review my patch and apply it .
Thank You.

Let me work on this issue and try to solve it .

Hello,

I have created a patch to solve all the errors related to phpcs code standard.
Please review and apply it .
Thank You.

Let me try to solve the issue..

prachi6824 → created an issue.

Hello,

I have created a patch to solve all the errors related to phpcs code standard but have left these warnings
reported within the .module file.
----------------------------------------------------------------------------------------
144 | WARNING | The use of function dvm() is discouraged
147 | WARNING | The use of function dvm() is discouraged
200 | WARNING | The use of function dvm() is discouraged
204 | WARNING | The use of function dvm() is discouraged

I think this function may be replaced by drupal_var_export.
Please review and apply it .
Thank You.

Let me try to fix the issues...

prachi6824 → created an issue.

Hello,

I have created a patch to solve this issue.

Please review and apply it .

prachi6824 → created an issue.

Please do review 3371515-#4.patch.

Hello @Harshita mehna I have created a merge request to merge these changes to the code.

prachi6824 → made their first commit to this issue’s fork.

Hello,

I have recreated a patch to solve the error as the above patch fails to replace all the \Drupal calls.

Please review and apply it .

Hello,

I have recreated a patch to solve the error as the above patch fails to replace all the \Drupal calls.

Please review and apply it .

Hello,

I have created a patch to solve the issue.

Please review and apply it .

prachi6824 → created an issue.

Hello,

I have created a patch to replace all \Drupal calls with dependency injection used within the module .

Please review and apply it .

Let me work on it ...

prachi6824 → created an issue.