Fix the issues reported by phpcs

Hello,

I have created a patch to solve all the errors related to phpcs within the module

Please review and apply it .

These fixes should always target dev branch.

Anything that's inside the folder 'legacy' isn't worth fixing. That is a reminder for me to see what's not ported from the D7 version yet.

The remaining looks quite minor, not sure if that's worth fixing. The coding standard issues report on https://www.drupal.org/pift-ci-job/2704671 → do not mark unused variables as a coding standard violation.

I tempted to close this as "Won't fix". It might be better to put your time in other things.

bindu r → made their first commit to this issue’s fork.

Hi,
Applied MR !9, can still see some errors.

FILE: C:\feeds_tamper\feeds_tamper.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 15 | WARNING | Unused variable $operations.
 56 | WARNING | Unused variable $feed_type_tamper_meta.
----------------------------------------------------------------------


FILE: C:\feeds_tamper\legacy\feeds_tamper_ui\tests\feeds_tamper_ui.test
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 8 WARNINGS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------------------------------------------------
 112 | ERROR   | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
 163 | ERROR   | Public method name "FeedsTamperUIWebTestCase::testCSV" is not in lowerCamel format
 193 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 194 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 195 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 198 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 199 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 200 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 215 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 234 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\feeds_tamper\src\Form\TamperEditForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 67 | WARNING | Unused variable $tampers_config.
----------------------------------------------------------------------


FILE: C:\feeds_tamper\tests\src\Functional\UiCrudTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 182 | WARNING | Unused variable $uuid.
----------------------------------------------------------------------

Hi

I applied MR !9 after commit #8 and I confirmed that after applying the patch I can see no PHPCS issues.

➜  feeds_tamper git:(8.x-2.0-beta3) curl https://git.drupalcode.org/project/feeds_tamper/-/merge_requests/9.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 16864    0 16864    0     0  31320      0 --:--:-- --:--:-- --:--:-- 31758
patching file feeds_tamper.module
patching file 'legacy/feeds_tamper_ui/feeds_tamper_ui.module'
patching file 'legacy/feeds_tamper_ui/tests/feeds_tamper_ui.test'
patching file 'src/Form/TamperEditForm.php'
patching file 'tests/src/Functional/UiCrudTest.php'
➜  feeds_tamper git:(8.x-2.0-beta3) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml feeds_tamper 
➜  contrib git:(master) ✗ 

Any remaining reported phpcs issues are in the legacy folder. And for that we have 📌 Remove legacy code from D7 Needs review .

Closing this as "won't fix", because there is no need to fix phpcs issues from the legacy folder.