Hi,
Applied MR!12, the Twitter icon is updated successfully.
Hi,
Applied MR!2, the issue resolved and the changes looks good.
Attaching screenshots for reference.
Hi,
Applied MR!6, the issue is resolved as the mini pager is styled.
Hi,
Applied MR!10, changes looks good for mini pager and full pager but the text in the mini pager is not center aligned.
Attaching screenshots for reference
Hi,
Applied MR!3, the issue is still not resolved. The close icon moves on scroll for mobile and tablet devices.
Attaching screenshots for reference.
Hi,
Applied MR!15, the issue is resolved and the banner images can be changed.
Thank you!
Hi,
Applied MR!7, the mini pager looks good but there is a thin horizontal line overlapping the mini-pager.
Please check. Attaching screenshots for reference.
Hi, the issue do not exist now as the search icon is visible.
Attaching screenshots for reference.
Hi,
Applied #3 patch, the patch applied successfully and issue is also resolved.
Attaching screenshots for references.
Hi,
Applied #3 patch, the patch applied successfully. The changes looks good but there is an underline on the text which would be better if removed. Attaching screenshots for reference.
Hi,
Applied MR!10, the login form looks good for all dimensions and the search block overlapping the menus issue is also resolved.
Attaching screenshots for reference.
Hi,
Applied MR!3, but still the issue is not resolved the menu dropdown is still not visible.
Attaching screenshots for reference.
Hi,
Applied MR!5 successfully, the issue is resolved.
Attaching screenshots for reference.
Hi,
Applied #3 patch, the patch applies successfully and the issue is resolved for both mobile and tablet.
Attaching screenshots for reference.
Hi,
Applied #3 patch, the patch applies successfully and the issue is also resolved.
Attaching screenshots for reference.
Hi,
Applied #3 patch, the patch applied successfully and the issue is also resolved.
Attaching screenshots for reference.
Hi,
Applied MR!18, the issue is resolved.
Adding screenshots for reference.
Hi,
Applied MR!4, the changes looks good in the mobile view.
Attaching screenshots for reference.
Hi,
Applied MR!6, the issue is resolved and the form looks good in all dimensions.
Attaching screenshots for reference.
Hi,
Tried applying #2 patch, but the patch was not able to apply and is throwing error.
Hi, Applied #3 patch. The patch applies successfully, but the issue is still not resolved.
The multilevel menu links are still not showing, attaching screenshots for reference.
Hi, Applied MR!12 successfully
The login page currently has two "Log In" buttons, one of the duplicate "Log In" buttons can be removed to avoid redundancy.
Hi, Applied MR!5, the issue is resolved.
Attaching screenshots for reference.
Hi, Applied #3 patch. The patch applies successfully and resolves the issue.
Attaching screenshots for reference.
Shruu_rao → made their first commit to this issue’s fork.
Hi,
Tested the MR!8, the MR is applied successfully and error is resolved.
Hi, I checked for phpcs issues using the command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml sam/
Found few warnings.
FILE: C:\sam\sam.module
-----------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------
20 | WARNING | [ ] Global constants should not be used, move it to a class or interface
57 | WARNING | [ ] Unused variable $should_simplify.
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------
Resolved some phpcs issues in the above patch.
Hi, all the phpcs issues are resolved in the above patch.
Shruu_rao → made their first commit to this issue’s fork.
Shruu_rao → made their first commit to this issue’s fork.
Hi,
Applied MR!4 and ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,yml opigno_poll/, found no phpcs issues.
Shruu_rao → made their first commit to this issue’s fork.
Shruu_rao → made their first commit to this issue’s fork.
Fixed some phpcs errors and warnings in the above patch.
Shruu_rao → made their first commit to this issue’s fork.
Hi,
Applied MR!17 and ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig ds/
Found no phpcs errors and warnings.
Shruu_rao → made their first commit to this issue’s fork.
Shruu_rao → made their first commit to this issue’s fork.
Shruu_rao → made their first commit to this issue’s fork.
Hi,
I checked for phpcs issues for MR!9 using phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml verf/
Found no errors and warnings.
Shruu_rao → made their first commit to this issue’s fork.
Shruu_rao → made their first commit to this issue’s fork.
Hi,
Applied MR!18 and checked for phpcs errors and warnings.
There are no errors found.
Hi,
I tried applying #37 patch. The patch throws
error: corrupt patch at line 16
Please check.
Shruu_rao → made their first commit to this issue’s fork.
Shruu_rao → made their first commit to this issue’s fork.
Hi,
Applied MR!1 , found no phpcs issues.
Shruu_rao → made their first commit to this issue’s fork.
Shruu_rao → made their first commit to this issue’s fork.
Shruu_rao → made their first commit to this issue’s fork.
Hi,
Applied #23 patch. The patch applied cleanly without any errors and ran the command phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml href_lang_exchange/
Didn't find any phpcs errors.
Shruu_rao → made their first commit to this issue’s fork.
Hi,
Applied #26 patch, the patch does not apply cleanly and throws error.
$ git apply -v phpcs_fix.patch
Checking patch preview_site.post_update.php...
error: while searching for:
/**
* @file
<<<<<<< ours
* Post update hooks for preview_site.
*/
error: patch failed: preview_site.post_update.php:2
error: preview_site.post_update.php: patch does not apply
Checking patch src/Deploy/DeployPluginBase.php...
error: while searching for:
// We provide an implementation here to prevent breaking BC under the 1:1
// rule. But in reality any plugin that doesn't implement this is probably
// not going to work.
@trigger_error('Deploy plugins are expected to implement \Drupal\preview_site\Deploy\DeployPluginInterface::deployFilePath', E_USER_DEPRECATED);
}
}
error: patch failed: src/Deploy/DeployPluginBase.php:56
error: src/Deploy/DeployPluginBase.php: patch does not apply
Checking patch src/EventSubscribers/AdditionalPathsEvent.php...
error: while searching for:
public function __construct(
protected PreviewSiteBuildInterface $build,
protected array $paths = [],
) { }
/**
* Gets additional paths.
error: patch failed: src/EventSubscribers/AdditionalPathsEvent.php:18
error: src/EventSubscribers/AdditionalPathsEvent.php: patch does not apply
Checking patch src/Generate/FileCollection.php...
error: while searching for:
class FileCollection implements \IteratorAggregate {
/**
* @var \Drupal\file\FileInterface[]
*/
private $files = [];
error: patch failed: src/Generate/FileCollection.php:10
error: src/Generate/FileCollection.php: patch does not apply
Checking patch src/Plugin/views/field/ItemLinks.php...
error: while searching for:
public const PLUGIN_ID = 'preview_site_item_links';
/**
* {@inheritdoc}
*/
error: patch failed: src/Plugin/views/field/ItemLinks.php:20
error: src/Plugin/views/field/ItemLinks.php: patch does not apply
Checking patch src/PreviewSiteCache.php...
error: while searching for:
*/
final class PreviewSiteCache extends StaticCache {
private StaticCacheInterface $inner;
private RequestStack $requestStack;
/**
error: patch failed: src/PreviewSiteCache.php:19
error: src/PreviewSiteCache.php: patch does not apply
Checking patch tests/src/Kernel/PreviewSiteBuilderTest.php...
error: while searching for:
],
[[PreviewSiteBuilder::class, 'operationQueueGenerate'], [$build->id()]],
[[PreviewSiteBuilder::class, 'operationProcessGenerate'], [$build->id()]],
[[PreviewSiteBuilder::class, 'operationQueueAdditionalPaths'], [$build->id()]],
[[PreviewSiteBuilder::class, 'operationProcessAssets'], [$build->id()]],
[[PreviewSiteBuilder::class, 'operationQueueDeploy'], [$build->id()]],
[[PreviewSiteBuilder::class, 'operationProcessDeploy'], [$build->id()]],
error: patch failed: tests/src/Kernel/PreviewSiteBuilderTest.php:202
error: tests/src/Kernel/PreviewSiteBuilderTest.php: patch does not apply
Checking patch tests/src/Traits/PreviewSiteTestTrait.php...
error: while searching for:
];
$clean_batch = function (array $context) {
return [
'finished' => 1,
'sandbox' => [],
] + $context;
};
PreviewSiteBuilder::operationMarkDeploymentStarted($build->id(), $context);
PreviewSiteBuilder::operationQueueGenerate($build->id());
error: patch failed: tests/src/Traits/PreviewSiteTestTrait.php:156
error: tests/src/Traits/PreviewSiteTestTrait.php: patch does not apply
Hi,
Applied MR!8 and ran the command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml sortableviews/
Didn't find any phpcs errors.
Shruu_rao → made their first commit to this issue’s fork.
Hi,
Applied #5 patch. The patch applies cleanly.
There are still some warnings left
FILE: C:\festeva\README.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 18 WARNINGS AFFECTING 18 LINES
----------------------------------------------------------------------
13 | WARNING | Line exceeds 80 characters; contains 114 characters
33 | WARNING | Line exceeds 80 characters; contains 160 characters
36 | WARNING | Line exceeds 80 characters; contains 138 characters
39 | WARNING | Line exceeds 80 characters; contains 112 characters
42 | WARNING | Line exceeds 80 characters; contains 165 characters
45 | WARNING | Line exceeds 80 characters; contains 213 characters
48 | WARNING | Line exceeds 80 characters; contains 201 characters
51 | WARNING | Line exceeds 80 characters; contains 232 characters
54 | WARNING | Line exceeds 80 characters; contains 207 characters
57 | WARNING | Line exceeds 80 characters; contains 209 characters
60 | WARNING | Line exceeds 80 characters; contains 175 characters
63 | WARNING | Line exceeds 80 characters; contains 122 characters
66 | WARNING | Line exceeds 80 characters; contains 102 characters
69 | WARNING | Line exceeds 80 characters; contains 148 characters
72 | WARNING | Line exceeds 80 characters; contains 168 characters
75 | WARNING | Line exceeds 80 characters; contains 100 characters
77 | WARNING | Line exceeds 80 characters; contains 148 characters
79 | WARNING | Line exceeds 80 characters; contains 176 characters
----------------------------------------------------------------------
Hi,
Applied #11 patch , the patch is not get applied and throwing error.
Hi,
Applied #22 patch. patch applied cleanly but still could see some errors.
FILE: C:\spambot\spambot.module
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
19 | WARNING | Global constants should not be used, move it to a class or interface
43 | WARNING | Code after the RETURN statement on line 41 cannot be executed
539 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\spambot\src\Controller\SpambotUserSpamPageController.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
24 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------
FILE: C:\spambot\src\Form\SpambotSettingsForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 25 WARNINGS AFFECTING 25 LINES
------------------------------------------------------------------------------------------------------------------------------------------
124 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
125 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
279 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
362 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
363 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
368 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
369 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
371 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
372 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
373 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
374 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
375 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
376 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
377 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
378 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
384 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
385 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
387 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
388 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
389 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
390 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
391 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
392 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
393 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
394 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\spambot\src\Form\SpambotUserspamForm.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------
194 | WARNING | Node::load calls should be avoided in classes, use dependency injection instead
283 | WARNING | Unused variable $comments_enabled.
636 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------
FILE: C:\spambot\src\Plugin\WebformHandler\SpamBotWebformHandler.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------------------------------
113 | WARNING | Only string literals should be passed to t() where possible
114 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
118 | WARNING | Only string literals should be passed to t() where possible
119 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
123 | WARNING | Only string literals should be passed to t() where possible
124 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
Hi,
I ran the command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml tg_integration/
There are no errors found.
Hi,
I ran the command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml simple_address/
There are no errors found.
Hi,
Addressed the above comments here.
Hi,
Applied MR!53, can still see some errors.
FILE: C:\redirect\redirect.admin.inc
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 16 ERRORS AND 2 WARNINGS AFFECTING 17 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
85 | ERROR | The array declaration extends to column 152 (the limit is 80). The array content should be split up over multiple lines
220 | ERROR | Missing parameter type
222 | ERROR | Missing parameter type
284 | ERROR | The array declaration extends to column 119 (the limit is 80). The array content should be split up over multiple lines
285 | ERROR | The array declaration extends to column 173 (the limit is 80). The array content should be split up over multiple lines
310 | ERROR | The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
370 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
370 | ERROR | The array declaration extends to column 299 (the limit is 80). The array content should be split up over multiple lines
434 | ERROR | The array declaration extends to column 422 (the limit is 80). The array content should be split up over multiple lines
493 | ERROR | The array declaration extends to column 299 (the limit is 80). The array content should be split up over multiple lines
575 | ERROR | The array declaration extends to column 316 (the limit is 80). The array content should be split up over multiple lines
599 | ERROR | The array declaration extends to column 111 (the limit is 80). The array content should be split up over multiple lines
630 | ERROR | The array declaration extends to column 158 (the limit is 80). The array content should be split up over multiple lines
671 | ERROR | The array declaration extends to column 422 (the limit is 80). The array content should be split up over multiple lines
675 | WARNING | Avoid backslash escaping in translatable strings when possible, use "" quotes instead
695 | ERROR | The array declaration extends to column 384 (the limit is 80). The array content should be split up over multiple lines
702 | ERROR | The array declaration extends to column 165 (the limit is 80). The array content should be split up over multiple lines
935 | ERROR | The array declaration extends to column 152 (the limit is 80). The array content should be split up over multiple lines
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\redirect\redirect.api.php
-------------------------------------------------------------------------
FOUND 18 ERRORS AND 3 WARNINGS AFFECTING 21 LINES
-------------------------------------------------------------------------
26 | WARNING | Line exceeds 80 characters; contains 85 characters
36 | WARNING | Line exceeds 80 characters; contains 83 characters
74 | ERROR | Missing parameter type
76 | ERROR | Missing parameter type
88 | ERROR | Missing parameter type
90 | ERROR | Missing parameter type
92 | ERROR | Missing parameter type
117 | WARNING | Line exceeds 80 characters; contains 81 characters
126 | ERROR | Missing parameter type
129 | ERROR | Missing parameter type
134 | ERROR | Missing parameter type
138 | ERROR | Return type missing for @return tag in function comment
176 | ERROR | Missing parameter type
199 | ERROR | Missing parameter type
201 | ERROR | Missing parameter type
203 | ERROR | Missing parameter type
219 | ERROR | Missing parameter type
235 | ERROR | Missing parameter type
251 | ERROR | Missing parameter type
267 | ERROR | Missing parameter type
283 | ERROR | Missing parameter type
-------------------------------------------------------------------------
FILE: C:\redirect\redirect.drush.inc
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
9 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
79 | ERROR | The array declaration extends to column 139 (the limit is 80). The array content should be split up over multiple lines
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\redirect\redirect.generate.inc
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
166 | WARNING | Line exceeds 80 characters; contains 88 characters
185 | ERROR | The array declaration extends to column 185 (the limit is 80). The array content should be split up over multiple lines
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\redirect\redirect.info
------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------
7 | ERROR | It's only necessary to declare files[] if they declare a class or interface.
------------------------------------------------------------------------------------------
FILE: C:\redirect\redirect.module
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 70 ERRORS AND 12 WARNINGS AFFECTING 78 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
18 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
24 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
30 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
259 | WARNING | Line exceeds 80 characters; contains 83 characters
259 | ERROR | Comment indentation error, expected only 1 spaces
260 | ERROR | Comment indentation error, expected only 2 spaces
261 | WARNING | Line exceeds 80 characters; contains 129 characters
261 | ERROR | Comment indentation error, expected only 4 spaces
299 | ERROR | Missing parameter type
302 | ERROR | Return type missing for @return tag in function comment
512 | ERROR | The array declaration extends to column 112 (the limit is 80). The array content should be split up over multiple lines
523 | ERROR | The array declaration extends to column 112 (the limit is 80). The array content should be split up over multiple lines
534 | ERROR | The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines
541 | ERROR | Missing parameter type
543 | ERROR | Missing parameter type
546 | ERROR | Return type missing for @return tag in function comment
565 | ERROR | Missing parameter type
567 | ERROR | Missing parameter type
570 | ERROR | Return type missing for @return tag in function comment
583 | ERROR | Missing parameter type
585 | ERROR | Missing parameter type
587 | ERROR | Missing parameter type
624 | ERROR | Missing parameter type
626 | ERROR | Missing parameter type
628 | ERROR | Missing parameter type
630 | ERROR | Missing parameter type
633 | ERROR | Return type missing for @return tag in function comment
664 | WARNING | Line exceeds 80 characters; contains 91 characters
678 | ERROR | Missing parameter type
680 | ERROR | Missing parameter type
683 | ERROR | Missing parameter type
686 | ERROR | Return type missing for @return tag in function comment
697 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
699 | ERROR | Missing parameter type
704 | ERROR | Missing parameter type
707 | ERROR | Missing parameter type
711 | ERROR | Return type missing for @return tag in function comment
731 | WARNING | Line exceeds 80 characters; contains 82 characters
748 | WARNING | Line exceeds 80 characters; contains 81 characters
776 | ERROR | The array declaration extends to column 313 (the limit is 80). The array content should be split up over multiple lines
817 | ERROR | Missing parameter type
916 | ERROR | Missing parameter type
931 | ERROR | Missing parameter type
960 | ERROR | Missing parameter type
963 | ERROR | Parameter tags must be grouped together in a doc comment
963 | ERROR | Missing parameter name
982 | ERROR | Missing parameter type
984 | ERROR | Missing parameter type
997 | ERROR | Comment indentation error, expected only 1 spaces
1000 | ERROR | Comment indentation error, expected only 2 spaces
1050 | ERROR | Missing parameter type
1085 | ERROR | Missing parameter type
1089 | ERROR | Missing parameter type
1093 | ERROR | Return type missing for @return tag in function comment
1133 | ERROR | Missing parameter type
1142 | ERROR | The array declaration extends to column 140 (the limit is 80). The array content should be split up over multiple lines
1160 | WARNING | Line exceeds 80 characters; contains 81 characters
1175 | ERROR | Comment indentation error, expected only 1 spaces
1199 | WARNING | Line exceeds 80 characters; contains 84 characters
1278 | ERROR | Missing parameter type
1281 | ERROR | Return type missing for @return tag in function comment
1320 | ERROR | Return type missing for @return tag in function comment
1360 | ERROR | Missing parameter type
1362 | ERROR | Missing parameter type
1365 | ERROR | Return type missing for @return tag in function comment
1392 | ERROR | Missing parameter type
1394 | ERROR | Missing parameter type
1397 | ERROR | Return type missing for @return tag in function comment
1415 | ERROR | Missing parameter type
1418 | ERROR | Return type missing for @return tag in function comment
1507 | ERROR | Doc comment short description must end with a full stop
1507 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
1579 | WARNING | Line exceeds 80 characters; contains 93 characters
1612 | ERROR | Return type missing for @return tag in function comment
1648 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
1650 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "locale_form_redirect_edit_form_alter" but expected
| | "redirect_locale_form_redirect_edit_form_alter"
1705 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines
1726 | ERROR | The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
1744 | WARNING | Line exceeds 80 characters; contains 82 characters
1745 | WARNING | Line exceeds 80 characters; contains 82 characters
1805 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
1807 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "mpac_form_redirect_edit_form_alter" but expected
| | "redirect_mpac_form_redirect_edit_form_alter"
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\redirect\redirect.test
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 21 ERRORS AND 5 WARNINGS AFFECTING 22 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
10 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
31 | ERROR | The array declaration extends to column 163 (the limit is 80). The array content should be split up over multiple lines
51 | ERROR | Parameter $source_path is not described in comment
51 | ERROR | Parameter $redirect_path is not described in comment
54 | ERROR | Missing parameter type
56 | ERROR | Missing parameter type
140 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
158 | ERROR | The array declaration extends to column 91 (the limit is 80). The array content should be split up over multiple lines
158 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines
164 | ERROR | The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines
165 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
166 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
179 | ERROR | The array declaration extends to column 92 (the limit is 80). The array content should be split up over multiple lines
180 | ERROR | The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
180 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
214 | ERROR | The array declaration extends to column 197 (the limit is 80). The array content should be split up over multiple lines
221 | ERROR | Public method name "RedirectUnitTest::testParseURL" is not in lowerCamel format
268 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
270 | ERROR | Missing member variable doc comment
270 | ERROR | Class property $admin_user should use lowerCamel naming without underscores
289 | ERROR | The array declaration extends to column 194 (the limit is 80). The array content should be split up over multiple lines
364 | ERROR | The array declaration extends to column 105 (the limit is 80). The array content should be split up over multiple lines
366 | WARNING | Line exceeds 80 characters; contains 96 characters
390 | ERROR | The array declaration extends to column 111 (the limit is 80). The array content should be split up over multiple lines
391 | WARNING | Line exceeds 80 characters; contains 96 characters
396 | ERROR | The array declaration extends to column 112 (the limit is 80). The array content should be split up over multiple lines
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\redirect\views\redirect_handler_field_redirect_link_delete.inc
------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | Class name must begin with a capital letter
11 | ERROR | Class name must use UpperCamel naming without underscores
24 | ERROR | Public method name "redirect_handler_field_redirect_link_delete::option_definition" is not in lowerCamel format
33 | ERROR | Public method name "redirect_handler_field_redirect_link_delete::options_form" is not in lowerCamel format
------------------------------------------------------------------------------------------------------------------------------
FILE: C:\redirect\views\redirect_handler_field_redirect_link_edit.inc
----------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------
11 | ERROR | Class name must begin with a capital letter
11 | ERROR | Class name must use UpperCamel naming without underscores
24 | ERROR | Public method name "redirect_handler_field_redirect_link_edit::option_definition" is not in lowerCamel format
33 | ERROR | Public method name "redirect_handler_field_redirect_link_edit::options_form" is not in lowerCamel format
----------------------------------------------------------------------------------------------------------------------------
FILE: C:\redirect\views\redirect_handler_field_redirect_operations.inc
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | Class name must begin with a capital letter
11 | ERROR | Class name must use UpperCamel naming without underscores
24 | ERROR | Public method name "redirect_handler_field_redirect_operations::option_definition" is not in lowerCamel format
34 | ERROR | Public method name "redirect_handler_field_redirect_operations::options_form" is not in lowerCamel format
81 | ERROR | The array declaration extends to column 127 (the limit is 80). The array content should be split up over multiple lines
81 | ERROR | The array declaration extends to column 125 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\redirect\views\redirect_handler_field_redirect_redirect.inc
---------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------------
11 | ERROR | Class name must begin with a capital letter
11 | ERROR | Class name must use UpperCamel naming without underscores
25 | ERROR | Public method name "redirect_handler_field_redirect_redirect::option_definition" is not in lowerCamel format
36 | ERROR | Public method name "redirect_handler_field_redirect_redirect::options_form" is not in lowerCamel format
---------------------------------------------------------------------------------------------------------------------------
FILE: C:\redirect\views\redirect_handler_field_redirect_source.inc
-------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------
11 | ERROR | Class name must begin with a capital letter
11 | ERROR | Class name must use UpperCamel naming without underscores
25 | ERROR | Public method name "redirect_handler_field_redirect_source::option_definition" is not in lowerCamel format
36 | ERROR | Public method name "redirect_handler_field_redirect_source::options_form" is not in lowerCamel format
-------------------------------------------------------------------------------------------------------------------------
FILE: C:\redirect\views\redirect_handler_filter_redirect_type.inc
--------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------
11 | ERROR | Class name must begin with a capital letter
11 | ERROR | Class name must use UpperCamel naming without underscores
16 | ERROR | Public method name "redirect_handler_filter_redirect_type::get_value_options" is not in lowerCamel format
22 | WARNING | Only string literals should be passed to t() where possible
--------------------------------------------------------------------------------------------------------------------------
Hi,
Applied MR!8, I didn't find any phpcs issues.
Thank you
Hi,
Applied patch #10, the patch applies cleanly and there are no phpcs errors found.
Hi,
Applied MR !9, can still see some errors.
FILE: C:\feeds_tamper\feeds_tamper.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
15 | WARNING | Unused variable $operations.
56 | WARNING | Unused variable $feed_type_tamper_meta.
----------------------------------------------------------------------
FILE: C:\feeds_tamper\legacy\feeds_tamper_ui\tests\feeds_tamper_ui.test
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 8 WARNINGS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------------------------------------------------
112 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
163 | ERROR | Public method name "FeedsTamperUIWebTestCase::testCSV" is not in lowerCamel format
193 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
194 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
195 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
198 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
199 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
200 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
215 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
234 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\feeds_tamper\src\Form\TamperEditForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
67 | WARNING | Unused variable $tampers_config.
----------------------------------------------------------------------
FILE: C:\feeds_tamper\tests\src\Functional\UiCrudTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
182 | WARNING | Unused variable $uuid.
----------------------------------------------------------------------
Shruu_rao → made their first commit to this issue’s fork.
Hi @Nikolay Shapovalov, as per your suggestion i have reverted the commit 30d4afc.
Thank you
Remaining issues
FILE: C:\content_sync\src\Content\ContentFileStorageFactory.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
18 | WARNING | The @see url 'https://api.drupal.org/api/drupal/core%21includes%21bootstrap.inc/constant/CONFIG_ACTIVE_DIRECTORY/8.9.x' does not match the standard:
| | http(s)://www.drupal.org/node/n or http(s)://www.drupal.org/project/aaa/issues/n
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\content_sync\src\Content\ContentStorageComparer.php
-------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------
53 | WARNING | Unused variable $key.
-------------------------------------------------------------------------
FILE: C:\content_sync\src\ContentSyncManager.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
95 | WARNING | Unused variable $uuid.
113 | WARNING | Line exceeds 80 characters; contains 87 characters
----------------------------------------------------------------------
FILE: C:\content_sync\src\Controller\ContentLogController.php
-------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------
315 | ERROR | Function return type is not void, but function is returning void here
-------------------------------------------------------------------------------------
FILE: C:\content_sync\src\DependencyResolver\ExportQueueResolver.php
---------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------
59 | WARNING | Unused variable $ref_entity_type_id.
68 | WARNING | Unused variable $ref_entity_type_id.
76 | WARNING | Unused variable $bundle.
---------------------------------------------------------------------------------
FILE: C:\content_sync\src\DependencyResolver\ImportQueueResolver.php
---------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------
100 | WARNING | Unused variable $ref_entity_type_id.
146 | WARNING | Unused variable $uuid.
---------------------------------------------------------------------------------
FILE: C:\content_sync\src\Form\ContentExportMultiple.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
73 | ERROR | Parameter $formats is not described in comment
----------------------------------------------------------------------
FILE: C:\content_sync\src\Form\ContentExportTrait.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AND 4 WARNINGS AFFECTING 15 LINES
----------------------------------------------------------------------------------------------------------------------------------------
27 | ERROR | Missing parameter type
29 | ERROR | Missing parameter type
61 | ERROR | The array declaration extends to column 81 (the limit is 80). The array content should be split up over multiple lines
63 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
63 | ERROR | The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines
88 | ERROR | Missing parameter type
90 | ERROR | Missing parameter type
92 | ERROR | Missing parameter type
97 | ERROR | Arguments with default values must be at the end of the argument list
187 | WARNING | Unused variable $file.
191 | WARNING | Unused variable $cache.
223 | ERROR | Parameter $serializer_context is not described in comment
226 | ERROR | Missing parameter type
231 | ERROR | Public method name "ContentExportTrait::generateSiteUUIDFile" is not in lowerCamel format
253 | WARNING | Unused variable $file.
276 | WARNING | Line exceeds 80 characters; contains 90 characters
----------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\content_sync\src\Form\ContentImportForm.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------------------
28 | ERROR | The array declaration extends to column 144 (the limit is 80). The array content should be split up over multiple lines
81 | ERROR | The array declaration extends to column 195 (the limit is 80). The array content should be split up over multiple lines
93 | ERROR | Invalid function name, expected empty_directory but found emptyDirectory
--------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\content_sync\src\Form\ContentImportTrait.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 4 WARNINGS AFFECTING 8 LINES
----------------------------------------------------------------------------------------------------------------------------------------
30 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
30 | ERROR | The array declaration extends to column 88 (the limit is 80). The array content should be split up over multiple lines
31 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines
31 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines
43 | WARNING | Line exceeds 80 characters; contains 91 characters
52 | ERROR | Arguments with default values must be at the end of the argument list
79 | WARNING | Unused variable $cache.
106 | WARNING | Line exceeds 80 characters; contains 91 characters
115 | ERROR | Arguments with default values must be at the end of the argument list
158 | WARNING | Unused variable $cache.
----------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\content_sync\src\Form\ContentSingleExportForm.php
-----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------
122 | WARNING | Line exceeds 80 characters; contains 87 characters
-----------------------------------------------------------------------
FILE: C:\content_sync\src\Form\ContentSync.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
125 | WARNING | Unused variable $source_list.
226 | WARNING | Unused variable $collection.
----------------------------------------------------------------------
FILE: C:\content_sync\src\Importer\ContentImporter.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
186 | ERROR | Missing parameter type
----------------------------------------------------------------------
FILE: C:\content_sync\src\Importer\ContentImporterInterface.php
----------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------
13 | ERROR | Missing parameter type
15 | ERROR | Missing parameter type
----------------------------------------------------------------------------
FILE: C:\content_sync\src\Normalizer\ContentEntityNormalizer.php
-----------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------
111 | WARNING | Possible useless method overriding detected
118 | ERROR | Missing parameter type
-----------------------------------------------------------------------------
FILE: C:\content_sync\src\Normalizer\EntityReferenceFieldItemNormalizer.php
----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------
121 | WARNING | Line exceeds 80 characters; contains 178 characters
----------------------------------------------------------------------------------------
FILE: C:\content_sync\src\Normalizer\FileEntityNormalizer.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
120 | WARNING | Line exceeds 80 characters; contains 81 characters
124 | WARNING | Line exceeds 80 characters; contains 128 characters
--------------------------------------------------------------------------
FILE: C:\content_sync\src\Normalizer\LinkItemNormalizer.php
----------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------
26 | WARNING | Line exceeds 80 characters; contains 91 characters
41 | ERROR | Parameter $entity_type_manager is not described in comment
75 | WARNING | Line exceeds 80 characters; contains 81 characters
142 | WARNING | Line exceeds 80 characters; contains 178 characters
----------------------------------------------------------------------------
FILE: C:\content_sync\src\Normalizer\PathAliasEntityNormalizer.php
-------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------
91 | WARNING | Line exceeds 80 characters; contains 81 characters
-------------------------------------------------------------------------------
Remaining errors
FILE: C:\search_api\modules\search_api_db\README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
34 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------
FILE: C:\search_api\modules\search_api_db\src\Plugin\search_api\backend\Database.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------------
1508 | ERROR | The array declaration extends to column 439 (the limit is 80). The array content should be split up over multiple lines
1525 | ERROR | The array declaration extends to column 443 (the limit is 80). The array content should be split up over multiple lines
1779 | ERROR | No key specified for array entry; first entry specifies key
2004 | ERROR | No key specified for array entry; first entry specifies key
----------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\search_api\modules\search_api_db\tests\fixtures\update\search-api-db-base.php
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
52 | WARNING | Unused variable $data.
---------------------------------------------------------------------------------------------------
FILE: C:\search_api\modules\search_api_db\tests\src\FunctionalJavascript\IntegrationTest.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
33 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\search_api\modules\search_api_db\tests\src\Kernel\BackendTest.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 16 ERRORS AFFECTING 16 LINES
---------------------------------------------------------------------------------------------------------------------------------------
348 | ERROR | No key specified for array entry; first entry specifies key
351 | ERROR | No key specified for array entry; first entry specifies key
399 | ERROR | No key specified for array entry; first entry specifies key
402 | ERROR | No key specified for array entry; first entry specifies key
470 | ERROR | No key specified for array entry; first entry specifies key
473 | ERROR | No key specified for array entry; first entry specifies key
479 | ERROR | No key specified for array entry; first entry specifies key
488 | ERROR | No key specified for array entry; first entry specifies key
491 | ERROR | No key specified for array entry; first entry specifies key
497 | ERROR | No key specified for array entry; first entry specifies key
983 | ERROR | The array declaration extends to column 91 (the limit is 80). The array content should be split up over multiple lines
1275 | ERROR | No key specified for array entry; first entry specifies key
1288 | ERROR | No key specified for array entry; first entry specifies key
1300 | ERROR | No key specified for array entry; first entry specifies key
1313 | ERROR | Key specified for array entry; first entry has no key
1317 | ERROR | Key specified for array entry; first entry has no key
---------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\search_api\README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
127 | WARNING | Line exceeds 80 characters; contains 83 characters
----------------------------------------------------------------------
FILE: C:\search_api\search_api.api.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
342 | WARNING | Unused variable $datasource_id.
367 | WARNING | Unused variable $datasource_id.
----------------------------------------------------------------------
FILE: C:\search_api\search_api.drush.inc
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------------------------------
86 | ERROR | The array declaration extends to column 167 (the limit is 80). The array content should be split up over multiple lines
87 | ERROR | The array declaration extends to column 238 (the limit is 80). The array content should be split up over multiple lines
183 | ERROR | The array declaration extends to column 199 (the limit is 80). The array content should be split up over multiple lines
184 | ERROR | The array declaration extends to column 189 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\search_api\search_api.install
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
195 | ERROR | The array declaration extends to column 88 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\search_api\search_api.post_update.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
42 | ERROR | The array declaration extends to column 88 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\search_api\src\Display\DisplayPluginBase.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
140 | WARNING | The deprecation-version 'Search' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or project:n.x-n.n-label[n] or
| | project:n.n.n or project:n.n.n-label[n]
140 | WARNING | The removal-version '5' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or project:n.x-n.n-label[n] or project:n.n.n
| | or project:n.n.n-label[n]
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\search_api\src\Entity\Index.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 8 LINES
------------------------------------------------------------------------------------------------------------------------------------------
161 | ERROR | Missing short description in doc comment
193 | ERROR | Missing short description in doc comment
242 | ERROR | Missing short description in doc comment
1010 | ERROR | The array declaration extends to column 117 (the limit is 80). The array content should be split up over multiple lines
1127 | ERROR | The array declaration extends to column 108 (the limit is 80). The array content should be split up over multiple lines
1155 | ERROR | The array declaration extends to column 123 (the limit is 80). The array content should be split up over multiple lines
1178 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines
1619 | WARNING | There must be no blank line following an inline comment
------------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\search_api\src\Entity\Task.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
141 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
--------------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\search_api\src\ParamConverter\SearchApiConverter.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
59 | WARNING | The deprecation-version 'search_api' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or project:n.x-n.n-label[n] or
| | project:n.n.n or project:n.n.n-label[n]
59 | WARNING | The removal-version '2.0.0' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or project:n.x-n.n-label[n] or
| | project:n.n.n or project:n.n.n-label[n]
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\search_api\src\Plugin\search_api\parse_mode\Phrase.php
----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------
24 | ERROR | No key specified for array entry; first entry specifies key
----------------------------------------------------------------------------
FILE: C:\search_api\src\Plugin\search_api\parse_mode\Terms.php
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
88 | ERROR | No key specified for array entry; first entry specifies key
---------------------------------------------------------------------------
FILE: C:\search_api\src\Plugin\search_api\processor\Stemmer.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
144 | WARNING | Unused variable $i.
----------------------------------------------------------------------------
FILE: C:\search_api\src\Plugin\views\filter\SearchApiFulltext.php
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
452 | ERROR | No key specified for array entry; first entry specifies key
------------------------------------------------------------------------------
FILE: C:\search_api\src\Plugin\views\query\SearchApiQuery.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
464 | ERROR | The trigger_error message '\Drupal\search_api\Plugin\views\query\SearchApiQuery::getEntityTypes() is deprecated in 8.x-1.x is removed from Search API
| | 8.x-1.5. Use \Drupal\search_api\IndexInterface::getEntityTypes() instead. See https://www.drupal.org/node/2899682' does not match the strict standard
| | format: %thing% is deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%. See %cr-link%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\search_api\src\Utility\FieldsHelper.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
178 | WARNING | Unused variable $i.
----------------------------------------------------------------------
FILE: C:\search_api\tests\src\Kernel\BackendTestBase.php
---------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 12 LINES
---------------------------------------------------------------------------
266 | ERROR | No key specified for array entry; first entry specifies key
269 | ERROR | No key specified for array entry; first entry specifies key
275 | ERROR | No key specified for array entry; first entry specifies key
573 | ERROR | No key specified for array entry; first entry specifies key
590 | ERROR | No key specified for array entry; first entry specifies key
594 | ERROR | No key specified for array entry; first entry specifies key
606 | ERROR | No key specified for array entry; first entry specifies key
611 | ERROR | No key specified for array entry; first entry specifies key
629 | ERROR | No key specified for array entry; first entry specifies key
638 | ERROR | No key specified for array entry; first entry specifies key
646 | ERROR | No key specified for array entry; first entry specifies key
650 | ERROR | No key specified for array entry; first entry specifies key
---------------------------------------------------------------------------
FILE: C:\search_api\tests\src\Kernel\Processor\LanguageWithFallbackTest.php
----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------
111 | WARNING | Variable $expected inside unset call is undefined.
118 | WARNING | Variable $expected inside unset call is undefined.
----------------------------------------------------------------------------------------
FILE: C:\search_api\tests\src\Kernel\Processor\RenderedItemTest.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
355 | WARNING | Unused variable $key.
--------------------------------------------------------------------------------
FILE: C:\search_api\tests\src\Kernel\Views\ViewsQueryTypeUpdateTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
21 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations.
-------------------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\search_api\tests\src\Unit\Processor\HtmlFilterTest.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
283 | WARNING | Variable $config inside unset call is undefined.
----------------------------------------------------------------------------
FILE: C:\search_api\tests\src\Unit\TermsParseModeTest.php
---------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
---------------------------------------------------------------------------
62 | ERROR | No key specified for array entry; first entry specifies key
70 | ERROR | No key specified for array entry; first entry specifies key
77 | ERROR | No key specified for array entry; first entry specifies key
87 | ERROR | No key specified for array entry; first entry specifies key
98 | ERROR | No key specified for array entry; first entry specifies key
106 | ERROR | No key specified for array entry; first entry specifies key
114 | ERROR | No key specified for array entry; first entry specifies key
118 | ERROR | No key specified for array entry; first entry specifies key
124 | ERROR | No key specified for array entry; first entry specifies key
132 | ERROR | No key specified for array entry; first entry specifies key
---------------------------------------------------------------------------
Shruu_rao → made their first commit to this issue’s fork.
Shruu_rao → made their first commit to this issue’s fork.
Hi,
Tested #10, patch applied cleanly without any errors.
Shruu_rao → made their first commit to this issue’s fork.
Hi,
Tested the #8 patch, patch does not apply and throws following errors.
Checking patch src/LcLayoutRender.php...
Hunk #1 succeeded at 327 (offset 1 line).
Checking patch src/LcLayoutsManager.php...
warning: src/LcLayoutsManager.php has type 100644, expected 100755
Checking patch src/LcTheme.php...
warning: src/LcTheme.php has type 100644, expected 100755
error: while searching for:
use Drupal\Core\DependencyInjection\ContainerInjectionInterface;
use Drupal\Core\Layout\LayoutPluginManager;
use Drupal\Core\Routing\RouteMatchInterface;
use Drupal\node\Entity\Node;
use Symfony\Component\DependencyInjection\ContainerInterface;
error: patch failed: src/LcTheme.php:5
error: src/LcTheme.php: patch does not apply
Checking patch src/Plugin/Layout/LcBase.php...
warning: src/Plugin/Layout/LcBase.php has type 100644, expected 100755
Hi,
Reviewed MR !2, found few remaining errors adding some below.
FILE: C:\eudonet\eudonet.module
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\eudonet\README.md
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\eudonet\src\Annotation\EudonetQuery.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\eudonet\src\Annotation\EudonetQueryResult.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\eudonet\src\Eudonet.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\eudonet\src\EudonetMappingPluginManager.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\eudonet\src\EudonetMappingPluginManagerInterface.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\eudonet\src\EudonetQueryCondition.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\eudonet\src\EudonetSearchQueryResultItemWrapper.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
Hi,
Reviewed MR !1 , still there are many phpcs errors.
Adding some of them below.
FILE: C:\pylot_bridge\assets\gisconverter.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 64 ERRORS AND 7 WARNINGS AFFECTING 66 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
3 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
10 | ERROR | [ ] Class name doesn't match filename; expected "class gisconverter"
11 | ERROR | [ ] Missing member variable doc comment
82 | ERROR | [ ] Missing member variable doc comment
83 | ERROR | [ ] Missing member variable doc comment
98 | ERROR | [ ] Missing member variable doc comment
106 | ERROR | [ ] Missing member variable doc comment
127 | ERROR | [ ] Interface name must begin with a capital letter
127 | WARNING | [ ] Interface names should always have the suffix "Interface"
129 | ERROR | [ ] Missing short description in doc comment
132 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
157 | ERROR | [ ] Interface name must begin with a capital letter
157 | WARNING | [ ] Interface names should always have the suffix "Interface"
165 | ERROR | [ ] Public method name "iGeometry::toGeoJSON" is not in lowerCamel format
173 | ERROR | [ ] Public method name "iGeometry::toKML" is not in lowerCamel format
181 | ERROR | [ ] Public method name "iGeometry::toWKT" is not in lowerCamel format
186 | ERROR | [ ] Missing parameter comment
186 | ERROR | [ ] Missing parameter name
187 | ERROR | [x] Separate the @param and @return sections by a blank line.
190 | ERROR | [ ] Public method name "iGeometry::toGPX" is not in lowerCamel format
196 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
197 | ERROR | [x] Separate the @param and @return sections by a blank line.
208 | ERROR | [ ] Class constants must be uppercase; expected NAME but found name
213 | ERROR | [ ] Public method name "Geometry::toGeoJSON" is not in lowerCamel format
220 | ERROR | [ ] Public method name "Geometry::toKML" is not in lowerCamel format
227 | ERROR | [ ] Public method name "Geometry::toGPX" is not in lowerCamel format
234 | ERROR | [ ] Public method name "Geometry::toWKT" is not in lowerCamel format
366 | ERROR | [ ] Protected method name "WKT::_parseCollection" is not in lowerCamel format
416 | ERROR | [ ] Protected method name "GeoJSON::_geomFromJson" is not in lowerCamel format
616 | ERROR | [ ] Protected method name "XML::_childsCollect" is not in lowerCamel format
642 | ERROR | [ ] Protected method name "XML::_geomFromXML" is not in lowerCamel format
646 | ERROR | [ ] Doc comment is empty
715 | ERROR | [ ] Protected method name "KML::_extractCoordinates" is not in lowerCamel format
726 | ERROR | [ ] Protected method name "KML::_geomFromXML" is not in lowerCamel format
768 | WARNING | [ ] Code after the RETURN statement on line 766 cannot be executed
772 | WARNING | [ ] Code after the RETURN statement on line 770 cannot be executed
776 | WARNING | [ ] Code after the RETURN statement on line 774 cannot be executed
799 | ERROR | [ ] Protected method name "GPX::_extractCoordinates" is not in lowerCamel format
845 | ERROR | [ ] Protected method name "GPX::_geomFromXML" is not in lowerCamel format
872 | ERROR | [ ] String concat is not required here; use a single string instead
875 | ERROR | [ ] String concat is not required here; use a single string instead
886 | ERROR | [ ] Class constants must be uppercase; expected NAME but found name
888 | ERROR | [ ] Missing member variable doc comment
889 | ERROR | [ ] Missing member variable doc comment
928 | ERROR | [ ] Public method name "Point::toWKT" is not in lowerCamel format
935 | ERROR | [ ] Public method name "Point::toKML" is not in lowerCamel format
942 | ERROR | [ ] Public method name "Point::toGPX" is not in lowerCamel format
955 | ERROR | [ ] Public method name "Point::toGeoJSON" is not in lowerCamel format
956 | ERROR | [ ] The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
956 | ERROR | [ ] The array declaration extends to column 88 (the limit is 80). The array content should be split up over multiple lines
1002 | ERROR | [ ] Missing member variable doc comment
1019 | ERROR | [ ] Public method name "Collection::toWKT" is not in lowerCamel format
1034 | ERROR | [ ] Public method name "Collection::toGeoJSON" is not in lowerCamel format
1043 | ERROR | [ ] The array declaration extends to column 102 (the limit is 80). The array content should be split up over multiple lines
1050 | ERROR | [ ] Public method name "Collection::toKML" is not in lowerCamel format
1062 | ERROR | [ ] Class constants must be uppercase; expected NAME but found name
1100 | ERROR | [ ] Class constants must be uppercase; expected NAME but found name
1115 | ERROR | [ ] Public method name "LineString::toKML" is not in lowerCamel format
1124 | ERROR | [ ] Public method name "LineString::toGPX" is not in lowerCamel format
1149 | ERROR | [ ] Class constants must be uppercase; expected NAME but found name
1169 | ERROR | [ ] Class constants must be uppercase; expected NAME but found name
1208 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
1245 | ERROR | [x] Inline comments must start with a capital letter
1245 | ERROR | [x] Comments may not appear after statements
1281 | ERROR | [ ] Class constants must be uppercase; expected NAME but found name
1304 | ERROR | [ ] Public method name "Polygon::toKML" is not in lowerCamel format
1318 | ERROR | [ ] Class constants must be uppercase; expected NAME but found name
1338 | ERROR | [ ] Class constants must be uppercase; expected NAME but found name
1355 | ERROR | [ ] Public method name "GeometryCollection::toWKT" is not in lowerCamel format
1364 | ERROR | [ ] Public method name "GeometryCollection::toGeoJSON" is not in lowerCamel format
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\config\install\core.entity_view_display.node.fiche_sit.teaser.yml
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
33 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\config\install\field.field.node.fiche_sit.body.yml
-------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------
25 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\config\install\field.field.node.fiche_sit.field_rubriques_sit.yml
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
31 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\config\install\field.field.node.fiche_sit.field_rubrique_sit_canonique.yml
-------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
31 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\config\install\field.storage.node.field_code_sit.yml
---------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------
17 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\config\install\field.storage.node.field_rubriques_sit.yml
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
22 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\config\install\field.storage.node.field_rubrique_sit_canonique.yml
-----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
22 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\config\install\node.type.fiche_sit.yml
-------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------
14 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------
FILE: C:\pylot_bridge\config\install\taxonomy.vocabulary.rubrique_sit.yml
--------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------
11 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\config\res\field.field.node.fiche_sit.field_content_category.yml
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
23 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\config\res\field.storage.node.field_content_category.yml
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
22 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\console.services.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
16 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: C:\pylot_bridge\drush9_custom_commands.info.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
6 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: C:\pylot_bridge\overrides\mosl\module_mosl\assets\css_K9V-_HfExIuxnGS83rGV2ki2YzkjzR3M4QdASDuvDfE.css
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\overrides\mosl\module_mosl\assets\custom_bridge\fiche.css
--------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\overrides\mosl\module_mosl\assets\custom_bridge\list.css
-------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\overrides\mosl\module_mosl\assets\fiche\css_mWazpAbx-FAVCmiIGCQPMy2ZwKgHBbp61po3CUIwcZ0.css
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\overrides\mosl\module_mosl\assets\fiche\css_WsAlDn0tmiG5AH-Yq501TPy6eqBoZFfdnEZr9xxiaog.css
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\overrides\mosl\module_mosl\assets\list\css_D7iyEhNzRdcF9nS9XVKM105_Rtu-beuXdsvaZ2Kkz0M.css
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-----------------------------------------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\overrides\mosl\module_mosl\assets\list\css_UrqZdOKHjsOsUY6sVK0-e_JAmNzBr4aCAVMaFfbZFMk.css
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-----------------------------------------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\overrides\mosl\module_mosl\mosl.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\overrides\mosl\templates-bridge-twig\fiche\_specifique\mosl\blocks-mosl\button-cv.html.twig
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 16 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
18 | ERROR | [x] Short PHP opening tag used with echo; expected "<?php echo $cvPreviewLink ..." but found "<?= $cvPreviewLink ..."
19 | ERROR | [x] Short PHP opening tag used with echo; expected "<?php echo $bridgeMsgAddedtoCv ..." but found "<?= $bridgeMsgAddedtoCv ..."
20 | ERROR | [x] Short PHP opening tag used with echo; expected "<?php echo $bridgeMsgAddToCv ..." but found "<?= $bridgeMsgAddToCv ..."
21 | ERROR | [x] Short PHP opening tag used with echo; expected "<?php echo $bridgeMsgAlreadyInCv ..." but found "<?= $bridgeMsgAlreadyInCv ..."
25 | ERROR | [x] Short PHP opening tag used with echo; expected "<?php echo ( ..." but found "<?= ( ..."
25 | ERROR | [x] Expected 1 space before "?"; 0 found
25 | ERROR | [x] Expected 1 space after "?"; 0 found
25 | ERROR | [x] Expected 1 space before ":"; 0 found
25 | ERROR | [x] Expected 1 space after ":"; 0 found
25 | ERROR | [x] Expected 1 space after IF keyword; 0 found
25 | ERROR | [x] Inline control structures are not allowed
25 | ERROR | [x] Short PHP opening tag used with echo; expected "<?php echo esc_attr ..." but found "<?= esc_attr ..."
26 | ERROR | [x] Short PHP opening tag used with echo; expected "<?php echo $msg ..." but found "<?= $msg ..."
28 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\pylot_bridge\overrides\mosl\templates-bridge-twig\liste\moteur\filters\cityproxdyn.html.twig
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
237 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------
Shruu_rao → made their first commit to this issue’s fork.
Hi,
Reviewed MR !1 as of #9, could still see some errors and warning.
FILE: C:\combined_image_style\combined_image_style.module
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\combined_image_style\src\Controller\ImageStyleDownloadController.php
------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------
FILE: C:\combined_image_style\src\Entity\CombinedImageStyle.php
-------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
47 | WARNING | [ ] Possible useless method overriding detected
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------
FILE: C:\combined_image_style\src\Entity\ImageStyle.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
FILE: C:\combined_image_style\src\Plugin\Field\FieldFormatter\ResponsiveImageFormatter.php
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------
FILE: C:\combined_image_style\src\Routing\RouteSubscriber.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
Time: 2.53 secs; Memory: 12MB
Hi,
Reviewed #10, the patch is not applying and is throwing following error.
Checking patch README.md...
error: while searching for:
All are optionals.
You can customize the fields order by editing the provided template (block-popin.html.twig).
You can configure the visibility of the popin by date, or globally.
The popin will be displayed once per user session. Update the popin configuration form will reset this setting.
## Installation
You can download this module with composer, and enable it like any other module.
After that, head to blocks structure configuration to add the « Popin block » to a region (footer for example).
(You can use block visibility settings if you want to display the popin only on the frontpage)
Finally you can configure the popin content and visibility on /admin/content/popin.
error: patch failed: README.md:12
error: README.md: patch does not apply
Checking patch css/popin.css...
error: while searching for:
margin-top: 15px;
text-align: center;
}
error: patch failed: css/popin.css:76
error: css/popin.css: patch does not apply
Checking patch popin.module...
error: while searching for:
<?php
/**
* Implements hook_theme().
*/
error: patch failed: popin.module:1
error: popin.module: patch does not apply
Checking patch src/Form/PopinConfigForm.php...
error: while searching for:
namespace Drupal\popin\Form;
use Drupal\Core\Cache\Cache;
use Drupal\Core\Datetime\DrupalDateTime;
use Drupal\Core\Form\ConfigFormBase;
use Drupal\Core\Form\FormStateInterface;
use Drupal\Core\Config\ConfigFactoryInterface;
use Drupal\Core\Session\AccountProxyInterface;
use Drupal\file\Entity\File;
use Drupal\file\FileUsage\FileUsageInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Drupal\Core\Config\ConfigManagerInterface;
/**
* Class PopinConfigForm.
*/
class PopinConfigForm extends ConfigFormBase {
/**
* @var FileUsageInterface
*/
protected $fileUsage;
/**
* @var AccountProxyInterface
*/
protected $currentUser;
error: patch failed: src/Form/PopinConfigForm.php:3
error: src/Form/PopinConfigForm.php: patch does not apply
Checking patch src/Plugin/Block/PopinBlock.php...
error: while searching for:
use Drupal\Core\Block\BlockBase;
use Drupal\Core\Config\ConfigFactoryInterface;
use Drupal\Core\Datetime\DrupalDateTime;
use Drupal\file\Entity\File;
use Drupal\image\Entity\ImageStyle;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
use Drupal\Core\Session\SessionManagerInterface;
use Drupal\Core\Session\AccountProxyInterface;
use Symfony\Component\HttpFoundation\RequestStack;
/**
* Provides a 'PopinBlock' block.
error: patch failed: src/Plugin/Block/PopinBlock.php:5
error: src/Plugin/Block/PopinBlock.php: patch does not apply
Hi,
Reviwed MR !3, still getting some errors.
\entity_notes\entity_notes.install
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_notes\src\Entity\EntityNote.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_notes\src\Entity\EntityNoteAccessControlHandler.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_notes\src\Entity\EntityNoteInterface.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_notes\src\Entity\EntityNotesListBuilder.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_notes\src\Entity\EntityNoteViewBuilder.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_notes\src\Entity\EntityNoteViewsData.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_notes\src\Form\EntityNoteForm.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_notes\src\Form\EntityNotesConfigForm.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_notes\src\Plugin\Derivative\EntityNotesLocalTasks.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_notes\src\Routing\EntityNotesRoutes.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
Hii,
Reviewed MR 9!, still can see some phpcs errors.
\cl_editorial\modules\sdc_tags\src\Controller\ComponentTaggingController.php
-------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------
242 | ERROR | Key specified for array entry; first entry has no key
279 | ERROR | No key specified for array entry; first entry specifies key
-------------------------------------------------------------------------------------------------
\cl_editorial\src\Element\ComponentSelectorElement.php
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
91 | ERROR | Key specified for array entry; first entry has no key
---------------------------------------------------------------------------
\cl_editorial\src\Form\ComponentFiltersFormTrait.php
-------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------
50 | ERROR | Key specified for array entry; first entry has no key
-------------------------------------------------------------------------
\cl_editorial\src\NoThemeComponentManager.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
71 | ERROR | Key specified for array entry; first entry has no key
----------------------------------------------------------------------
Hii,
patch applied cleanly for #26 but still there are some errors.
\entity_print\modules\entity_print_views\src\Controller\ViewPrintController.php
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------
\entity_print\src\Asset\AssetCollector.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_print\src\Controller\EntityPrintController.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_print\src\Entity\PrintEngineStorageInterface.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_print\src\EntityPrintPermissions.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_print\src\Event\PrintEventBase.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_print\src\EventSubscriber\PrintEngineExceptionSubscriber.php
-----------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------
\entity_print\src\Form\SettingsForm.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_print\src\Plugin\EntityPrint\PrintEngine\DomPdf.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_print\src\Plugin\EntityPrintPluginManager.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_print\src\Plugin\PrintEngineInterface.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_print\src\PrintBuilder.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
\entity_print\src\Renderer\RendererBase.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------
Addressed the remaining errors and warnings of #15, created a patch and a interdiff file
Thank you !!
Addressed the remaining errors and warnings of #15, Created a patch and an interdiff file.
Hii,
After applying the patch #14, the patch is successfully applied, but there are still some errors found when running the phpcs command.
\group_domain\src\EventSubscriber\PathRequestSubscriber.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
148 | ERROR | Missing short description in doc comment
149 | ERROR | Description for the @return value must be on the next line
--------------------------------------------------------------------------------
\group_domain\src\Plugin\views\filter\DomainGroupContent.php
---------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
---------------------------------------------------------------------------------
23 | ERROR | Missing member variable doc comment
24 | ERROR | Missing member variable doc comment
25 | ERROR | Missing member variable doc comment
27 | ERROR | Doc comment is empty
112 | WARNING | Unused variable $tq.
---------------------------------------------------------------------------------
Reviewed the MR !77(#6), still found many errors and warnings
Shruu_rao → made their first commit to this issue’s fork.
Shruthi rao → made their first commit to this issue’s fork.