- Issue created by @sonam_sharma
- ๐ฎ๐ณIndia Raveen Kumar
Raveen Thakur โ made their first commit to this issueโs fork.
- Assigned to sonam_sharma
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 9:34am 3 July 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
Since this issue is using PHP_CodeSniffer, let us rescope this issue.
The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.
- Assigned to imustakim
- Issue was unassigned.
- Assigned to priyanka_chauhan31
- Issue was unassigned.
- First commit to issue fork.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
I would rather first apply the patch given in ๐ Automated Drupal 10 compatibility fixes Needs review , and then fix this.
- First commit to issue fork.
- ๐ฎ๐ณIndia pray_12
Hi,
adressed the #13 comment and applied the patch .There are many phpcs errors and warnings that need to be resolved. - ๐ญ๐บHungary dj1999
@pray_12 please check this if you have time https://git.drupalcode.org/project/paypal_plus/-/merge_requests/2
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
I left out the warnings/errors about the functions not prefixed by the module machine name, or the ones about using dependency injection, as those require changes that are not backward compatible. I would leave those to separate issues.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The list of warnings/errors has been updated for this merge request.
Let's fix the dependency injection problems in another issue.
- Status changed to Postponed
9 months ago 10:55pm 10 March 2024 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
I would postpone this issue on ๐ \Drupal calls should be avoided in classes, use dependency injection instead Needs work , which requires less changes.