🇮🇳India @imustakim

imustakim → created an issue.

Patch #3 merged.

imustakim → made their first commit to this issue’s fork.

Closing this issue because one already exist: https://www.drupal.org/project/taxonomy_translation_imp_exp/issues/3437443 🐛 PHP 8.1: count(): Argument #1 ($value) must be of type Countable|array RTBC

imustakim → created an issue.

MR updated.
Please review.

MR Updated.
Please review.

MR Updated for review.

MR Updated.
Please review.

MR Updated, but still these errors remain.

FILE: C:\Sites\Projects\ssom-3371743\oauth2_server\oauth2_server.routing.yml
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------
  7 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
 13 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
 19 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
 27 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
------------------------------------------------------------------------------------------------------------------


FILE: C:\Sites\Projects\ssom-3371743\oauth2_server\src\Controller\OAuth2Controller.php
--------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------
 373 | WARNING | There must be no blank line following an inline comment
--------------------------------------------------------------------------------------

Updated patch and issue summary with css, js errors.
Please review.

Issue summary updated.

Fixed all the issues related to phpcs.
Updated the patch.
Please review.

MR Updated.

Please ignore the #13 patch.

Patch updated.
Please review.

MR is updated.
Please review.

MR Updated.
Please review.

MR updated.
Please review.

Issue summary updated.

Issue summary updated.

I faced some issue while creating the merge request.
So Updating the patch, please review. Address all the issue mentioned in #9 📌 Fix the issues reported by phpcs Needs review .

MR updated. Please review.

imustakim → made their first commit to this issue’s fork.

Updated the MR as per the suggestion and fixed all the issue related to code sniffer.
Please review.

As per suggestions by @apaderno, Changes have been made, and to address some of the concern mentioned in #31 📌 Fix the issues reported by phpcs Needs review , only these errors are remaining.
Assuming these can be ignored. Rest of the errors are fixed.
Patch is updated, please review.

FILE: /Users/specbee/Sites/Projects/entity_browser/src/Form/EntityBrowserForm.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 131 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/entity_browser/src/Plugin/EntityBrowser/Widget/View.php
-------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
 41 | WARNING | Line exceeds 80 characters; contains 85 characters
-------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/entity_browser/src/Plugin/EntityBrowser/Display/Standalone.php
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
 48 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------------------------

Time: 3.16 secs; Memory: 18MB

MR updated.
Please review.

Patch updated.
Still these two warnings are showing up because of the class namespace in constructor description, assuming this can be ignored.
Please review.

FILE: /Users/specbee/Sites/Projects/email_content_templates/src/Controller/PreviewController.php
------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
 41 | WARNING | Line exceeds 80 characters; contains 90 characters
------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/email_content_templates/src/EmailContentTemplatesService.php
------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
 40 | WARNING | Line exceeds 80 characters; contains 90 characters
------------------------------------------------------------------------------------------------

Time: 341ms; Memory: 12MB

@froboy I've created an MR and updated the issue summary and tags.
Please review.

Issue summary updated.

Updated the MR.
Please review.

Patch updated.
Please review.

@roberttabigue please remove css from your phpcs command, Refer #16.

Addressed all the suggestion mentioned in #8 📌 Fix the issues reported by phpcs Needs work .
Please review the MR.

Hey, @podarok, Didn't know about the css.
Raised the MR and removed the css changes.
Please review.

MR updated and now only these two issues are remaining because these lines contains link and we can't break it.
Assuming these can be ignored.
Rest of the errors are fixed.
Please review.

FILE: /Users/specbee/Sites/Projects/bootstrap_pages-3373757/CONTRIBUTOR.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
  38 | WARNING | Line exceeds 80 characters; contains 84 characters
 152 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------

Time: 417ms; Memory: 10MB

Patch updated and interdiff attached.
Please review.

Issue summary updated.

Issue summary updated.

Issue summary updated.

Issue summary updated.

Issue summary updated.

Only this error is remaining because of class namespace in constructor description, Assuming this can be ignored.
MR Updated, Please review.

FILE: /Users/specbee/Sites/Projects/merlinone-3376138/src/Plugin/EntityBrowser/Widget/MerlinOneSearch.php
---------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 36 | WARNING | Line exceeds 80 characters; contains 91 characters
---------------------------------------------------------------------------------------------------------

Time: 362ms; Memory: 10MB

Fixed all the coding standard issues.
Patch updated and interdiff attached.
Please review.

Issue summary updated.
Added coding standard tag to the issue.

Issue summary updated.

Issue summary updated.

Issue summary updated.

Patch updated and interdiff attached.
Please review.

MR updated.
Please review.

Issue summary updated.

Issue summary updated.

Issue summary updated.