- Issue created by @roshni27
- Issue was unassigned.
- Status changed to Needs review
12 months ago 1:54pm 7 July 2023 - Status changed to Needs work
12 months ago 6:57am 13 July 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
Thanks @roshni27 for your contribution. Would you please create an issue fork and provide a merge request instead of a patch? That's the new way for code contribution and it makes collaboration on it much easier for all participants. In the current code there are still some code style issues (e.g. a blank line after the class declaration and also type declaration for the new variable). I'll look into them in more details when the MR is available.
- Assigned to roshni27
- @roshni27 opened merge request.
- Issue was unassigned.
- Status changed to Needs review
12 months ago 9:19am 13 July 2023 - Status changed to Needs work
12 months ago 9:36am 13 July 2023 - First commit to issue fork.
- Status changed to Needs review
12 months ago 11:42am 13 July 2023 - Status changed to Needs work
12 months ago 11:56am 13 July 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
Getting closer. And we have to revert part of the latest changes as I was getting it wrong. Details in the threads of the MR.
- Status changed to Needs review
12 months ago 5:21am 19 July 2023 - 🇮🇳India roshni27
Hello @jurgenhaas,
Yes, you are right; a static create function is not required.I have made changes in MR ,Please review it.
Thanks. - Status changed to Needs work
11 months ago 7:45am 31 July 2023 - Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
11 months ago 2:08pm 31 July 2023 -
jurgenhaas →
committed 94ac88cf on 1.0.x authored by
roshni27 →
Issue #3373232 by roshni27, sakthi_dev, jurgenhaas: Fix the warnings/...
-
jurgenhaas →
committed 94ac88cf on 1.0.x authored by
roshni27 →
- Status changed to Fixed
11 months ago 4:01pm 31 July 2023 - Status changed to Needs work
11 months ago 3:03pm 1 August 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
This MR broke even more, re-opening and reworking the module.
-
jurgenhaas →
committed 237d6170 on 1.0.x
Issue #3373232 by roshni27, jurgenhaas, sakthi_dev, imustakim, apaderno...
-
jurgenhaas →
committed 237d6170 on 1.0.x
- Status changed to Fixed
11 months ago 3:09pm 1 August 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
Now fixed again and published version 1.0.1 with the fix.
Automatically closed - issue fixed for 2 weeks with no activity.
