Fix the issues reported by phpcs

I have applied provided patch.
Patch get apply cleanly.
moving to RTBC

Thank you Ashutosh for testing the patch.

The report is for seven files, but the patch changes only six files.

-  public function download($arg1 = 'test', $options = [
+  public function download($arg1 = 'test', array $options = [
     'stream_proxy_id' => '',
     'fid' => 0,
   ]) {

Method and function declarations must be on a single line.

-    $request_path_info = rawurldecode($request->getPathInfo());
+    // $request_path_info =
+    rawurldecode($request->getPathInfo());

The existing line and the changed line are not even equivalent. Comments starting with // are single-line comments.
Furthermore, if a line must be removed, it does not need to be commented out; it is removed.

Updated patch #1 by addressing #5, please review it.

Thanks!

-    foreach ($results as $uri) {
+    foreach ($results as $results) {

I do not see any reason to change the variable name, but the changed code is not correct.

Fixed all the issues related to phpcs.
Updated the patch.
Please review.

Hi @imustakim,

Applied patch #9 successfully, it threw errors mostly about "Multi-line function declarations ...".

simple_proxy git:(1.0.x) curl https://www.drupal.org/files/issues/2023-10-24/3373619-9.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 12810  100 12810    0     0  38383      0 --:--:-- --:--:-- --:--:-- 39537
patching file src/Commands/SimpleProxyCommands.php
patching file src/Controller/ModalCredentialsController.php
patching file src/Entity/StreamProxy.php
patching file src/EventSubscriber/ImageDownloadControllerSubscriber.php
patching file src/EventSubscriber/SimpleProxySubscriber.php
patching file src/Form/CredentialsForm.php
patching file src/Plugin/ConfigurableStreamHandlerPlugin.php
patching file src/Plugin/StreamHandler/PrivateStreamHandler.php
patching file src/Plugin/StreamHandler/PublicStreamHandler.php
patching file src/Plugin/StreamHandlerPluginBase.php
patching file src/StreamProxyListBuilder.php
patching file src/StreamProxyManager.php
➜  simple_proxy git:(1.0.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig simple_proxy

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/simple_proxy/src/StreamProxyManager.php
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 96 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/simple_proxy/src/Plugin/ConfigurableStreamHandlerPlugin.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 38 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/simple_proxy/src/Plugin/StreamHandler/PrivateStreamHandler.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 35 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/simple_proxy/src/Plugin/StreamHandler/PublicStreamHandler.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
 34 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/simple_proxy/src/Plugin/StreamHandlerPluginBase.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 89 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/simple_proxy/src/Commands/SimpleProxyCommands.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------
 50 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 75 | ERROR | [x] Expected 1 space between comma and "'fid'"; 0 found
 75 | ERROR | [x] Expected one space after the comma, 0 found
 75 | ERROR | [x] Comma not allowed after last value in single-line array declaration
 75 | ERROR | [x] Expected one space after the comma, 0 found
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------

Time: 833ms; Memory: 12MB

Kindly check

Thanks,
Jake

silvi.addweb → made their first commit to this issue’s fork.

Please review MR!2, added changes of patch #9 and also solved other issues reported by phpcs.

Hi @silvi.addweb,

Applied MR!2's plain diff, confirmed all errors/issues fixed.

simple_proxy git:(1.0.x) curl https://git.drupalcode.org/project/simple_proxy/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 15997    0 15997    0     0  42491      0 --:--:-- --:--:-- --:--:-- 43588
patching file src/Commands/SimpleProxyCommands.php
patching file src/Controller/ModalCredentialsController.php
patching file src/Entity/StreamProxy.php
patching file src/EventSubscriber/ImageDownloadControllerSubscriber.php
patching file src/EventSubscriber/SimpleProxySubscriber.php
patching file src/Form/CredentialsForm.php
patching file src/Plugin/ConfigurableStreamHandlerPlugin.php
patching file src/Plugin/StreamHandler/PrivateStreamHandler.php
patching file src/Plugin/StreamHandler/PublicStreamHandler.php
patching file src/Plugin/StreamHandlerPluginBase.php
patching file src/StreamProxyListBuilder.php
patching file src/StreamProxyManager.php
➜  simple_proxy git:(1.0.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig simple_proxy
➜  contrib git:(main) ✗

Will now move this to RTBC

Thanks,
Jake