- Issue created by @indrapatil
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:16am 11 July 2023 - Status changed to Needs work
over 1 year ago 2:25pm 21 July 2023 - 🇵ðŸ‡Philippines roberttabigue
Hi @Indrapatil,
After applying the latest MR !2 to the Bootstrap Pages module against 8.x-1.x-dev on Drupal 9.5.10, I'm still seeing several errors:
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/bootstrap_pages/CONTRIBUTOR.md ---------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 24 WARNINGS AFFECTING 24 LINES ---------------------------------------------------------------------------------------------------------- 30 | WARNING | Line exceeds 80 characters; contains 113 characters 35 | WARNING | Line exceeds 80 characters; contains 135 characters 36 | WARNING | Line exceeds 80 characters; contains 90 characters 48 | WARNING | Line exceeds 80 characters; contains 236 characters 52 | WARNING | Line exceeds 80 characters; contains 192 characters 60 | WARNING | Line exceeds 80 characters; contains 93 characters 63 | WARNING | Line exceeds 80 characters; contains 427 characters 65 | WARNING | Line exceeds 80 characters; contains 128 characters 70 | WARNING | Line exceeds 80 characters; contains 171 characters 74 | WARNING | Line exceeds 80 characters; contains 115 characters 76 | WARNING | Line exceeds 80 characters; contains 151 characters 77 | WARNING | Line exceeds 80 characters; contains 448 characters 83 | WARNING | Line exceeds 80 characters; contains 99 characters 87 | WARNING | Line exceeds 80 characters; contains 294 characters 100 | WARNING | Line exceeds 80 characters; contains 81 characters 101 | WARNING | Line exceeds 80 characters; contains 101 characters 102 | WARNING | Line exceeds 80 characters; contains 142 characters 103 | WARNING | Line exceeds 80 characters; contains 103 characters 105 | WARNING | Line exceeds 80 characters; contains 137 characters 106 | WARNING | Line exceeds 80 characters; contains 81 characters 112 | WARNING | Line exceeds 80 characters; contains 91 characters 114 | WARNING | Line exceeds 80 characters; contains 100 characters 131 | WARNING | Line exceeds 80 characters; contains 82 characters 135 | WARNING | Line exceeds 80 characters; contains 234 characters ---------------------------------------------------------------------------------------------------------- Time: 500ms; Memory: 10MB
I'm moving this for now to Needs work for investigations.
Thank you! - Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 3:29pm 26 July 2023 - 🇨🇦Canada imustakim Canada
MR updated and now only these two issues are remaining because these lines contains link and we can't break it.
Assuming these can be ignored.
Rest of the errors are fixed.
Please review.FILE: /Users/specbee/Sites/Projects/bootstrap_pages-3373757/CONTRIBUTOR.md -------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------- 38 | WARNING | Line exceeds 80 characters; contains 84 characters 152 | WARNING | Line exceeds 80 characters; contains 81 characters -------------------------------------------------------------------------- Time: 417ms; Memory: 10MB
- Status changed to RTBC
over 1 year ago 5:00pm 26 July 2023 - 🇵ðŸ‡Philippines roberttabigue
Hi,
I applied the latest MR and confirmed I'm seeing the 2 issues remaining mentioned above which can be ignored.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig bootstrap_pages/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
- First commit to issue fork.
- Status changed to Fixed
8 months ago 12:01am 30 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.