🇮🇳India @indrapatil

Bangalore
Account created on 4 July 2019, over 5 years ago
#

Recent comments

🇮🇳India indrapatil Bangalore

@mlncn
Yes, I retested with the latest version 8.x-1.0-beta6. I can delete it for the translated node.
Drupal 10.2.

🇮🇳India indrapatil Bangalore

Thank you @shweta__sharma
I tested your patch i attached a screenshot
RTBC +1

🇮🇳India indrapatil Bangalore

Hello Team,

I've noticed that this module is in search of a new maintainer. I'm keen on taking up the role to enhance the codebase, get it ready for Drupal 10, and address the reported bugs in the issue queue.

🇮🇳India indrapatil Bangalore

Hi,
I have attached the config file plz review it and let me know of any changes.
Thank you

🇮🇳India indrapatil Bangalore

Hello @stefvanlooveren

Here is my suggestion

Effortlessly organize and access Drupal module categories with a tabbed layout. No more searching – find what you need quickly.

or

Easily manage your Drupal modules using a simple tabbed layout.

🇮🇳India indrapatil Bangalore

Hello @stefvanlooveren

Here is my suggestion.

"Simplify file data management in Drupal with this user-friendly module"

🇮🇳India indrapatil Bangalore

Hello @stefvanlooveren

Is this description ok?

"WebProfiler adds a handy toolbar to the site, showing stats like database queries and service usage, helping you optimize performance."

or

"Enhance site performance with Web Profiler! Monitor database queries and services easily on your site using a convenient toolbar."

"

🇮🇳India indrapatil Bangalore

@voleger TO test this issue can you plz update the following below
Problem/Motivation
Steps to reproduce
Proposed resolution

Thank you

🇮🇳India indrapatil Bangalore

Thank you for the patch @swatidhurandhar It is working as per the resolution so moving to RTBC.

🇮🇳India indrapatil Bangalore

@smustgrave we need to add an assertion for the Name field or Machine-readable field.

🇮🇳India indrapatil Bangalore

Hello,
Since it has not maintained for a long time I would like to maintain this module and I can assure you continued success of the module
Please let me know what the next steps are.

Thank you.

🇮🇳India indrapatil Bangalore

Hi
I have tested the patch it working I attached the screenshot for reference.

🇮🇳India indrapatil Bangalore

Hi, I worked on the files which are listed in the remove_t_list.txt file. Please let me know if this is correct.
In this other than assertEquals() it has all the t() functions listed.

Please guide me if anything needs to be done.

🇮🇳India indrapatil Bangalore

I Reviewed patch #16 I attached the screen shot

🇮🇳India indrapatil Bangalore

@ravi kant Its working #3 for me.

🇮🇳India indrapatil Bangalore

I reviewed the patch Able to see the Filters icons I am attaching the screen shot for reference.

🇮🇳India indrapatil Bangalore

@ravi kant
My mistake I checked in Drupal 9. Now I tested for Drupal 10 getting the same error.
" The website encountered an unexpected error. Please try again later."

🇮🇳India indrapatil Bangalore

I reviewed this patch. I attached the screenshot.

🇮🇳India indrapatil Bangalore

I installed this "composer require 'drupal/xmlsitemap:^1.4'"
It's working for me.

🇮🇳India indrapatil Bangalore

@Dheeraj Jhamtani I tested your patch and applied it successfully.
RTBC +1.

🇮🇳India indrapatil Bangalore

Indrapatil made their first commit to this issue’s fork.

🇮🇳India indrapatil Bangalore

Update the patch for this issue. Please review it.

🇮🇳India indrapatil Bangalore

Apologies my Previous changes are unexpected changes in the composer.json and I reverted and attached the patch.

🇮🇳India indrapatil Bangalore

@smustgrave i fixed "80 instances of = strtolower($this->randomMachineName( "
and added an updated patch with interdiffs please review and let me know if any changes are required.

🇮🇳India indrapatil Bangalore

@longwave Please review my updated patch and let me know of any changes.

🇮🇳India indrapatil Bangalore

Yes, i agree with @smustgrave there were 27 changes there I fixed them and I go through @longwave #10 I worked for Multibyte also But I am not sure weather to include them in a single patch. please guide me if any changes are required in my patch.

🇮🇳India indrapatil Bangalore

@longwave I updated the patch please review.

🇮🇳India indrapatil Bangalore

Hello @Gauravvvv

there are two options to consider for addressing the issue related to the "Name" and "Machine-readable" fields which are hidden in the Add form mode:

1.Make the "Name" Field Mandatory:
If the "Name" field is intended to be mandatory for creating a new form mode, you should add the necessary validation to enforce this requirement. Additionally, it would be essential to provide a visual indication (mandatory sign or asterisk) in the user interface to inform users that the "Name" field is required. By doing so, users will know they need to provide a value for the "Name" field before they can successfully create a new form mode.

2. Remove Validation for the Machine-Readable Field:
If the "Machine-readable" field is causing confusion or if it's not necessary to be mandatory for the form mode creation, you could consider removing the validation for this field. This would allow users to create new form modes without having to provide a value for the "Machine-readable" field. However, it's essential to assess the implications of removing this validation and ensure that it won't lead to unintended consequences or issues in the system.

The decision between these two options depends on the requirements and design of the project. If the "Machine-readable" field is not a critical aspect of the form mode creation, removing its validation might be a reasonable solution. On the other hand, if the "Name" field is a crucial piece of information and should be mandatory for the creation process, then adding the necessary validation and visual indication would be appropriate.

🇮🇳India indrapatil Bangalore

Hello @bendqh1
These web pages have empty space issues because of the below CSS.

.page-wrapper {
max-width: var(--max-bg-color);
background: var(--color--white);
}

max-width: var(--max-bg-color); is creating the empty space.
If we make 100% then it will be fixed.

🇮🇳India indrapatil Bangalore

I verified this patch and attached the screenshot before and after.
RTBC + 1.
Thank you.

🇮🇳India indrapatil Bangalore

With reference to #10, i am moving to RTBC.

🇮🇳India indrapatil Bangalore

I tested this patch and it's working as expected I attached the screenshot for this after testing.
RTBC + 1.
Thank you

🇮🇳India indrapatil Bangalore

I fixed the issue please review the patch.

🇮🇳India indrapatil Bangalore

@chi This issue from yesterday I was facing in my system
$ vendor/bin/drush cr
[notice] The file assets://css was not deleted because it does not exist.
[notice] The file assets://js was not deleted because it does not exist.
[success] Cache rebuild complete.

The front end totally broke the css after that I tried disabling
Aggregate CSS files
Aggregate JavaScript files

Now the site is working but when I run the vendor/bin/drush cr
still exist errors.
[notice] The file assets://css was not deleted because it does not exist.
[notice] The file assets://js was not deleted because it does not exist.

🇮🇳India indrapatil Bangalore

Hi @guardiola86
I applied the patch it worked fine and I wasn't able to reproduce the error given.
Let's wait for someone else to review as well.
RTBC + 1

🇮🇳India indrapatil Bangalore

Sure @larowlan I will work on the other issues.
Thank you.

🇮🇳India indrapatil Bangalore

Patch applied cleanly so moving to RTBC.

🇮🇳India indrapatil Bangalore

Patch applied cleanly so moving to RTBC.

🇮🇳India indrapatil Bangalore

Hi @arti
You need to update the command which we need to run to test.
patch applied cleanly so moving to RTBC.

🇮🇳India indrapatil Bangalore

The patch is working well so moving to RTBC WIth your #6 comment @vishal.

🇮🇳India indrapatil Bangalore

The patch is working well so moving to RTBC.

🇮🇳India indrapatil Bangalore

reviewed the patch it's working So moving to RTCB

🇮🇳India indrapatil Bangalore

With this patch, the some of issues will fix
https://www.drupal.org/project/security_review/issues/3370990 📌 t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead Closed: won't fix

🇮🇳India indrapatil Bangalore

Still I am working on it.

Production build 0.71.5 2024