Random machine names no longer need to be wrapped in strtolower()

Removed all the calls to strtolower().

Thanks for working on this!

+++ b/core/modules/file/tests/src/Functional/FileFieldWidgetTest.php
@@ -299,7 +299,7 @@ public function testPrivateFileComment() {
-    $name = strtolower($this->randomMachineName());
+    $field_name = $this->randomMachineName();

The variable name here is changed incorrectly and causes the tests to fail.

@longwave I updated the patch please review.

Back to needs review.

Applied the patch and searched for = strtolower($this->randomMachineName() and still found 27 instances

Not sure if we want to cover mb_strtolower too here.

Yes let's remove the multibyte versions here as well, no need to do them separately imho.

Yes, i agree with @smustgrave there were 27 changes there I fixed them and I go through @longwave #10 I worked for Multibyte also But I am not sure weather to include them in a single patch. please guide me if any changes are required in my patch.

+++ b/core/lib/Drupal/Component/Utility/Html.php
@@ -71,7 +71,7 @@ class Html {
-      static::$classes[$class] = static::cleanCssIdentifier(mb_strtolower($class));
+      static::$classes[$class] = static::cleanCssIdentifier($class);

We don't want to remove calls like this, only the ones in tests where we call $this->randomMachineName().

Sure @longwave I will rework on this

@longwave Please review my updated patch and let me know of any changes.

Can we include interdiffs please.

The file sizes are jumping all over the place.

Now I'm finding 80 instances of = strtolower($this->randomMachineName(

@smustgrave i fixed "80 instances of = strtolower($this->randomMachineName( "
and added an updated patch with interdiffs please review and let me know if any changes are required.

Apologies my Previous changes are unexpected changes in the composer.json and I reverted and attached the patch.

sourabhjain → closed merge request !4487

Something went wrong in the creation of the last MR, it is 850 commits behind on 11.x

Update the patch for this issue. Please review it.

Fixing up credit for bad MRs and CC failure patches.

Searching for mb_strtolower($this->randomMachineName and strtolower($this->randomMachineName and seems all instances have been replaced.

Committed b175481 and pushed to 11.x. Thanks!

lauriii → closed merge request !4513

lauriii → closed merge request !4508

lauriii → closed merge request !4488

Automatically closed - issue fixed for 2 weeks with no activity.