undefined - Contrib.social

Since we have focused in on the handling of setting a uid which doesn't correspond to a user on Node, I thought I would see how the same scenario is handled for comments.

drush ev "\Drupal::entityTypeManager()->getStorage('comment')->create(['entity_id' => 2, 'entity_type' => 'node', 'field_name' => 'comment', 'comment_type' => 'comment', 'uid' => 12345, 'comment_body' => ['value' => 'This is the comment body', 'format' => 'basic_html']])->save();"

The result of this is to store the uid is given:

SELECT * FROM comment_field_data;
+-----+--------------+----------+--------+-------+------+-----------+---------+------+------+----------+----------+------------+------------+--------+-------------+------------+------------------+
| cid | comment_type | langcode | status | uid   | pid  | entity_id | subject | name | mail | homepage | hostname | created    | changed    | thread | entity_type | field_name | default_langcode |
+-----+--------------+----------+--------+-------+------+-----------+---------+------+------+----------+----------+------------+------------+--------+-------------+------------+------------------+
|   1 | comment      | en       |      0 | 12345 | NULL |         2 | NULL    | NULL | NULL | NULL     | NULL     | 1719581477 | 1719581477 | 01/    | node        | comment    |                1 |
+-----+--------------+----------+--------+-------+------+-----------+---------+------+------+----------+----------+------------+------------+--------+-------------+------------+------------------+

It seems there is a desire to not allow the storing of nodes if a specified uid does not match a stored user. See #9. But, if this is expensive perhaps it is better to just allow the storing of the uid as provided. This could be achieved by removing the following:

From \Drupal\node\Entity\Node::presave()

// If no owner has been set explicitly, make the anonymous user the owner.
      if (!$translation->getOwner()) {
        $translation->setOwnerId(0);
      }

Is there any appetite to just remove this code and not throw an exception at all?

🐛 | Drupal core | Non-existent node author user IDs are silently converted to 0 (?) (without validation errors)

Comment 9 months ago →

🇬🇧United Kingdom nlisgo

I can recreate the issue in 11.x.

drush ev "\Drupal::entityTypeManager()->getStorage('node')->create(['title' => 'test', 'type' => 'article', 'uid' => 12345])->save();"

SELECT * FROM node_field_data;
+-----+-----+---------+----------+--------+-----+-------+------------+------------+---------+--------+------------------+-------------------------------+
| nid | vid | type    | langcode | status | uid | title | created    | changed    | promote | sticky | default_langcode | revision_translation_affected |
+-----+-----+---------+----------+--------+-----+-------+------------+------------+---------+--------+------------------+-------------------------------+
|   2 |   2 | article | en       |      1 |   0 | test  | 1719579473 | 1719579473 |       1 |      0 |                1 |                             1 |
+-----+-----+---------+----------+--------+-----+-------+------------+------------+---------+--------+------------------+-------------------------------+

🐛 | Drupal core | Announce tabledrag warning message to Assistive tech

Comment 9 months ago →

🇬🇧United Kingdom nlisgo

@Lendude, since you marked this issue as postponed in #3 the only comment that possibly calls for any next steps are in #7. And the next steps are not clear to me, could you perhaps update the issue summary?

🐛 | Drupal core | Deprecated function: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\field_ui\Form\FieldStorageAddForm->buildForm()

Comment 9 months ago →

🇬🇧United Kingdom nlisgo

Drupal\field_ui\Form\FieldStorageAddForm is in the field_ui module. Therefore, any use of $this->config('field_ui.settings')->get('field_prefix') should be expected to be valid. The config/install and config/schema should be relied upon to set the default of field_ui and to ensure that any change to that matches the schema of string with regex of /^[_a-z]+[_a-z0-9]*$/.

I think given these conditions there is nothing to fix here. If somehow this error is triggered then we need to diagnose and fix the problem not address the symptom.

There is a case where $this->config('field_ui.settings')->get('field_prefix') can be expected to be null in core and that has been handled: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/media...

The above case is justified because field_ui module may not be installed. The same condition is not true with code in the field_ui module.

My strong recommendation is that this issue be "closed (works as designed)".

For those that are experiencing this deprecation warning it is best to create an issue and provide the specific steps to reproduce and we can offer support on ensuring that the field_ui settings are available for you when the field_ui module is installed.

🐛 | Drupal core | Deprecated function: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\field_ui\Form\FieldStorageAddForm->buildForm()

Comment 9 months ago →

🇬🇧United Kingdom nlisgo

I just had it happen on a test project as well, the field_ui.settings config was missing. It shouldn't happen, but it can happen. Might as well deal with it since the fix isn't that complicated anyway, right?

To respond to #3. If this is genuinely a case of "it shouldn't happen" then "might as well deal with it" is not a great approach. If the absence of field_ui.settings config is a condition we want to handle then that may affect the solution. I will try and write a test only MR so that we can agree on the target solution.

🐛 | Drupal core | The Inline form error of a required, limited multiple file widget is rendered twice

Comment 9 months ago →

🇬🇧United Kingdom nlisgo

🐛 | Drupal core | The Inline form error of a required, limited multiple file widget is rendered twice

Comment 9 months ago →

🇬🇧United Kingdom nlisgo

🐛 | Drupal core | The Inline form error of a required, limited multiple file widget is rendered twice

Comment 9 months ago →

🇬🇧United Kingdom nlisgo

The reason we do not experience the issue in claro is because they have a workaround since before it was brought into Drupal core.

This is when the workaround was introduced: https://git.drupalcode.org/project/claro/-/commit/3bb63fdf6ecadd9a9ba87d...

The fix for this should also include removing that workaround code.

🐛 | Drupal core | The Inline form error of a required, limited multiple file widget is rendered twice

Comment 9 months ago →

🇬🇧United Kingdom nlisgo

I can confirm this is happening whether or not client side JS is running.

🐛 | Drupal core | The Inline form error of a required, limited multiple file widget is rendered twice

Comment 9 months ago →

🇬🇧United Kingdom nlisgo

I have been able to recreate the issue in 11.x

I would like to take this on.

🐛 | Drupal core | A translation already exists for the specified language

Comment 10 months ago →

🇬🇧United Kingdom nlisgo

We still need clear steps to recreate the conditions which expose this issue. This should pave the way to a test and fix.

As the request for steps to reproduce has gone unanswered for 3 years (#3). #8 seeks to answer this but it is unclear.

Marking it as Postponed (maintainer needs more info)

🐛 | Drupal core | A translation already exists for the specified language

Comment 10 months ago →

🇬🇧United Kingdom nlisgo

I created a MR which just introduces the change in #16.

Still needs tests and issue summary update.

🐛 | Drupal core | A translation already exists for the specified language

Comment 10 months ago →

🇬🇧United Kingdom nlisgo

nlisgo → made their first commit to this issue’s fork.

🐛 | Drupal core | Stream wrapper reference in JS library causes error in _locale_parse_js_file()

🇬🇧United Kingdom @nlisgo

Merge Requests

!8522A translation already exists for the specified language Closed Show issue Drupal core

!8584Route "_title_arguments" computation may be incorrectClosed Show issue Drupal core

!4540Move hook_schema out of ban.install and create the table lazyOpen Show issue Drupal core

!8570The Inline form error of a required, limited multiple file widget is rendered twiceOpen Show issue Drupal core

Recent comments

!8522A translation already exists for the specified language
Closed
Show issue
Drupal core

!8584Route "_title_arguments" computation may be incorrect
Closed
Show issue
Drupal core

!4540Move hook_schema out of ban.install and create the table lazy
Open
Show issue
Drupal core

!8570The Inline form error of a required, limited multiple file widget is rendered twice
Open
Show issue
Drupal core