Contrib.social

Add destination property to the status message link leads to the Maintenance mode configuration page

Open on Drupal.org →
Created on 29 July 2023, about 1 year ago
Updated 7 August 2023, about 1 year ago

Problem/Motivation

When your website is in maintenance mode, we have an information message with a link to disable it.

I think it would be nice to add a destination property for this link to return to your initial page after disabling maintenance mode.

✨ Feature request
Status

Needs work

Version

11.0 🔥

Component
Link  →

Last updated 3 days ago

Created by

🇺🇦Ukraine _shY Lutsk

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @_shY
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.2 & MySQL 8
    last update about 1 year ago
    29,908 pass
  • @_shy opened merge request.
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇺🇦Ukraine _shY Lutsk
  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇺🇸United States smustgrave

    Can we add a small test assertion to cover this change

  • First commit to issue fork.
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.2 & MySQL 8
    last update about 1 year ago
    29,951 pass, 2 fail
  • @nlisgo opened merge request.
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.2 & MySQL 8
    last update about 1 year ago
    29,951 pass, 2 fail
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇬🇧United Kingdom nlisgo

    Added a test.

    Created a test-only MR and also added the test to the main MR.

  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇺🇦Ukraine _shY Lutsk

    Test failed, return to the "Needs work".

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.2 & MySQL 8
    last update about 1 year ago
    29,951 pass, 2 fail
  • Comment about 1 year ago →
    🇬🇧United Kingdom nlisgo

    Locally on the same commit the same test is passing:

    phpunit app/core/modules/system/tests/src/Functional/System/SiteMaintenanceTest.php 
PHPUnit 9.6.10 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\system\Functional\System\SiteMaintenanceTest
..                                                                  2 / 2 (100%)

Time: 00:44.704, Memory: 10.00 MB

OK (2 tests, 68 assertions)

HTML output was generated
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-261-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-262-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-263-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-264-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-265-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-266-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-267-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-268-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-269-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-270-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-271-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-272-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-273-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-274-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-275-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-276-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-277-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-278-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-279-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-280-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-281-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-282-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-283-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-284-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-285-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-286-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-287-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-288-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-289-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-290-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-291-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-292-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-293-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-294-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-295-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-296-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-297-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-298-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-299-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-300-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-301-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-302-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-303-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-304-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-305-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-306-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-307-37384944.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-308-44249763.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-309-44249763.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-310-44249763.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-311-44249763.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-312-44249763.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-313-44249763.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-314-44249763.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-315-44249763.html
http://127.0.0.1:8080/sites/simpletest/browser_output/Drupal_Tests_system_Functional_System_SiteMaintenanceTest-316-44249763.html

    Have hit test rerun.

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.2 & MySQL 8
    last update about 1 year ago
    29,951 pass, 2 fail
  • Comment about 1 year ago →
    🇬🇧United Kingdom nlisgo

    As far as I can tell this is a bit of a minefield. The test passes when run in isolation but when run along with other tests it fails. I’m worried that this is a case of "test order dependency".

    I’m not quite at the point where I have proof that this is the case but to prove my point I will attempt to trigger that CI only run this 1 test.

    Would appreciate extra eyes on this please.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024