Move BrowserTestBaseTest tests checking WebAssert methods to WebAssertTest

First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Custom Commands Failed
@nlisgo opened merge request.
Status changed to Needs review over 1 year ago2:02am 2 August 2023
Comment over 1 year ago →
🇬🇧United Kingdom nlisgo
I've moved all of the appropriate tests from BrowserTestBase to WebAssert

Some of the tests mentioned in #7 are for Behat\Mink\WebAssert assertions:
- testXpathAsserts
- testFieldAssertsForTextfields
- testFieldAssertsForCheckbox

Cannot locate testFieldAssertsForOptions
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,945 pass
Status changed to RTBC over 1 year ago5:26pm 3 August 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Seems methods mentioned in #7 have been moved minus the 3 in #15

LGTM.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,945 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,952 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,952 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,957 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,957 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,957 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,958 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,046 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,050 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,055 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,057 pass
Comment over 1 year ago →
🇳🇿New Zealand quietone
I'm triaging RTBC issues → .

I looked at this late last night and after reading the IS and comments I don't see anything left to do.

Leaving at RTBC.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,059 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,059 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,097 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
27:55
26:37
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,134 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,135 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,145 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,144 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
30,147 pass
Comment over 1 year ago →
System Message

longwave → committed dfd507fc on 10.1.x
Issue #3187314 by Pooja Ganjage, nlisgo, mondrake, longwave: Move...
Comment over 1 year ago →
System Message

longwave → committed 13f6f9d0 on 11.x
Issue #3187314 by Pooja Ganjage, nlisgo, mondrake, longwave: Move...
Status changed to Fixed over 1 year ago9:10pm 12 September 2023
Comment over 1 year ago →
🇬🇧United Kingdom longwave UK
Committed 13f6f9d and pushed to 11.x. Thanks!

Also cherry-picked back to 10.1.x to keep tests in sync.
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Move BrowserTestBaseTest tests checking WebAssert methods to WebAssertTest

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities