Allow views base tables to define additional cache tags and max age

rerolling the patch for the current version 10.1.x and adding the reroll diff file along with it.

Adding reroll for 10.1.x
please review

Reuploading the #26 patch after removing empty comments

The last submitted patch, 27: 2811041-27.patch, failed testing. View results →

@Abhisheksingh27 please include an interdiff with patches.

#25 appears to be the closest reroll but needs to $modules to be protected.

Patch to make $modules protected. Please, review.

Should we aggregate the changes in the comments from patch #27?

I think #27 included additional changes as the size was 12-14KB while the fix is 7.4

Reviewing #30 the change looks good and the change record is clear.

Think it would be cool if we can eventually set this via a UI? Similar to https://www.drupal.org/project/views_custom_cache_tag → maybe.

Ran the tests locally without the fix as I didn't see the tests-only patch

QueryTest.php and SqlTest.php actually passes which doesn't show a valid test.

I'm going to see if I can help with this issue. I'll be starting by trying to work on a test only patch that adequately expresses the issue.

@smustgrave I was able to verify that QueryTest.php fails without the fix but SqlTest.php passed without the fix.

The SqlTest adjusts seem meaningless if they pass without the fix but the adjustments are needed after the fix.

To demonstrate this I will provide 3 PR's:

• test-only
• fix-only
• test-and-fix

Thanks but just fyi you do an MR you only need 1 now.

There’s a test only feature built into the pipeline.

If you’re going to do patches then just need

Test-only patch
Then full patch in that order

Marking as "Needs review" as I believe the concerns raised in #32 are met by the presentation of the test-only and fix-only MRs.

Hiding patches to make it clearer for committers.

Rebased MR 5039 to make sure the pipeline failure was random and it was.

Change record was written for D8 so that needs to be updated.

Is this providing any UI change by chance?

nlisgo → closed merge request !5038

nlisgo → closed merge request !5037

There are no UI changes.