-
alexpott โ
committed 733dc5fc on 11.x
Issue #2625212 by faline, bbrala, cilefen, bircher, okay19, krishnan.n,...
-
alexpott โ
committed 733dc5fc on 11.x
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
The CR is no longer correct as the class is not moving. I do think that the CR should exist - it should detail that by default if you use the development.services.yml you will can warnings when saving configuration that does not comply with schema. Once the CR is updated this can be set back to RTBC. The solution looks elegant and it's great that this emits warnings rather than errors.
- ๐บ๐ธUnited States smustgrave
Re-run seemed to do the trick. Believe all feedback has been addressed
Nit: add
readonly
to the promoted properties. Otherwise can RTBC.- ๐ณ๐ฑNetherlands bbrala Netherlands
Applied suggestion for grammar and adjusted contructor.
- ๐ณ๐ฑNetherlands bbrala Netherlands
We can decide the namespace, i think this placement is all good.
- ๐บ๐ธUnited States smustgrave
1 small comment but
Consider adding a todo to move it out of the Testing namespace in D9.
And decide on the namespace. There was an initial suggestion of 'Drupal\Core\Config\Schema\ConfigSchemaChecker'. And later the patch used '\Drupal\Core\Config\Devel\ConfigSchemaChecker', which was changed to '\Drupal\Core\Config\Development\ConfigSchemaChecker'.
Is the current namespace '\Drupal\Core\Config\Development\ConfigSchemaChecker' the one to use or something else?
Is the todo still needed?
Has the namespace been decided?