Move ModuleHandler::buildModuleDependencies to extension listing code

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

needs re-roll for 10.1 deprecation and test

re-roll for 10.1, no idea how to add deprecation test as there's no replacement

fix cs

The last submitted patch, 17: 3017017-17.patch, failed testing. View results →

Unrelated failure in LayoutBuilderUiTest

Wonder if we can add a simple test that the deprecation message is returned.

Added a test for the deprecation.

The last submitted patch, 21: 3017017-21.patch, failed testing. View results →

Fixed test

Change code inline with with deprecated menthod

Filed follow-up 📌 Fix Variable $graph might not be defined Fixed

Tests look good.

Note for reviewer/commiter(s)

+++ b/core/lib/Drupal/Core/Extension/ExtensionList.php
@@ -596,4 +597,41 @@ public static function sortByName(Extension $a, Extension $b): int {
+    $graph = [];
+    foreach ($extensions as $extension) {
+      $graph[$extension->getName()]['edges'] = [];
...
+    $graph_object = new Graph($graph);

In follow-up I did just $graph_object = new Graph($graph ?? []);

The last submitted patch, 25: 3017017-25.patch, failed testing. View results →

Random error, commented on 🐛 [random failure] Curl error thrown for http in JSWebAssertTest Fixed

I came here because I saw the draft CR is in the 8.7 branch. The CR needs to be udpdated, adding tag. There is now a deprecation as well that needs to be added to the CR. And given the age of the CR the entire text and title should be reviewed. Thanks.

Now that I am here I have skimmed the comments and I see rerolls and a request for a test (thank you) but I do not see a review of the original code, which is from 2018. I do think we should get some eyes on that. Thanks.