- 🇺🇸United States smustgrave
Reviewing patch #10 on Drupal 10.1 with a standard install
The post update hook worked without issue.
Change record is included
Has test coverage
Post update hook is doing a before/after assertion.Think this is good for the next step.
- Status changed to Needs work
almost 2 years ago 2:31am 3 March 2023 - 🇳🇿New Zealand quietone
I am reviewing the Issue meta data.
This is a change to the UI so adding the Usability tag.
There is a screenshot in the issue summary but it does not state if it is before or after, or when it was made. Is this from the latest patch or something else?
The release note snippet is a phrase, it should be explanation of the change in correct English. See Release note snippets → .
I read the change record. It is good to see a screenshot! The CR is brief, it should be expanded to explain the changes. And it should include before and after code changes, if appropriate.
I skimmed the comments in the patch.
+++ b/core/tests/Drupal/KernelTests/Core/Action/MessageActionTest.php @@ -0,0 +1,88 @@ + * Provides data for message types.Provides data for testMessageActionTypes.
- 🇮🇳India anchal_gupta
I have uploaded the patch
Against addressed #85 comment
