Remove the optional $request argument from outbound path processor

Created on 26 March 2014, over 10 years ago

Updated 17 July 2023, over 1 year ago

Updated: Comment #N

Problem/Motivation

OutboundPathProcessorInterface::processOutbound currently accepts an optional $request parameter. The only subsystem requiring the request when processing outbound paths is the various language path processors.

At the same time it is desirable to remove the dependency of UrlGenerator from the request service. In order to do so, outbound path processing needs to be possible without having to inject the request (or request_stack) into the UrlGenerator.

Proposed resolution

Remove the optional request parameter from OutboundPathProcessorInterface::processOutbound()

Removing the request dependency from the UrlGenerator completely should be done in a follow-up issue.

Remaining tasks

evaluate and commit

User interface changes

API changes

\Drupal\Core\PathProcessor\OutboundPathProcessorInterface::processOutbound() optional argument removal

-  public function processOutbound($path, &$options = array(), Request $request = NULL, CacheableMetadata $cacheable_metadata = NULL);
+  public function processOutbound($path, &$options = array(), CacheableMetadata $cacheable_metadata = NULL);

Beta phase evaluation

📌 Task

Status

Needs work

Version

11.0 🔥

Component

Base →

Last updated about 7 hours ago

Maintained by
🇺🇸United States @effulgentsia
🇬🇧United Kingdom @catch
🇬🇧United Kingdom @alexpott
🇦🇺Australia @larowlan
🇺🇸United States @bnjmnm
🇫🇷France @nod_
🇪🇸Spain @ckrina
🇬🇧United Kingdom @justafish

Created by

🇨🇭Switzerland znerol

Live updates comments and jobs are added and updated live.

Needs change record updates

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇺🇸United States smustgrave
At this time we will need a D10.1 version.

Also this was tagged for change record updates but the change record has been published? Is a new one needed?

Also was tagged for IS which still needs to happen.
Comment almost 2 years ago →
🇮🇳India _utsavsharma
Patch for 10.1.x.
Comment over 1 year ago →
🇬🇧United Kingdom joachim
I'm not keen on this either -- there are use cases where the generated URL needs the context of the request.

For example, in Tome, I want an outbound path processor that only acts in the context of a Tome request -- see 🐛 Base URL option in generate form doesn't work when running Drupal in a sub-directory Active .

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024