JSON:API module should support POSTing dynamic entity references with only `type`, `id`/entity reference field should validate type when setting with entity property

🐛 ResourceTypeRepository wrongly assumes that all entity reference fields have the setting "target_type" Fixed landed!

Rebased on to 11.x and all green now! This was cautiously RTBC before, maybe we can get it there again?

Left a few comments nothing major.

Nits addressed, back to NR.

Seems this has gone through a number of reviews so will lean on that.

Did run the test-only feature to show the tests are failing as expected https://git.drupalcode.org/issue/drupal-3277553/-/jobs/1527829

Feedback from earlier has been addressed.

Believe this one to be good.

@smustgrave. The definition of RTBC includes the following, "Setting an issue to this status is a judgment call: if you have thoroughly tested and reviewed the patch and believe it is ready, you may change the status." I don't think that criteria has been meet in this case because as you say you are leaning on the reviews of others.

Let's have a title update here. The title is a problem statement and is better as a positive statement of what is being fixed. Also, I didn't find a comment that any of the 4 change records have been reviewed. That needs to be done. And all the change records need an update to the branch/version.

I did not review the patch.

Updates made.

Went through the changes again. I have some feedback of thinigs that have changed in core since. Also i'm afraid we need a BC path for the contructor addition. I think @larowlan just missed that.

I think we are ok with no bc path for the topdocumentnornalizer.

https://git.drupalcode.org/search?group_id=2&repository_ref=11.x&scope=b...

No usage. Just to be sure I'll also check the service

And for the service. Think we are golden, no bc path.

https://git.drupalcode.org/search?group_id=2&repository_ref=11.x&scope=b...

Extra note, also read through the cr's

Removed the two dead code lines in test, sounds like nothing to change on the BC side (excellent.)

Might need a rebase, but that single test is failing consistently.

Done, green.

All feedback has been resolved. Think this is ready, ty for the work here.

I read the issue summary and am concentrating on the remaining tasks.
The title has been updated, thank you. However it still long and I do not understand if the comma is separating 2 phrases or the forward slash is. This seems to be fixing multiple things? Is this what it means, "JSON:API validates entity reference fields and supports POSTing dynamic entity references with only 'type' and 'id'"

In #44 @bralla read through the change records so I presume that means they are accurate.
The branch/version on the CRs is correct.

That is the three remaining tasks. I am setting back to NW for a title update.

I then took a closer look at the change records. Since there are four of them I will ask if this issue has too wide a scope?

This change record → isn't really clear in explaining the action the developer should take. It uses 'may' so it is not clear if the change must be made or not or what the consequences are. For example, what happens if a site is using the following code in say Drupal 12? Is this a problem? Does a site using that have to change that code?

meta": {
            "entity_type": "user"
          }

Anyway, I worked on all the change records to convert them to plain language and to correct the casing of JSON:API per the specification. I hope that helps to keep this moving along.