catch → credited jhodgdon → .
Please commit this patch.
I have verified on my site that:
- This module works in Drupal 9 with or without this patch.
- This module does not work in Drupal 10 without this patch.
- This module does work in Drupal 10 with this patch.
Since it doesn't break Drupal 9, and fixes Drupal 10, it seems like a good patch. I didn't test it with any prior versions of Drupal, or with Drupal 11.
Ah, OK. Well it needs an issue summary update, because much of what is in the summary has been taken care of.
I just tested this on the latest -dev code.
All of the problems in the issue summary have been resolved due to fixes from other issues, at least to my satisfaction.
The Content page does still show all of the translations of all of the content, but it works MUCH better:
- The language filter filters you down to just the translations in the language you choose.
- The operations are at the translation level -- for instance, if you choose delete on a translation, you are just deleting that one translation. If you choose delete on one of the the original language rows, you get a coherent warning telling you you're about to delete the [specific languages listed] translations of that node.
So to me, this is working in a way that makes sense. I think we can call this issue fixed.
Yes, and in the case of User accounts (the admin/people page has the same problem if you make User entity translatable), it is *really* not obvious the difference between the translations, because all you see is the username, which is untranslatable.
Note on priority: I am OK with demoting this to major if we are OK with admin/node really being broken for multilingual. But this issue is not that hard to fix and I don't think it's OK to release D8 with admin/node being broken for multilingual. It is definitely very broken -- the UI will lead people to delete entire nodes when they really only meant to delete a translation.
If you read the entirety of that issue, you'll see it was reported as resolved and then later reported as reverted. If you read all 148 comments here, you'll find out that the reason it was reverted is that it caused a huge performance problem (at least I think so from comment #145 above). So we don't currently have a fix, and the issue has been moved off to Drupal 8 for consideration of a good fix.
#120: 296693-hide-empty-admin-120.patch queued for re-testing.
The failed tests are all in language negotiation, and don't look related to this patch? http://qa.drupal.org/pifr/test/42318
I'll request a retest.
There are typos in this patch: groupping should only have 1 P in it.