🇮🇳India @Sivaji_Ganesh_Jojodae

Chennai
Account created on 2 July 2008, almost 17 years ago
#

Merge Requests

More

Recent comments

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

sivaji_ganesh_jojodae changed the visibility of the branch 3514936-modulesuninstallform.php-assigns-string to hidden.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

Closing due to branch issue mentioned in #16.

Fork #3514936 allows to create a features branch from 11.x.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

+1 for @prudloff.

If you grep there are several routes with _access: 'TRUE' as appropriate.

grep -rni \_access: core/modules/*/*.routing.yml | grep -i TRUE

There are several routes

core/modules/big_pipe/big_pipe.routing.yml:9:    _access: 'TRUE'
core/modules/filter/filter.routing.yml:7:    _access: 'TRUE'
core/modules/image/image.routing.yml:55:    _access: 'TRUE'
core/modules/system/system.routing.yml:7:    _access: 'TRUE'
core/modules/system/system.routing.yml:15:    _access: 'TRUE'
core/modules/system/system.routing.yml:23:    _access: 'TRUE'
core/modules/system/system.routing.yml:31:    _access: 'TRUE'
core/modules/system/system.routing.yml:342:    _access: 'TRUE'
core/modules/system/system.routing.yml:352:    _access: 'TRUE'
core/modules/system/system.routing.yml:360:    _access: 'TRUE'
core/modules/system/system.routing.yml:400:    _access: 'TRUE'
core/modules/system/system.routing.yml:407:    _access: 'TRUE'
core/modules/system/system.routing.yml:414:    _access: 'TRUE'
core/modules/system/system.routing.yml:421:    _access: 'TRUE'
core/modules/system/system.routing.yml:459:    _access: 'TRUE'
core/modules/system/system.routing.yml:479:    _access: 'TRUE'
core/modules/system/system.routing.yml:489:    _access: 'TRUE'
core/modules/system/system.routing.yml:519:    _access: 'TRUE'
core/modules/system/system.routing.yml:526:    _access: 'TRUE'
core/modules/user/user.routing.yml:138:    _access: 'TRUE'
core/modules/user/user.routing.yml:148:    _access: 'TRUE'
core/modules/user/user.routing.yml:192:    _access: 'TRUE'
core/modules/user/user.routing.yml:233:    _access: 'TRUE'
core/modules/views/views.routing.yml:6:    _access: 'TRUE'
🇮🇳India Sivaji_Ganesh_Jojodae Chennai

I don't find reference to original interface name change. However I can see usage change in issue #2002134 commit id f6161fad

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

The existing branches are outdated. I'm not able to create a new branch from 11.x.

Hitting create branch button throws error

Failed to create branch '3311358-module-uinstall': invalid reference name '11.x'.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

sivaji_ganesh_jojodae changed the visibility of the branch 3311358-module-uninstall-form to hidden.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

sivaji_ganesh_jojodae changed the visibility of the branch 3311358-module-uninstall-form to active.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

sivaji_ganesh_jojodae changed the visibility of the branch 3311358-module-uninstall-form to hidden.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

I think the feedback is to change as follow,

- @trigger_error('typedConfigManager() is deprecated in drupal:11.2.0 and is removed from drupal:12.0.0. This method is no longer in use instead $this->typedConfigManager to be used. See https://www.drupal.org/project/drupal/issues/3477616', E_USER_DEPRECATED);
+ @trigger_error('typedConfigManager() is deprecated in drupal:11.2.0 and is removed from drupal:12.0.0. The replacement is to use the $this->typedConfigManager as is done in ::validateForm(). See https://www.drupal.org/project/drupal/issues/3477616', E_USER_DEPRECATED);
🇮🇳India Sivaji_Ganesh_Jojodae Chennai

I encountered the same issue. I had to clear cache for the new hook_mail() implementation to get recognized by Drupal.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

Interesting issue. The bug indeed is still around. I can reproduce the issue with the attached test module.

Attached are the screenshots of before and after the MR.

The patch looks straightforward and pipeline looks good as well.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

Inside core/modules/basic_auth/tests I can still find the usage of \Drupal::. Should we change the following occurances as well?

./modules/basic_auth_test/src/BasicAuthTestController.php:16:    \Drupal::state()->set('basic_auth_test.state.controller_executed', TRUE);
./modules/basic_auth_test/src/BasicAuthTestController.php:25:    \Drupal::service('page_cache_kill_switch')->trigger();
./modules/basic_auth_test/src/BasicAuthTestController.php:28:      '#markup' => \Drupal::state()->get('basic_auth_test.state.controller_executed') ? 'yep' : 'nope',
🇮🇳India Sivaji_Ganesh_Jojodae Chennai

Drupal 7 is EOL and I don't think this affects D10+.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

sivaji_ganesh_jojodae changed the visibility of the branch 3504629-process-all-view-arguments to hidden.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

> changed target branch from 11.x to 11.1.x

Should be 11.x

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

The issue seems to exist in both Drupal 10.x and 11.x.

Could someone share any inputs or direction on how to resolve?

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

Updated the MR to reflect comment #34 and earlier.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

The updated code visually looking good to me.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

When $element['#title'] is set, $element['#title'] should be used not NULL.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

It's a quick-fix and pipeline has passed already.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

+1 to mark this issue as duplicate in favor of #2972846.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

Pipeline has failed with following error,

Behat\Mink\Exception\ResponseTextException: The text "Has taxonomy term (= term1)" was not found anywhere in the text of the current page.

.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

Thanks. I will fix the comment line. But there is an error from unit test. See below,

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

Patch #3 re-rolled for branch 11.x.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

sivaji_ganesh_jojodae changed the visibility of the branch 3504567-breadcrumb-ada-fix to hidden.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

sivaji_ganesh_jojodae changed the visibility of the branch 3504567-breadcrumb-ada-fix-2 to hidden.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

sivaji_ganesh_jojodae made their first commit to this issue’s fork.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

On a related note, shouldn't we use wildcard /* instead of empty array [] to indicate the global visibility to be inline with the page visibility settings?

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

@joachim, not sure what I'm missing. Any inputs on the failing test results?

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

Drupal 7 security support has ended as of 5 January 2025. This is the final extension of Drupal 7 end of life – Drupal 7 will no longer receive security updates or compatibility updates

See Drupal 7 End of Life .

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

One of the views has a URL ending with a space. I used ctrl+F on pattern "[space])" to find the occurrence.

See the screenshot below,

Seems like it was configured incorrectly in the first place.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

Facing the same issue with the views admin page. Downgrading symfony/http-foundation to 6.4.12 makes the error go away. Not sure what will be the reliable fix for the issue.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

On a related note, we are getting the following error with the flatten method.

TypeError: Drupal\rest_export_nested\Plugin\views\display\RestExportNested::flatten(): Argument #1 ($data) must be of type array, null given, called in /usr/share/nginx/html/project-consumer-drupal/modules/contrib/rest_export_nested/src/Plugin/views/display/RestExportNested.php on line 45 in Drupal\rest_export_nested\Plugin\views\display\RestExportNested->flatten() (line 92 of /usr/share/nginx/html/project-consumer-drupal/modules/contrib/rest_export_nested/src/Plugin/views/display/RestExportNested.php).

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

Steps in comment #17 helped to work around the issue. Thanks @rduplock!

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

We are requiring this feature in our project. Would like to see this added shortly.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

Let me know if anyone has any inputs. Any help or direction will be much appreciated.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

I think we should remove the core and change the core_version_requirement to support only 9 & 10 (core_version_requirement: ^9 || ^10) since D8 is no longer supported anyway.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

Note that the module also supports Drupal 8 which requires core to be present.

core_version_requirement: ^8.8 || ^9 || ^10
🇮🇳India Sivaji_Ganesh_Jojodae Chennai

I have similar issues. Getting 504 timeout in the interim of the batch process after 3 minutes of starting. Not sure if it is the timeout on the client (guzzle, php-fpm, nginx, or database) or the server's.

Someone from our team indicated checking HTTP 499 which is the client's initiation to discard the request from processing further and the server could respect the same.

The issue seems to be with the entity reference field,

If you have access to your server and PHP configuration, you can extend the max_execution_time in the php.ini.

If there is the usage of PHP-FPM to serve PHP scripts, you have also to adjust the request_terminate_timeout in your FPM config to the same value.

If PHP-FPM has a reverse proxy like Nginx in the front to the user, the fastcgi_read_timeout also needs to be set to the same value, and to all other proxies in the front, you may adjust the proxy_read_timeout value.

Anyway I'm going to try https://www.drupal.org/docs/contributed-modules/entity-share/troubleshoo...

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

@Igor Mashevskyi, let me know if there is anything I can help with. Also, could you provide some direction on resolving the issue?

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

Thanks for working on drupal 10.

Uncaught PHP Exception Error: "Class "Drupal\\commerce_cart_api\\Normalizer\\FieldNormalizer" not found" at core/lib/Drupal/Component/DependencyInjection/Container.php line 259

We are getting the above issue after the upgrade. The site fails to load with a couple of other errors.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

Thanks a lot. I can help with testing.

We have a complex structure of products and variations with reference to other variations and paragraphs.

🇮🇳India Sivaji_Ganesh_Jojodae Chennai

To fix this issue, uninstall login_emailusername and use mail login instead.

Production build 0.71.5 2024