- 🇮🇳India Sivaji_Ganesh_Jojodae Chennai
To fix this issue, uninstall login_emailusername and use mail login → instead.
- @manav opened merge request.
- Status changed to Needs work
almost 2 years ago 2:55pm 16 March 2023 - 🇪🇬Egypt manar_farh
This module uses class LoginEmailUsernameUserAuthenticationController which extends core class UserAuthenticationController,
Currently the core class UserAuthenticationController doesn't use property flood anymore which causes the error instead it uses property userFloodControl,
This is fixed in the attached patch. - Status changed to RTBC
over 1 year ago 5:36pm 19 July 2023 - Status changed to Needs work
10 months ago 6:58am 26 February 2024 - 🇺🇸United States dww
This change was introduced in #2983395: user module's flood controls should do better logging → . See the CR at https://www.drupal.org/node/3067148 → .
- So if we directly change the code per patch #7, this module would no longer be compatible with core prior to 9.1.0 and the
core_version_requirement
inlogin_emailusername.info.yml
would need to change. - Or, we need to conditionally see if we've got a
userFloodControl
member, and if not, gracefully fall back to using aflood
member, instead. Then, the module can continue to be compatible with all modern versions of core.
Needs work for either of these solutions. I'd vote for #2 (easier for end users), but the maintainers might prefer #1 for less technical debt.
- So if we directly change the code per patch #7, this module would no longer be compatible with core prior to 9.1.0 and the
- 🇫🇷France bachbach Le Havre
hi,
here is a patch for #10 option 2, not sure if this is the right method. - 🇦🇺Australia VladimirAus Brisbane, Australia
Thanks everyone for your work.
Please review patch in 📌 Automated Drupal 11 compatibility fixes for login_emailusername Needs review which copies current core functionality and fixes flood and password reset issues.