- @quietone opened merge request.
- Status changed to Needs review
4 months ago 7:40am 25 August 2024 - 🇳🇿New Zealand quietone
Changed to use a phrase of the form, "'rebuild' has been set to TRUE", which is from the docs for \Drupal\Core\Form\FormState::$rebuild.
- Status changed to Needs work
4 months ago 12:02pm 25 August 2024 - 🇬🇧United Kingdom joachim
> I don't think this an improvement, we're taking an awkwardly phrased comment about an API method and making it about a protected property instead.
Agreed -- the protected property is internal.
> If 'rebuild' has been set to TRUE
This doesn't help either. How do I find out more about what 'rebuild' is and how to set it or check for it?
> What about 'If $form_state->isRebuilding() returns TRUE" at least for the first part of the comment.
Maybe. It depends whether the reader of this documentation is trying to know
A. 'how do I know which behaviour I will get here' --> isRebuilding() is the key thing because that's how you find out
B. 'how do I influence which behaviour I will get here' --> isRebuilding() is one step removed from this AND its docs don't tell you how to change that status, and what you actually need to know about is setRebuild()I'd lean towards B.