🇨🇦Canada @danrod

It is fine @marcus_johansson , you may close this issue, I'm ok with that, and I'm glad that the Token module has been added to 2.0, sometimes I am too lazy to install additional dependencies, that's why I created this issue. Cheers!

I made changes in the *.info.yml files as suggested by @robloach. Tested functionality every module seems to work. Needs review again.

Thanks @robloach , I'll have another look on this.

I reviewed this and I can see that the markup has been indented as mentioned (please see screenshots before and after the changes), tested functionality as well. I'll move this to RTBC for now.

Hello @annmarysruthy and @paraderojether , I fixed the issues you pointed out, please review.

After adding the dependencies, should be easier to install the modules. It is a simple fix, but should make life easier for those who want to install the module for the first time and not install extra modules:

danrod → created an issue.

Tested and works as expected (had the same results as your screenshots), the only comment I have is in the code:

 if ($this->entity->isNew() && isset($form['moderation_state']['widget'][0]['state'])) {
      // Map default_status to moderation state: TRUE = 'published', FALSE = 'draft'.
      $default_moderation_state = $default_status ? 'published' : 'draft';
      $form['moderation_state']['widget'][0]['state']['#default_value'] = $default_moderation_state;
    }

Will $this->entity- be NULL on certain situations? I don't think so, but I'm just wondering.

I'll leave this for another extra review to move it to RTBC.

danrod → created an issue.

Hello @breidert , I would like to review this, but I see that the MR is in draft state, but issue status is "Needs Review", is this on purpose? Thanks in advance.

Hello @abhisekmazumdar how can I make the new Form for selecting elements to appear? because I'm setting up an AI automator and trying to follow the instructions below and I couldn't make the new form to appear (what it's being shown in the video). Maybe I am missing something? Do I need to add another AI Model? Please Have a look at the screenshot below, I am setting this to "Needs Work" because I am really confused here. I'm only using OpenAI in my instance:

I'll move it to RTBC for now.

I merged this fix into the 5.0.x, 3.0.x and 8.x-1.x branches, and I created new releases:

https://www.drupal.org/project/languages_dropdown/releases/5.0.2 →
https://www.drupal.org/project/languages_dropdown/releases/3.0.4 →
https://www.drupal.org/project/languages_dropdown/releases/8.x-1.7 →

I'll mark this as "Fixed", thanks a lot for the suggestion @flyke

Thanks a lot for this, I tested this on a B5 theme and works as expected:

I'll move this to RTBC.

danrod → made their first commit to this issue’s fork.

I reviewed this and I got the expected results (the generated audio), please let me know if you want me to upload the file, but I think it's overkill. Code looks ok also: https://git.drupalcode.org/project/ai/-/merge_requests/1129/diffs

It would be great to have a second look before moving this to RTBC.

Thanks @guillaumepacilly , I'll look into the list in detail and see what's missing.

Hi @ryan-l-robinson done, you were granted maintainer status, I'll have a look on this JS this weekend, let's see if my JS skills still have some use.

Count me in !

Thanks for your investigation @ryanrobinson_wlu , I will look into this in detail this weekend, I have a busy day today, by the way, would you like to be a maintainer of this module? I like your contributions to this project, and I think you will do a great job in helping to maintain this module.

Thanks a lot again.

I tested this and I had the same results as the user @jibran above, the button is displayed and clickable. I won't post screenshots since it's kind of redundant (screenshots have been provided already) but I wanted to confirm that it works just in case. This issue can be moved to RTBC if needed.

Thanks @guillaumepacilly , there is an ESLINT warning to fix: https://git.drupalcode.org/issue/jquery_deprecated_functions-3567201/-/j...

Which other deprecated functions are missing? I'll have to check the jQuery docs and look for missing deprecated functions/objects/constants.

I created new releases to fix this issue, with instructions to run drush updatedb:

https://www.drupal.org/project/fluidui/releases/3.0.0 →

https://www.drupal.org/project/fluidui/releases/2.0.3 →

Thanks a lot @ryanrobinson_wlu , gave you the credits !

Tested MR 52 and works like a charm on D10.6 and above, I made some updates in the composer.json and fluidui.info.yml to make it work with D11, I also tested it on D11.2.10 and works fine.

I'll merge this, thanks @ryanrobinson_wlu for your hard work !

I fired up a new DDEV D10.6.1 instance, upgraded from 2.0.1 to 2.0.2 and indeed I saw this error, I didn't catch it because I don't usually do version upgrade tests (something that I will do it from now on).

Thanks a bunch @ryanrobinson_wlu for your hard work, I've been working for the Drupal AI project (I've been paid for that) and quickly forgot about this. I'll review this today and commit it to the 3.0.x/2.0.x branches

Hi @priyansu18 , I'll review this later today, sorry, I've been busy in other projects.

Thanks a lot @mably , looks much better like that !!

Cheers !

Thanks a lot @mably , I see now the directory that feeds that doc page: https://git.drupalcode.org/project/domain/-/tree/3.x/docs?ref_type=heads

I'll review this and make some contributions if some item of feature is missing for description.

Thanks a lot for your input @marcus_johansson , I'll address these issues first thing in the morning (EST time), your information and knowledge has been very valuable to me.

Hi there, are we going to have the Drupal AI meeting today? Can't find the link to the zoom meeting. Thanks in advance.

Makes sense to me, cheers !

Thanks @marcus_johansson and @murz , Could anyone please help reviewing the changes in the issue Fix PHPStan issues on API Explorer 📌 Fix PHPStan issues on API Explorer Active ? I added a bunch of exceptions in the neon file as suggested by s @marcus_johansson and resolved some conflicts after merging the new changes commited in the 2.0.x branch

I also tested the AI API Explorer and works as expected.

Thanks a lot for your investigation @ryanrobinson_wlu , would you dare to create a MR for this ? I'd go for the update hook and the CSS fix instead. I know the language implementation is kind of wonky, it needs to be simplified, but I just don't have the time to look on that at the moment, I'm trying to secure some income at the moment because I really don't have any and I'm broke.

Sorry for the off-topic and thanks for your understanding, I'll help with the update hook and language fixes once I have some free time.

Thanks a lot again.

Thanks a lot @murz , I think I will go with that approach instead of cluttering the phpstan.neon file with a bunch of exceptions.

Hi @murz I had to add exceptions in the issu e Fix PHPStan issues on API Explorer 📌 Fix PHPStan issues on API Explorer Active and I followed all the advices in https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iter... and I just couldn't make it work.
It is true that the PHPDoc at {@inheritdoc} should have all the typehinting information, but for some reason the warning is not gone.

This can be reviewed now, I fixed some of the PHPSTAN issues by applying code changes, but I also added a bunch of exceptions in the phpstan.neon because there were cases in which the tests were failing after applying a fix, so I added some temporary rules, I guess this can be avoided and add real fixes, I am open to suggestions on this.

I also tested the API Explorer and seems to work as expected.

I'll send this to RTBC for now and create a new issue for the CSPELL / PHPCS / PHPSTAN warnings.

Hi @ryanrobinson_wlu could you post a screen with the beige bar please? I don't see this myself, but I am suspecting I need to implement some hook_update_xxxx in order to fix this.

danrod → changed the visibility of the branch 3563396-fix-phpstan-issues to hidden.

danrod → changed the visibility of the branch 3563396-fix-phpstan-issues-on-api to hidden.

Thanks @mbatterton , I tested the new MR 58 and worked as expected (tested the AI Chatbox and the AI Assistants in the CKEditor), the addition of the CHANGELOG-2.0.md was a nice touch for those who want to upgrade to the AI 2.x framework.

Moving this to RTBC for now.

Just following on this one.

Hi @marcus_johansson, thanks for the fix, I was able to use the "LLM: Taxonomy" Automator Type with no problem, I still see some PHPSTAN issues regarding the AI CKEditor functionality, for example:

Line   modules/ai_automators/src/Plugin/AiCKEditor/AiAutomatorsCKEditor.php   
 ------ ----------------------------------------------------------------------- 
  474    Method                                                                 
         Drupal\ai_automators\Plugin\AICKEditor\AiAutomatorsCKEditor::ajaxGene  
         rate() never returns null so it can be removed from the return type.   
         🪪  return.unusedType 

Shall I address these here or is out of scope of this issue?

I'm trying to use an AI Automator to add new taxonomy terms based on the body field content (generated by the CKEditor AI plugin) and I'm running into this error, not sure if it has to do with the latest changes, but I'll test other Automator Types

Error: Call to undefined method stdClass::id() in Drupal\ai_automators\PluginBaseClasses\Taxonomy->getTaxonomyList() (line 353 of modules/contrib/ai/modules/ai_automators/src/PluginBaseClasses/Taxonomy.php).
Drupal\ai_automators\PluginBaseClasses\Taxonomy->generateTokens() (Line: 504)
Drupal\ai_automators\PluginBaseClasses\RuleBase->generate() (Line: 180)
Drupal\ai_automators\PluginBaseClasses\Taxonomy->generate() (Line: 71)
Drupal\ai_automators\AiAutomatorRuleRunner->generateResponse() (Line: 82)
Drupal\ai_automators\Plugin\AiAutomatorProcess\DirectSaveProcessing->modify() (Line: 241)
Drupal\ai_automators\AiAutomatorEntityModifier->markFieldForProcessing() (Line: 139)
Drupal\ai_automators\AiAutomatorEntityModifier->saveEntity() (Line: 34)
ai_automators_entity_presave()
call_user_func_array() (Line: 404)
Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}() (Line: 357)
Drupal\Core\Extension\ModuleHandler->invokeAllWith() (Line: 403)
Drupal\Core\Extension\ModuleHandler->invokeAll() (Line: 217)
Drupal\Core\Entity\EntityStorageBase->invokeHook() (Line: 922)
Drupal\Core\Entity\ContentEntityStorageBase->invokeHook() (Line: 530)
Drupal\Core\Entity\EntityStorageBase->doPreSave() (Line: 767)
Drupal\Core\Entity\ContentEntityStorageBase->doPreSave() (Line: 484)
Drupal\Core\Entity\EntityStorageBase->save() (Line: 804)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (Line: 370)
Drupal\Core\Entity\EntityBase->save() (Line: 281)
Drupal\node\Form\NodeForm->save()
call_user_func_array() (Line: 105)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers() (Line: 43)
Drupal\Core\Form\FormSubmitter->doSubmitForm() (Line: 589)
Drupal\Core\Form\FormBuilder->processForm() (Line: 321)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 627)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 183)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 53)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 715)
Drupal\Core\DrupalKernel->handle() (Line: 19)

I tested this with the latest DEV release of AI 2.x → in order to work on the issue Fix PHPStan issues on AI CKEditor → and the CKEditor AI functionality seems to work as expected (please see the attached screenshots), this will require more testing, but so far it looks ok.

Thanks a lot for your work , I'll plan to do some extra work next work, I was kite busy finishing up some work tasks.

I'd like to look on it once the ChatConsumer is merged, I'm good at fixing PHPCS / PHPSTAN issues.

Thanks @cameron prince

Would you please update the MR with the new change, if possible? Thanks !

Hi @shamir.vs is this MR ready? I still see the CI warnings that need to be addressed.

I'd like to work on this issue, if no one takes it.

danrod → created an issue.

I fixed all the issues and we have the three green checks now: https://git.drupalcode.org/project/block_ajax/-/merge_requests/14

Tested functionality and works as expected. Needs Review.

@ivnish Could we merge this to the 5.0.x branch? This change looks OK and will fix some of the PHPCS coding standard violations that this branch has.

danrod → made their first commit to this issue’s fork.

I tested this patch to fix PHPCS coding standard violations in CI pipeline (see issue # 3554583 📌 Fix PHPCS coding standard violations in CI pipeline Active ) and worked as expected, I'm moving this to "Needs Review", hopefully someone else will have some time to try this as well.