🇨🇦Canada @danrod

Merged to 8.x-1.x now, I'll mark this as "Fixed", I won't include tests here because the Drupal Core version is not compatible with the Gitlab CI/CD configuration.

All jobs are green now, so I'll merge it to the 8.x-1.x branch now: https://git.drupalcode.org/project/many_selects/-/merge_requests/10

danrod → created an issue.

I added the .gitlab-ci.yml file and ran with no issues, there's some addtional PHPCS and CSPELL issues that I'll fix in another branch: https://git.drupalcode.org/project/many_selects/-/merge_requests/9

danrod → changed the visibility of the branch 3520879-add-.gitlab-ci.yml-file to hidden.

danrod → created an issue.

danrod → created an issue.

I'm afraid I will need set this issue aside, I need to do a lot of changes in the module (changing links in the entity files, plugins, etc) and I'm afraid I'll break things up if I continue to work on this one. If anyone wants to take this, be my guest-

I was able to reproduce this, I installed a Drupal instance in a subdirectory (http://subsite.ddev.site/maresmuseum/) and I can see the issue you saw.

1. In the http://subsite.ddev.site/maresmuseum/en/calendar/1/events page, the link of the button "Add Event" must go to http://subsite.ddev.site/maresmuseum/admin/calendar/1/event/add instead the link is http://subsite.ddev.site/admin/calendar/1/event/add

2. Same situation in the http://subsite.ddev.site/maresmuseum/en/calendar/events page , the "List Calendars" button should go to http://subsite.ddev.site/maresmuseum/admin/calendar , instead the button link is http://subsite.ddev.site/admin/calendar

I'll create a MR to address this.

I'll move it to "Fixed" for now, as always, any issues and please let me know and I'll re-open the task.

I'll leave this task to "Needs Review" just in case anyone wants to do extra testing (for credits!)

Added the file composer.libraries.json in the 8.x-1.x branch and tested it ok, merging.

I fixed the composer.libraries.json file and It downloads the correct library version:

daniel@drupal:/var/www/html$ composer require "rubentd/radios-to-slider"
./composer.json has been updated
Running composer update rubentd/radios-to-slider
Loading composer repositories with package information
Updating dependencies
Lock file operations: 1 install, 0 updates, 0 removals
  - Locking rubentd/radios-to-slider (0.2.2)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
  - Downloading rubentd/radios-to-slider (0.2.2)
  - Installing rubentd/radios-to-slider (0.2.2): Extracting archive
Generating autoload files
98 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
phpstan/extension-installer: Extensions installed
No security vulnerability advisories found.
Using version ^0.2.2 for rubentd/radios-to-slider

I'll merge this branch and I'll use the same file in the 8.x-1.x branch

danrod → created an issue.

Good Morning, I'll be looking into this today.

I also made the same fix in the 8.x-1.x branch.

I think I'm ready to create two tagged releases after fixing a lot of issues with the module, will do that tomorrow. Closing this to "Fixed"

I also changed the installer from tar.gz to zip and it seems to work now:

ddev composer require "rubentd/gifplayer"
./composer.json has been updated
Running composer update rubentd/gifplayer
Loading composer repositories with package information
Updating dependencies
Lock file operations: 1 install, 0 updates, 0 removals
  - Locking rubentd/gifplayer (0.3.7)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
  - Installing rubentd/gifplayer (0.3.7): Extracting archive
Generating autoload files
98 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
phpstan/extension-installer: Extensions installed
No security vulnerability advisories found.
Using version ^0.3.7 for rubentd/gifplayer

Seems that all the tests have passed, and tested locally and the module works as usual. Moved to "Fixed" for now.

danrod → created an issue.

Merged.

I committed the file and I can see that the pipelines are being executed with no problems: https://git.drupalcode.org/project/gifplayer/-/merge_requests/12

I'll create another issue to fix the ESLINT / PHPCS / PHSTAN issues.

I'll merge this to the 8.x-1.x branch and mark this as "Fixed"

danrod → created an issue.

danrod → created an issue.

Hi @sirclickalot

I updated the documentation page and created a demo of the Gif Player field in this page: https://dev-d10-date-timepicker.pantheonsite.io/gifplayer

I'll keep the demo page updated with some other stuff, let me know if you need access to it, for now, I'll mark the issue as "Fixed" again.

Thanks a lot @darren.fisher

danrod → created an issue.

No testers, ok, I'll merge to the 3.0.x branch and make a DEV release, this one is still very experimental so I won't create a tagged release out of this. I'll also mark this as "Fixed" for now, but I'll investigate more to see if I can avoid the manual step that I outlined in the README.md file

@darren.fisher no worries, I'll open another issue to request to be maintainer, thanks !

Thanks @sirclickalot

I'll re-open the task and I'll find a way to create a demo on a permanent basis

I can maintain this module if you guys don't mind, I do updates on all the modules I maintain on a daily basis (I'm kinda being paid for this), you may checkout my profile here: https://www.drupal.org/u/danrod →

It's all green now, except for the tests, which I had to delete because the module is not compatible with the Drupal Core version that runs the tests.

I'll move it to "Fixed", if anyone is having any issues, please let me know and I'll re-open the task.

Seems like the instance has expired....

@sirclickalot, it you still need to see a demo, please let me know and I'll set up another one, for now, I'll move this to Fixed, let me know if you need another demo and I'll re-open the task.

danrod → created an issue.

I added the .gitlab-ci.yml file and I see a bunch of ESLINT / PHPCS / PHPSTAN issues to fix, in addition to the missing tests: https://git.drupalcode.org/project/radiostoslider/-/pipelines/478660

I'll create another issue to fix these, for now I'll mark this as "Fixed".

I changed it to:

CKEditor Font Size enables the CKEditor Font Size and Family plugin, which adds drop-downs that apply CSS classes or attributes as inline element style.

Which is 198 characters long, once the user clicks in the module name link, will see that the module is deprecated and there are more alternatives to this.

Marking this as "Fixed", if the description is not updated in a few days, I'll re-open the ticket.

I know the project is deprecated, but at least the summary should point that out in short manner.

danrod → created an issue.

danrod → created an issue.

Hi @sirclickalot:

You can see a demo here: https://master-d4bbwsqxdwn5gn2fqdth3hadxxo5rthq.tugboatqa.com/node/1

it's a simpletest.me temporary instance, send me a pm (from the contact form) to get the username:password if you want to do extra tests.

I was able to setup multiligual settings in the toolbox, and not to lose the translations after the module is upgraded, in the README.md you will see a procedure on how to do that, I'll leave the task to "Needs Review" for now.

Sadly, the documentation for localization support is very bad: https://docs.fluidproject.org/infusion/development/LocalizationInThePref...

I think I'll merge this and move it to "Fixed", I'll delete the Timepicker addon plugin later.

Merged to the 8.x-2.x branch, works as expected as well:

I updated the README.md with extra instructions for installing the new library, I think I'll merge this to the 3.0.x branch and then create another MR for the 8.x-2.x branch.

I'm thinking of creating a fluidui_translations directory in the Drupal public directory (sites/default/files) when installing the module, to store the translatiosn and the table of contents there, and add another field in the config settings page to check which translations to enable.

I think the the table of contents needs to be updated to reflect the latest infusion library changes, I'll have to check that too.

In progress...

I changed the summary above using the standard template, hope it makes sense.

The other plugins seem to work fine:

Patch # 35 worked great to me, using Drupal 11.1.1 on a DDEV instance (PHP 8.3)

I was able to integrate the flatpickr plugin and It looks nice, but I won't drop support for the Timepicker Addon until I'm sure that other plugins are working fine, for now, I'll leave it to "Needs Review" just in case someone wants to have a peek on this.

I fixed most of the issues reported by the Queue Bot, but there's still a PHPSTAN issue to fix: https://git.drupalcode.org/issue/drupal-1818764/-/jobs/5007233

 ------ --------------------------------------------------------------------- 
  Line   core/modules/update/update.module                                    
 ------ --------------------------------------------------------------------- 
  207    Function _update_manager_access not found.                           
         🪪  function.notFound                                                
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  

Where is this function _update_manager_access implemented? was it ever implemented in this MR? I think it's a legacy function from D7 that needs to be refactored here:

/**
 * Access callback: Resolves if the current user can access updater menu items.
 *
 * It both enforces the 'administer software updates' permission and the global
 * kill switch for the authorize.php script.
 *
 * @return
 *   TRUE if the current user can access the updater menu items; FALSE
 *   otherwise.
 *
 * @see update_menu()
 */
function update_manager_access() {
  return variable_get('allow_authorize_operations', TRUE) && user_access('administer software updates');
}

danrod → made their first commit to this issue’s fork.

I added fixes to support older Drupal releases, some Misc fixes that were also applied in the 3.0.x branch and PHPCS Fixes. Tested worked fine for me, I'll close it for now, if anyone is having issues with this module, please let me know and I'll re-open it.

danrod → created an issue.

I did not see this warning in other themes, for now I'll move it to "Fixed", I'll create tagged releases soon.

I updated the infusion library and other files and I was able to make it work in the 2.0.x branch:

I see a strange error in the JS console, but I'm not sure if it's related with the change, for now, I'll leave this task to "Needs Review" until I find out.

Since it's a small change and does not impact the functionality much, I'll move it to "Fixed", if anyone is having any problems, please let me know and I'll re-open this.

I tested this on all branches and it works as expected, I'll leave it to "Needs Review" if anyone wants to get some extra credits (by testing).

I'll move this to "Fixed" and create a tagged release shortly.

I tested it on a few BS5 themes and works as expected:

danrod → created an issue.

I added a new DEV release that is working fine in a BS5-based theme, needs more testing (if anyone wants to score some credits), but I think it's working fine: https://www.drupal.org/project/languages_dropdown/releases/5.0.x-dev →