🇨🇦Canada @danrod

I'll merge it to the 2.0.x, if anyone has any suggestions or things to add, please let me know and I'll re-open the issue.

I think It looks ok, this is ready for review.

Hi @d.fisher I think you can go ahead.

Don't forget to git rebase & apply the patch just in case.

danrod → created an issue.

Thanks again, I'll merge to the 2.0.x branch.

Thanks @ankitv18 for this, I see a deprecation warning, I'll look into this, but it looks ok.

The method $this->assertSession()->statusCodeEquals(200) is deprecated and some cases it was failing on me, so I had to delete it.

Using PHPUnit 11.5.34 and PHP 8.4.10 for the tests.

Thanks a bunch @ankitv18 !!

I admit that the Tugboat settings are new to me and I haven't had the time to read through the documentation to work on this, thanks a lot again.

Giving the credits and merging.

Fixed, thanks for letting me know, gave you the credits:

- https://git.drupalcode.org/project/many_selects/-/blob/2.0.x/README.md?r...
- https://git.drupalcode.org/project/many_selects/-/blob/8.x-1.x/README.md...

Hi @ankitv18 , thanks for letting me know. I'll fix it now (for both branches).

Thank you @ankitv18

Thanks @ankitv18 , I fixed the link. Moving this to "Fixed"

Thanks a lot @ankitv18, fixed and deleted some redundant authors:

Thanks a lot for fixing the ESLINT and STYLEINT issues, @ankitv18

danrod → created an issue.

I think it looks better that way, a review would be nice.

Moving this to "Needs Review".

danrod → changed the visibility of the branch 3542766-update-readme.md-to-8x to active.

danrod → changed the visibility of the branch 3542766-update-readme.md-to-8x to hidden.

danrod → created an issue.

Fixed the PHPCS and PHPSTAN errors, kindly review.

I'll look into the PHPCS / PHSTAN errors

Tested and worked great, merging this to the 3.0.x branch.

danrod → made their first commit to this issue’s fork.

No problem, you will have to use the dev release for now, until I fix some critical issues and then I'll create a tagged release.

Hello,

I created a MR against the 2.0.x branch to fix these PHP 8.4 deprecation issues, I hope it's the correct branch, if not, I can do the same for the 8.x-1.x branch.

Kindly review, thanks.

danrod → changed the visibility of the branch 3542886-php-8.4-support to hidden.

Thanks @anweshas you are right, the cart is fine as it is now and will be up to the frontend developer to make the changes as desired.

I'll move it as "Closed (works as designed)"

Thanks for your input.

I'll move it to "Needs work" for now. I'll probably continue working with it tomorrow.

I'll merge this to the 2.0.x branch as well.

Merging this to the 2.0.x branch.

danrod → created an issue.

The README.md file looks ok now, probably needs to be updated to the other branches as well. I'll set it to "Needs Review" for now.

Changed the README.md file and looks better now, I'll appreciate a review (I'll give a credit).

Moving this to "Needs Review".

It looks better now, I'll move it to "Needs Review", hopefully someone will look on that.

I'll merge it to the 1.0.x branch then.

I'll merge this to the 2.0.x branch.

Looks much better now, an extra look would be nice. Setting this to "Needs Review".

I think It looks ok now, a review will be nice (will give a credit !!).

Moved to "Needs Review".

danrod → created an issue.

danrod → created an issue.

danrod → created an issue.

danrod → created an issue.

danrod → created an issue.

Thanks @neerajsingh, and I agree with removing the extra return before the execution of batch_set.

Merging this to the 3.0.x branch.

Thanks !

Looks ok to me @neerajsingh and thanks for fixing the PHPCS issues.

I'll merge this to the 3.0.x branch.

danrod → created an issue.

danrod → created an issue.

Thanks @neerajsingh

danrod → created an issue.