🇨🇦Canada @danrod

I'll merge this, it's just documentation changes.

Thank you everyone.

I'll do some tests myself as well.

I included the instructions for the fix from #18 in the README.md file in this MR.

Can be reviewed anytime.

Strange, I was expecting more than one jquery version.
I'll do some checks myself.

I'll move it to "Fixed" for now, if anyone is having problems with this, please let me know and I'll re-open the task.

I tested it on a D11 instance and worked fine:

I created a MR to address this (using matoeil's code), needs review.

Done: https://www.drupal.org/project/webform_intl_tel_national_mode/releases/1... →

Needs testing.

I'll go ahead with the new alpha release

I've moved this to "Needs Review" just in case you decide to go ahead with the MR.

danrod → created an issue.

It seems like the maintainers are absent over this module.
I'll request to be a maintainer of this.

Isn't this more like an issue for the Gin Admin team to address?

danrod → created an issue.

@joseph.olstad Interesting, I guess most of the clients prefer WordPress over Drupal 11 because of the templating system which is similar to the Drupal 7 templating system and the gutenberg editor which has a lot of components (blocks).

I was tempted to learn WordPress just to score extra work (need the extra money badly), but after seeing that I don't think It's a good idea, I'd rather invest my time in learning something else.

Thanks a lot for sharing this.

danrod → created an issue.

It seems to work now:

I don't think it needs further testing now, I'll merge it to the 1.0.x branch.

It is all green now, I'll merge it to the 1.0.x branch and work on the once() issue that is quite urgent.

https://git.drupalcode.org/project/webform_intl_tel_national_mode/-/pipe...

There's a bunch of errors related to the old jQuery once not supported anymore, I'll address these here:

Uncaught TypeError: $(...).find(...).once is not a function
    at Object.attach (webform.element.telephone.js?sznlzb:26:10)
    at drupal.js?v=11.1.5:166:24
    at Array.forEach (<anonymous>)
    at Drupal.attachBehaviors (drupal.js?v=11.1.5:162:34)
    at HTMLUListElement.<anonymous> (ajax.js?v=11.1.5:1402:18)
    at jQuery.each (jquery.js:383:19)
    at jQuery.each (jquery.js:205:17)
    at Drupal.AjaxCommands.insert (ajax.js?v=11.1.5:1394:19)
    at ajax.js?v=11.1.5:1046:41Understand this error
drupal.js?v=11.1.5:64 Uncaught TypeError: $(...).find(...).once is not a function
    at Object.attach (webform.element.telephone.js?sznlzb:26:10)
    at drupal.js?v=11.1.5:166:24
    at Array.forEach (<anonymous>)
    at Drupal.attachBehaviors (drupal.js?v=11.1.5:162:34)
    at HTMLAnchorElement.<anonymous> (ajax.js?v=11.1.5:1402:18)
    at jQuery.each (jquery.js:383:19)
    at jQuery.each (jquery.js:205:17)
    at Drupal.AjaxCommands.insert (ajax.js?v=11.1.5:1394:19)
    at ajax.js?v=11.1.5:1046:41Understand this error
drupal.js?v=11.1.5:64 Uncaught TypeError: $(...).find(...).once is not a function
    at Object.attach (webform.element.telephone.js?sznlzb:26:10)
    at drupal.js?v=11.1.5:166:24
    at Array.forEach (<anonymous>)
    at Drupal.attachBehaviors (drupal.js?v=11.1.5:162:34)
    at HTMLUListElement.<anonymous> (ajax.js?v=11.1.5:1402:18)
    at jQuery.each (jquery.js:383:19)
    at jQuery.each (jquery.js:205:17)
    at Drupal.AjaxCommands.insert (ajax.js?v=11.1.5:1394:19)
    at ajax.js?v=11.1.5:1046:41Understand this error
drupal.js?v=11.1.5:64 Uncaught TypeError: $(...).find(...).once is not a function
    at Object.attach (webform.element.telephone.js?sznlzb:26:10)
    at drupal.js?v=11.1.5:166:24
    at Array.forEach (<anonymous>)
    at Drupal.attachBehaviors (drupal.js?v=11.1.5:162:34)
    at HTMLUListElement.<anonymous> (ajax.js?v=11.1.5:1402:18)
    at jQuery.each (jquery.js:383:19)
    at jQuery.each (jquery.js:205:17)
    at Drupal.AjaxCommands.insert (ajax.js?v=11.1.5:1394:19)
    at ajax.js?v=11.1.5:1046:41Understand this error
drupal.js?v=11.1.5:64 Uncaught TypeError: $(...).find(...).once is not a function
    at Object.attach (webform.element.telephone.js?sznlzb:26:10)
    at drupal.js?v=11.1.5:166:24
    at Array.forEach (<anonymous>)
    at Drupal.attachBehaviors (drupal.js?v=11.1.5:162:34)
    at HTMLAnchorElement.<anonymous> (ajax.js?v=11.1.5:1402:18)
    at jQuery.each (jquery.js:383:19)
    at jQuery.each (jquery.js:205:17)
    at Drupal.AjaxCommands.insert (ajax.js?v=11.1.5:1394:19)
    at ajax.js?v=11.1.5:1046:41Understand this error
drupal.js?v=11.1.5:64 Uncaught TypeError: this.$el.children(...).drupalToolbarMenuHorizontal is not a function
    at r.renderHorizontal (MenuVisualView.js?v=11.1.5:37:46)
    at r.render (MenuVisualView.js?v=11.1.5:28:14)
    at r.initialize (MenuVisualView.js?v=11.1.5:20:14)
    at h.View (backbone.js:1340:21)
    at new r (backbone.js:2112:41)
    at toolbar.js?v=11.1.5:137:47
    at Array.forEach (<anonymous>)
    at Object.attach (toolbar.js?v=11.1.5:80:59)
    at drupal.js?v=11.1.5:166:24
    at Array.forEach (<anonymous>)Understand this error
drupal.js?v=11.1.5:64 Uncaught TypeError: $(...).find(...).once is not a function
    at Object.attach (webform.element.telephone.js?sznlzb:26:10)
    at drupal.js?v=11.1.5:166:24
    at Array.forEach (<anonymous>)
    at Drupal.attachBehaviors (drupal.js?v=11.1.5:162:34)
    at drupal.init.js?v=11.1.5:32:12
    at HTMLDocument.listener (drupal.init.js?v=11.1.5:20:7)Understand this error
drupal.js?v=11.1.5:64 Uncaught TypeError: $(...).find(...).once is not a function
    at Object.attach (webform.element.telephone.js?sznlzb:26:10)
    at drupal.js?v=11.1.5:166:24
    at Array.forEach (<anonymous>)
    at Drupal.attachBehaviors (drupal.js?v=11.1.5:162:34)
    at HTMLAnchorElement.<anonymous> (ajax.js?v=11.1.5:1402:18)
    at jQuery.each (jquery.js:383:19)
    at jQuery.each (jquery.js:205:17)
    at Drupal.AjaxCommands.insert (ajax.js?v=11.1.5:1394:19)
    at ajax.js?v=11.1.5:1046:41Understand this error
drupal.js?v=11.1.5:64 Uncaught TypeError: $(...).find(...).once is not a function
    at Object.attach (webform.element.telephone.js?sznlzb:26:10)
    at drupal.js?v=11.1.5:166:24
    at Array.forEach (<anonymous>)
    at Drupal.attachBehaviors (drupal.js?v=11.1.5:162:34)
    at success (ajax.js?v=11.1.5:1833:20)
    at l (loadjs.min.js?v=4.3.0:1:217)
    at loadjs.min.js?v=4.3.0:1:1712
    at Array.n (loadjs.min.js?v=4.3.0:1:1639)
    at u (loadjs.min.js?v=4.3.0:1:117)
    at loadjs.min.js?v=4.3.0:1:1443Understand this error
drupal.js?v=11.1.5:64 Uncaught TypeError: $(...).find(...).once is not a function
    at Object.attach (webform.element.telephone.js?sznlzb:26:10)
    at drupal.js?v=11.1.5:166:24
    at Array.forEach (<anonymous>)
    at Drupal.attachBehaviors (drupal.js?v=11.1.5:162:34)
    at HTMLDivElement.<anonymous> (ajax.js?v=11.1.5:1402:18)
    at jQuery.each (jquery.js:383:19)
    at jQuery.each (jquery.js:205:17)
    at Drupal.AjaxCommands.insert (ajax.js?v=11.1.5:1394:19)
    at ajax.js?v=11.1.5:1046:41

It seems to be working now:

And I've updated the documentation: Finally, Copy the bootstrap directory (which should be there already) located at `/vendor/entreprise7pro/bootstrap` to the `/web/libraries` directory.

I'll set it to "Needs Review" just in case anyone wants to test it.

Updates on library installations

I merged a few more changes, this should fix it, I'll make a final test.

It seems like the latest release of the Bootstrap theme → already comes with entreprise7pro/bootstrap , so a bit of refactoring is needed to integrate it with the theme. I'll create a new branch for that.

I created a new MR to address this, and some documentation → changes of course, I'll merge it to the 8.x-1.x-dev branch and try the installation on a fresh Drupal instance to see if it works.

Changed library information

danrod → created an issue.

I added a new README.md which can be reviewed in the MR, I think it looks OK and has the information that the user needs to install this module.

I'm settings to "Needs Review" now just in case someone wants to have a look on it.

I'll address the PHPCS / ESLINT issues here: https://www.drupal.org/project/webform_intl_tel_national_mode/issues/353... 🐛 Fix ESLINT / PHPCS issues Active

I'm closing this issue for now.

danrod → created an issue.

The pipeline ran with no major issues, but there's some ESLINT / PHPCS issues that need to be address. I'll open a new issue for that: https://git.drupalcode.org/project/webform_intl_tel_national_mode/-/pipe...

This change isn't working for me, it is just reverting the out-of-the-box phone validation, unless I am missing something here:

danrod → created an issue.

Merged to the 1.0.x branch.

I reviewed this, looks good, will merge MR 3 now.

danrod → created an issue.

I applied the patch and works as expected, screenshot attached:

Before:

After:

This can be reviewed now, I'll merge it to the 1.0.x branch later today.

I'll merge this quickly !!!

After a few many changes, I deleted and modified a bunch of config files, and now the site install correctly. I also changed the documentation for guiding the uses on how to add the fields for the products and other configuration: https://www.drupal.org/docs/extending-drupal/themes/contributed-themes/s... →

I think it's working fine now, I'm going to apply a few other fixes then I'll jump into the 5.x version

Added images in order to help the user how to create products and the fields they need

Added a section for the product types

More information added for the fields

New information for the new fields

Added a new section

Thanks @luke.leber !

I'll review the current status of the project today.

Thanks @luke.leber , I created the issue as requested: https://www.drupal.org/project/webform_intl_tel_national_mode/issues/353... 📌 Offering to be a maintainer Active

Please let me know if I need anything else to become a maintainer.

danrod → created an issue.

This does not affect the stable release: https://www.drupal.org/project/sshop/releases/8.x-1.15 →

danrod → created an issue.

@joseph.olstad thanks, will do during some free time tomorrow, I never jumped into the NodeJS wagon really (but I like JS), I'd rather learn to use Rust or a Python framework to create a website.

PHP is a more mature language with new features that you would expect from a modern language, the problem is that Drupal didn't catch up on time with these new features while other CMS did, that's why more and more people are migrating their Drupal sites to WordPress.

I know a client in Ottawa that had an old D9 site and was offered his site to be migrated to D11 or WordPress, the D11 proposal was cheaper. way, guess which one the client chose?

Experience Builder is a great idea but it came up late. WordPress has had these features since ages ago.

It's all green now, could anybody review this? If not I'll merge it shortly.

It seems like there is only outstanding STYLEINT issue to fix: https://git.drupalcode.org/project/gifplayer/-/pipelines/550762

danrod → created an issue.