🇨🇦Canada @danrod

Ohhh sorry I didn't see that the HST value wasn't being added to the Subtotal, but printed for information purposes, I'll close this issue as "Won't fix", sorry !

danrod → created an issue.

Thanks @sd9121 I'll create a few more issues and then we are ready for the BS5 migration and Drupal Recipes.

Thanks !

Merged to the default branch, thanks !

It looks ok to me, I'll merge this, thanks !

@sd9121 bear in mind that I still need to commit some config changes in order for you to work on this, see this issue 🐛 Save changes done to the theme files (config/templates) for the commerce blocks and other views Active

I'll look on that shortly

danrod → created an issue.

The slider looks much better, but I had to resort to some ugly hacking 🐛 Drupal 11 - jQuery 4.0.0-beta2 and legacy jquery.cycle.js Active in the views_slideshow module, which I'll avoid by creating a new contrib module to address that.

It is strange, I will post a video, when I click on the mobile menu, it collapses out as expected but then it goes back to the intial state (the menu collapses in).

I am fixing all the D11 compatibility problems in these issues:

https://www.drupal.org/project/sshop/issues/3523670 🐛 Save changes done to the theme files (config/templates) for the commerce blocks and other views Active
https://www.drupal.org/project/sshop/issues/3523670 🐛 Save changes done to the theme files (config/templates) for the commerce blocks and other views Active

It's working fine and dandy in Drupal 11.1.7, but still there are some styling/presentation issues to address, for now I'll mark this as "Fixed"

danrod → created an issue.

Hi @sd9121 thank you, It worked like a charm:

I'll mark this as "Fixed" and give you the credits of course.

Would you like to help testing and working on more issues on this theme before launching a tagged release? I'd like to have this before migrating this theme to Bootstrap 5 and using Drupal recipes instead of theme features.

Moved to "Fixed", I'll create another issue for the styling on the cart dropdown.

Thanks @sd9121 ,

Would it be possible to add this to the issue fork sshop-3523794 and create a MR, please?

Thanks !

Merged to the default branch.

danrod → created an issue. See original summary → .

I was able to get it back finally, after some configuration changes that were lost in previous commits:

The cart dropdown may need some addtional theming/styling, but I'll open a new issue for that.

I'll set to "Needs Review" for now.

I'll merge the changes to the 8.x-1.x branch to fix other issues that depend on this.

danrod → created an issue.

I applied some misc config/theming/styling changes and the single node page looks much better:

I'll move it to "Needs Review", just in case anyone want to have look for it (Novice users)

The slider seems to be working now, thanks to some advice I got in the issue # 3485144 🐛 Drupal 11 - jQuery 4.0.0-beta2 and legacy jquery.cycle.js Active in the Views Slideshow → module, still there's some work to do because the arrows are not showing up:

danrod → created an issue. See original summary → .

I'll merge this file to the default branch.

Thanks for your work on this, appreciate it, but I have a few questions.

1. Instead creating a patch for an old github library, why don't you just fork it and add the changes that we need to make it work in D11.
2. Instead of the extra "custom" module that you attached and you expect us to install it with no prior checking, why don't we create a contrib project for supporting all these deprecated jQuery fuctions that we need?

Please let me know and I can help on this, for now I'll work the jQuery Cycle project and add your changes there, if you don't mind.

Done, please review again, sorry for the commit comment, the $defaults string was replaced with an empty string.

I add a MR for this with the config changes and I can see that the field is mandatory and the text is displayed in the blog teasers:

Ready for review.

I created a MR to add this table.

I suggest to replace the README.txt with a README.md and follow the template guidelines: https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →

Hello @joachim I actually deleted the $defaults property and its docs, I don't see it being used anywhere in the class (or module). Please review.

Ok, another one to merge to the default branch.

I created another MR to fix this: https://git.drupalcode.org/project/sshop/-/merge_requests/34

Hopefully someone can help me with testing this (credits!). Moved to "Needs Review"

I'll merge it to the 8.x-1.x branch as well.

I fixed this in the MR 33, feel free to review anyone if you wanna get extra credits !

I'll leave it for "Needs Review" for a while

I'll merge it to 8.x-1.x as I need it to fix other issues.

danrod → created an issue.

danrod → created an issue.

danrod → created an issue.

I applied some SCSS fixes and it looks much better and the icon & input field are aligned:

I'll move it to "Needs Review" just in case anyone wants to take a peek on this.

I'll merge this to the 8.x-1.x in order to fix other issues and mark this as "Fixed", if any questions, please let me know.

I created a MR for this: https://git.drupalcode.org/project/sshop/-/merge_requests/30

Tested locally and downloaded the libraries with no issue, I'll leave this to "Needs Review" if anyone wants to review this.

danrod → created an issue.

I merged and tested the new changes and works as expected, moving this to "Fixed" again.

danrod → changed the visibility of the branch 3522884- to hidden.

Given that I received no response from the issue I created in their github's page, I decided to fork the project, include the function I needed it and compile it again, I have my own release: https://github.com/danrod96-new/bootstrap/releases/tag/v1.0.0

I re-opened this to update these files to reflect the new Bootstrap 3 fork release:

composer.libraries.json
estore.libraries.yml
README.md

I'll create a new MR for this.

I'll move this to "Fixed", since the priority is to fix the UX issues, make sure the installation sets up the right fields, modify the templates and fix the slider.

danrod → created an issue.

danrod → created an issue.

It's all green now: https://git.drupalcode.org/project/sshop/-/pipelines/492764

I'll leave it to "Needs Review" for a while, I'll work on some front-end issues that are a priority to fix<

I was able to make it work on both D10/D11, I'll post a tagged release soon, there's a lot of issues to be fixed in this theme, for now I'll mark this as "Fixed", if anyone has any concerns with the gitlab configuration, please let me know and I'll re-open the task.

danrod → created an issue.

The pipeline ran with it with no issues, but there's some PHPCS/ESLINT/.. issues that I'll address in another issue: https://git.drupalcode.org/project/sshop/-/pipelines/492369

I'll merge this to the 8.x-1.x branch, but I'll leave it to "Needs Review" for now, until I'm sure this theme can be installed on both D10/D11.

danrod → created an issue.

danrod → created an issue.

danrod → created an issue.

danrod → created an issue.

Merged!