🇨🇦Canada @danrod

For some reason, the "composer" tests are failing, I'll look into this later.

danrod → created an issue.

I created a MR for this, please review.

danrod → created an issue.

Thanks ! merging this to the main branch

Thanks @avpaderno

I addressed the issues you pointed out, and can be reviewed in the 1.0.x branch now: https://git.drupalcode.org/project/webform_intl_tel_national_mode

I couldn't move the hook hook_library_info_alter() to a class method because this is implemented in a contrib module (Libraries) and their API doesn't any information if I can implement this as a class method or not.

This looks good to me. I'll approve it.
Thanks @ankitv18

I'lll update it with yours.
Thanks.

You should see the changes now. Plase review @ankitv18

I edited the summary for a shorter one:

This module provides a machine name field. If you just need a stand-alone machine name field, use this. If you want two fields tied together (a frequent UI pattern in Drupal core), use Safeword.

Let's wait for it to be updated in the project browser page, I'll leave it to "Needs Review" for now.

danrod → created an issue.

danrod → created an issue.

This is ready for review @ankitv18 , I made some fixes in the README.md file as well.

Makes sense, I'll work on that.

Thanks for the review, I'll merge this to the 8.x.1.x branch

Hi @avpaderno I see, but he's seems pretty busy at the moment and I would like to opt my projects into security coverage.

Thanks @avpaderno for the suggestions, I applied the changes and it's ready for review again. Good to know that it's not a must to provide a composer.json file

Fixed the issue, I'll move it to "Needs Review".
Hopefully someone will review this.

Thanks @vishal.kadam

I addressed the issues you pointed out, and can be reviewed in the DEV version now:

https://www.drupal.org/project/webform_intl_tel_national_mode/releases/1... →
https://git.drupalcode.org/project/webform_intl_tel_national_mode

For some reason, the composer tests are not passing, I'll revisit this issue later, for not I'll set to "Needs Work"

I'll merge this to the 8.x-1.x branch.

danrod → created an issue.

I'm using the latest 1.2.0-alpha2 , I can confirm that the MR !683 works for me.

This is ready for review, kindly review if you have some time @ankitv18

danrod → made their first commit to this issue’s fork.

I created an issue to opt this project into security coverage: https://www.drupal.org/project/projectapplications/issues/3546269 📌 [1.0.x] Webform International Telephone National Mode Needs review

Let's wait and see what happens next.

danrod → created an issue.

I was able to make this work by using a couple of modules:

• Media Thumbnails SVG
• Svg Image

All I had to do is to install the modules, add "svg" in the list of the allowed extensions, and worked fine to me:

SVG file displayed in a node:

SVG in the Media Browser:

I hope this solve this issue.

Thanks for this @ankitv18 , merged to the main branch.

Tested it and looks ok, I'll merge this to the main branch.

danrod → created an issue.

No worries, @benstallings thanks for your help, I'm really stuck with some work stuff and I haven't had time to look in this one, probably I'll revisit this issue this week.

Please do continue with your work, if you have time, and thanks !

I'll move it to "Fixed", if anyone is having any issues with this release, please let me know and I'll re-open the task.

Looks ok to me, I'll merge it to the 8.x-1.x branch.

There's some PHPCS and PHPSTAN issues that need to be fixed, I'll open a new issue for that.

danrod → made their first commit to this issue’s fork.

Hi @abelpzl , thanks for your help on this, I've created an alpha release that works with D10/D11, please try and let me know how it goes.

https://www.drupal.org/project/machine_name/releases/8.x-1.0-alpha1 →

Giving you the credits.

That one is fixed, and we have an alpha release that works with D10/D11: https://www.drupal.org/project/machine_name/releases/8.x-1.0-alpha1 →

Back to this issue, I tested this patch on a D11.2.2 instance and works as expected, I'll merge the last MR and create a release.

danrod → changed the visibility of the branch 3431769-d11-compatibility-new-patch to active.

danrod → changed the visibility of the branch 3431769-d11-compatibility-new-patch to hidden.

danrod → changed the visibility of the branch 3431769-automated-drupal-11 to hidden.

I created the 1.0.0 release which was tested on a D11.2.2 instance: https://www.drupal.org/project/webform_intl_tel_national_mode/releases/1... →

Now that I have a stable release, I'll apply for security coverage.

I'll leave this issue as "Needs Review" for a bit, just in case anyone is having issues with this new release.

I'll create the release shortly.

Thanks a lot @c-logemann and @avpaderno for your help on this. I will maintain this module wisely.

danrod → created an issue.

Alright, will do.

I'll merge it to the 3.0.x branch.

I was able to fix the PHPSTAN issue, but still we need to fix the test (Hope to do that later this week), for now I'll set this to "Needs Review".

Hope someone would review this, I'd appreciate it.

Thanks.

danrod → changed the visibility of the branch 3544104-fix-phpstan-issues to hidden.

Tested and worked as expected, would like a second opinion please. I'll set it to "Needs Review".

I'll merge this to the 3.0.x branch.

Don't forget to give the credits who helped resolve the issue :)

danrod → created an issue.

Sorry, it was an old pipeline run, we can close this as "Closed (outdated)"

Tests passed: https://git.drupalcode.org/project/jqcloud/-/merge_requests/11

I'll appreciate a review if anyone has some time, I'll move this to "Needs Review".

Thanks for the review @d.fisher !

danrod → created an issue.

danrod → created an issue.

@omd I'm working into opting my module to be convered by Drupal's security policy and it's a lenghty process and you know that.

Thanks for your understanding.

I'll merge this to the 3.0.x branch for now, if you have any questions please let me know, but I think these tests are good enough for now.

danrod → created an issue.

I was able to create some decent JS tests, here's some screenshots during the test executions: