🇨🇦Canada @danrod

I'll merge this to the default branch, tested on D10.3 and D11.2.2, if anyone has any issue, please let me know and I'll re-open the task.

I don't have permissions for that, you may need to contact Adrian Ababei for that.

Everything looks ok except for the tests. Which still need to be tested.

Moving it to "Needs Review" hope someone can review this.

If anyone doesn't mind, I'll merge this and move to "Fixed".

Tested and works fine on D10.3 and D11.2.2. I'll move to "Fixed" for now, let me know if you encounter other issues.

Looks ok to me, thanks @ankitv18

I fixed some PHPCS / PHPSTAN, I think this is ready for review.

Appreciate any help.

Tested on my D10.3 and D11.2.2 instance and works as expected. Needs review.

Hey @anktiv18, I don't have permissions to that, maybe @c-logemann can help you with that

I can help with with the table sort, with vanilla JS. Just need to find some time for it.

I'll move it to "Fixed" then. Any issues please let me know and I'll re-open the task.

I'll move it to "Fixed", if there's any issue, I can re-open the task.

Thanks ! I'll merge this.

This one is ready for review again, setting this to "Needs Review".

danrod → created an issue.

danrod → created an issue.

danrod → created an issue.

Looks ok to me I'll move to RTBC

Needs an extra review if possible.

Tested on a D11.2, works as expected.

Applied the patch and commited to 3.x.

This has been included/fixed in the 3.0.x-dev release: https://www.drupal.org/project/media_thumbnails_svg/releases/3.x-dev →

A tagged release will follow suit. I'm closing this for now.

Thanks Boris,

I created the new 3.x branch and dropped support for D9/10.

I'll close this.

Fixed all the PHPCS / PHPSTAN issues. Ready for review again.

It seems like not a lot of work needs to be done here, the *.module is there with some preprocess calls.
No need to do more work.

I applied the #[LegacyHook] to support the D10 version and restored back the .module file as suggested, tested on a D10.5 instance and works great, moving this to "Needs Review" again.

@joseph.olstad Thanks, I'll have a look.

Moving this to "Needs Work", need to add backwards compatibility support with D10.3

I need to add Add backwards compatibility support with D10. Moving this to "Needs Work"

You are correct @ankitv18 , the Hook attribute is not really supported in D10.3, I will implement the #[LegacyHook] attribute and move this to "Needs Work".

I was aware that the hook attribute was introduced in D10.3 as well, but I can do the #[LegacyHook] if needed.

@smustgrave you can close this, please, thanks !

danrod → created an issue.

danrod → created an issue.

I created a small patch for this just in case there is no patch yet.

Looks like indeed was fixed in another (duplicate) issue: https://www.drupal.org/project/entity_browser/issues/3440973 🐛 TypeError: key(): Argument #1 ($array) must be of type array, null given in key() (line 424 of modules\contrib\entity_browser\src\Plugin\Field\FieldWidget\EntityReferenceBrowserWidget.php) RTBC

danrod → created an issue.

danrod → created an issue.

danrod → created an issue.

danrod → created an issue.

I tested this on a D10.3 and D11.2 instance and worked fine (screens attached), but we will need to drop support for D9 if we want to merge this.

I'll leave it to "Needs Review" for now.

I'll merge this to the 3.0.x branch.

I'll merge this to the 1.0.x branch.

Tested this on a D11.2 instance and a D10.3
I would love a second opinion of this, moving the issue to "Needs Review".

It's is working fine for me. How to test it easily:

1. Create a basic article, make sure the text format is "Full HTML".

2. Add this JS snippet:

<script>
  let trimText = "                  TEXT               ";
  console.log("Text before applying the $.trim() function: ", trimText);
  trimText = $.trim(trimText);
  console.log("Text AFTER before applying the $.trim() function: ", trimText);
</script>

3. Save it and you should see something like that on the browser console:

Text before applying the $.trim() function:                    TEXT               
 Text AFTER before applying the $.trim() function:  TEXT

I'll set this to "Needs Review" just in case anyone wants to have look on it (and get extra points!)

danrod → created an issue.

danrod → created an issue.

danrod → created an issue.

danrod → created an issue.

danrod → created an issue.

danrod → created an issue.

This request doesn't seem to fix the issue.

danrod → made their first commit to this issue’s fork.

I added a few screenshots, reorderered the information and added some information of why this module is useful: https://www.drupal.org/project/machine_name →

Ready for review. @ankitv18

This looks good to me, I'll approve it.

For some reason, the "composer" tests are failing, I'll look into this later.

danrod → created an issue.

I created a MR for this, please review.