Ottawa
Account created on 4 March 2005, almost 20 years ago
#

Merge Requests

More

Recent comments

🇨🇦Canada danrod Ottawa

danrod changed the visibility of the branch 1.0.x to hidden.

🇨🇦Canada danrod Ottawa

I took the liberty to jump into this and I create a MR, hope you don't mind.

🇨🇦Canada danrod Ottawa

danrod made their first commit to this issue’s fork.

🇨🇦Canada danrod Ottawa

It seems to be working now, I'll move the task to "Needs Review" and then I'll merge the changes to the 2.0.x branch and move the issue to "Fixed": https://git.drupalcode.org/project/radiostoslider/-/pipelines/429807

🇨🇦Canada danrod Ottawa

I fixed, it was a formatting issue, I'll continue with the task.

🇨🇦Canada danrod Ottawa

This looks ok so far, I'll move it to "Fixed" and let me know if you still see issues with /admin URLs and calendar/event entities

🇨🇦Canada danrod Ottawa

The tests look ok: https://git.drupalcode.org/project/gutenberg_ai_tools/-/pipelines/429252

Still missing the Unit Tests, but I gotta finish these between today and Friday :)

I'll move ito "Fixed"

🇨🇦Canada danrod Ottawa

I had to the skip the CSTYLE tests as well, I tried using the .stylelintignore to add some compiled files that needed to be ignored, it didn't work so I won't do any Styling tests for now.

🇨🇦Canada danrod Ottawa

I decided to skip the SKIP_ESLINT job because it was giving me a lot of trouble with the ReactJS app. I might revisit that later, for now I'll ignore the warnings until I find some more time to fix that.

🇨🇦Canada danrod Ottawa

All tests have passed for this branch, I'll move it to "Needs Review" for a bit before moving it to "Fixed": https://git.drupalcode.org/project/fluidui/-/pipelines/428925

🇨🇦Canada danrod Ottawa

I fixed the issues reported by Gitlab CI for the branch 2.0.x, we will have to do the same for the branch 3.0.x, but given the huge differences between two branches, I'll have to open a new issue page for the 3.0.x.

https://git.drupalcode.org/project/fluidui/-/merge_requests/12

Thanks a lot to everyone involved !

🇨🇦Canada danrod Ottawa

I will have to close these MR's but no worries, I will still give the credits. I just need to clean up this issue a bit.

🇨🇦Canada danrod Ottawa

I'll be reviewing this today and I am having a hard time merging the latest 2.0.x with these branches.

🇨🇦Canada danrod Ottawa

I'll have to change the .gitlab-ci.yml to ignore the local infusion library for the tests. I will look into this today.

🇨🇦Canada danrod Ottawa

I can't make past the "composer" step for some reason: https://git.drupalcode.org/project/radiostoslider/-/merge_requests/3

If anyone knows how to fix this please let me know, I'll give you full credits !!!

🇨🇦Canada danrod Ottawa

Added the GitlabCI file and fixed some CSPELL and PHPCS errors: https://git.drupalcode.org/project/many_selects/-/pipelines/427576

I'll move to RTBC and then to "Fixed".

🇨🇦Canada danrod Ottawa

danrod created an issue.

🇨🇦Canada danrod Ottawa

I did some tests today with the WxT distribution (6.1x - D11) and worked ok to me, I'll move this to "Fixed" and please open a an issue if you see any around.

Thanks

🇨🇦Canada danrod Ottawa

I did some tests today with the WxT distribution (6.1x - D11) and worked ok to me, I'll move this to "Fixed" and please open a an issue if you see any around.

Thanks

🇨🇦Canada danrod Ottawa

I tested it this morning and font works swell in the 3.0.0-alpha1 version, I'll move it to "Fixed" now, if anyone doesn't mind.

🇨🇦Canada danrod Ottawa

Hey @ryanrobinson_wlu just for you to know, the new library doesn't render this iframe anymore:

The div that replaces it has an "aria-label" property, which should be fine I think.

🇨🇦Canada danrod Ottawa

I created an alpha release that works with D10/D11 which includes the latest infusion library, I believe this fixes this issue, some screenshots above:

https://www.drupal.org/project/fluidui/releases/3.0.0-alpha1

🇨🇦Canada danrod Ottawa

I created an alpha release that works with D10/D11 which includes the latest infusion library, I believe this fixes this issue, some screenshots above:

🇨🇦Canada danrod Ottawa

Here's the alpha version and works well in Drupal 10.2 / 10.3 / 10.4 and Drupal 11: https://www.drupal.org/project/fluidui/releases/3.0.0-alpha1

Please try and let me know how it looks on your end, you don't need to compile a new library, I've included in the module as well, but I updated the README.md with instructions on how to compile the library again.

I'll leave this as "Needs Review" for a while, then I'll mark it as "Fixed" if no major complains are raised.

🇨🇦Canada danrod Ottawa

Hello @ryanrobinson_wlu in the D11 Upgrade task 📌 Drupal 11 compatibility issues Active and the new Infusion Library has included this font that you mention:

You'll test this once I release an alpha package from the 3.0.x branch.

🐛 | SShop | Cart issue
🇨🇦Canada danrod Ottawa
🇨🇦Canada danrod Ottawa

Thanks a lot everyone for your work involved on this (you'll get the credits of course), I guess I'll add more functionality into this module since more people are using it.

I'll add documentation, a .gitlab-ci.yml file and a JSON to test this.

Don't hesitate to reach out to me for any feedback.

🇨🇦Canada danrod Ottawa

Well, it worked fine for me, at least in the config form, I still need a JSON file to try it more, if you a test one, please try.

I'll create a beta release

🇨🇦Canada danrod Ottawa

At least the config form is working great in 10.4 (I don't have the JSON file to test it):

I'll do some tests in 10.2/10.3 and D11

🇨🇦Canada danrod Ottawa

I can't believe some people are using this module, do you have an API Key for this?

🇨🇦Canada danrod Ottawa

This, along with other issues that this has, can be only fixed in a complete refactoring of this theme, which it won't happen anytime soon

🇨🇦Canada danrod Ottawa

We won't fix this, the current 8.x-1.x tag release has a lot of bugs and It's better to start a new B5 project in the 2.0.x branch: https://git.drupalcode.org/project/sshop/-/tree/2.0.x?ref_type=heads

Hope to release something soon, for now you will stick the 8.x-1.x current version

🇨🇦Canada danrod Ottawa

We won't fix this, the current 8.x-1.x tag release has a lot of bugs and It's better to start a new B5 project in the 2.0.x branch: https://git.drupalcode.org/project/sshop/-/tree/2.0.x?ref_type=heads

Hope to release something soon, for now you will stick the 8.x-1.x current version

🇨🇦Canada danrod Ottawa

I'm not sure who controls the demo site, but it is pretty outdated not related with the latest D10/11 site, I suggest waiting until the 2.0.x relase comes alive: https://www.drupal.org/project/sshop/issues/3506856#comment-15989778 🐛 Disabling the commerce_wishlist module and remove the sshop_homepage_feature Active

Production build 0.71.5 2024