🇨🇦Canada @danrod

Was this MR tested at all? I ran into a WSOD when testing this MR:

The website encountered an unexpected error. Try again later.

TypeError: Drupal\Core\Form\ConfigFormBase::__construct(): Argument #2 ($typedConfigManager) must be of type Drupal\Core\Config\TypedConfigManagerInterface, Drupal\Core\Entity\EntityTypeManager given, called in /var/www/html/web/modules/contrib/gifplayer/src/Form/SettingsForm.php on line 36 in Drupal\Core\Form\ConfigFormBase->__construct() (line 43 of core/lib/Drupal/Core/Form/ConfigFormBase.php).
Drupal\gifplayer\Form\SettingsForm->__construct() (Line: 45)
Drupal\gifplayer\Form\SettingsForm::create() (Line: 36)
Drupal\Core\DependencyInjection\ClassResolver->getInstanceFromDefinition() (Line: 48)
Drupal\Core\Controller\HtmlFormController->getFormObject() (Line: 58)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 593)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 183)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 709)
Drupal\Core\DrupalKernel->handle() (Line: 19)

I'll change this to "Needs Work" and try to fix these issues myself.

ok @akulsaxena, that makes sense, I'll test this MR and if it goes ok, I'll merge it to the 2.0.x branch and create another issue for the CSPELL, ESLINT, PHPSTAN, and STYLEINT errors

Thanks @akulsaxena but I still see a bunch of CSPELL, ESLINT, PHPSTAN and STYLEINT errors, do you have some time to fix them? I might have a look on these today maybe.

Hello @jan kellermann can you share with me how to use Mink to test this MR? I'm not familiar with Mink and I'ld like to help on this.

Hey @igoragatti I tried your steps in in the 2.0.x branch and I couldn't see the issue again, I see that you tested on the release 8.x-1.8, could you upgrade to the latest 2.0.x release? If not it would be nice if the patch goes in the next 8.x-1.x release (if it's still maintained)

danrod → created an issue.

Done, merged MR to the 3.0.x , closing this issue

Finally after struggling with the ESLint pipeline that Drupal has set up in their gitlab infrastructure, I was able to pass all checks after the fixes:

I'll move this to "Fixed" and merge it to the 3.0.x branch

This one is hard to crack

This was fixed in another issue: https://www.drupal.org/project/jqcloud/issues/3499505#comment-15948036 📌 Switch jQCloud to Gitlab CI for automated testing Active

I'll close this issue and give you credits to whoever worked on this, thanks !

All the tests were passed, moved this to RTBC as seen:

https://git.drupalcode.org/project/jqcloud/-/pipelines/399715

I'm using Linux here and the default screen reader that comes with it (Orca) is just a nightmare and I can't submit/navigate the form unless I use the tab and hit enter to submit the form, I believe JAWS has the option to navigate the webform without the tab, I'll ask one of my colleagues who uses Windows if he can do some tests with JAWS.

I tested the original bug regarding the mouse pointer and I got the same error:

I had some issues applying the patch # 3, but It seemed to fix the issue

$ patch -p1 < antibot-issue-3406484-2.patch 
patching file js/antibot.js
Hunk #2 succeeded at 19 (offset 2 lines).
Hunk #3 FAILED at 46.
1 out of 3 hunks FAILED -- saving rejects to file js/antibot.js.rej

I'll look into the accessbility issues now.

I added the logo.png in the 2.0.x branch, but needs further testing (I need to test this on anther D11 instance)

I can see that the description is being displayed, we still need to provide the logo (which I'll do it shortly):

Merged, thank you to everyone involved !

Going back to this issue again, @darvanen I'm ok skipping the ESLint checks now, and seeing that the launch date of Drupal CMS is tomorrow and we'd like to have a new release as soon as possible, this is a reasonable workaround. I'll merge it to the 2.0.x branch.

This is because you have the "Display form ID" option checked:

I'll mark this issue as "Won't fix"

This is more like an issue with the context module itself: https://www.drupal.org/project/context/issues/3277701 🐛 Undefined #form_id in form alters Needs review

Agree with Jan, I'll close this as "won't fix"

danrod → created an issue.

danrod → created an issue.

Thanks for reporting this, I'll look on this issue later this week.

danrod → created an issue.

I'll have a look on this later this week, assigning it to myself.

Thanks @sandipt , since this an external library, I can't apply this patch here, I had to fork the github project and add the changes to make the library work with D10/11.

I gave you the credit anyways and thanks for your input, I'll mark it as "Fixed"

Tested on D10 with no issues, I'll mark this as "Fixed", I'll make a new release shortly, thanks @divyansh.gupta for your help !

I fixed all the issues and all the tests passed OK this time, I'll test this in Drupal 10 and then I'll merge it to the 3.0.x branch: https://git.drupalcode.org/project/google_calendar_service/-/pipelines/3...

Thanks @divyansh.gupta for fixing the PHPCS warnings, I still see some CSPELL and PHPSTAN issues, would you be able to check these? if not I can look on these today.

Attached a temporary patch to fix this.

danrod → created an issue.

Sorry, wrong place to post this !

danrod → created an issue.

danrod → created an issue.

Thank you @tormi and @astonvictor , I tested the patch successfully and I don't see the warnings anymore, I'll move this to RTBC if you don't mind

Tested thoroughly on a D11 instance and I couldn't find any issues/warnings, moving this to "Fixed"

Tested on D10 with no issues, moving this issue to "Fixed", thanks a lot @dhruv.mittal for your help !

Fixed the CSPELL issues, tested in Drupal 11, I'll move this to "Fixed" shortly, I want to test this in Drupal 10.

Thanks @dhruv.mittal, for the CSPELL issues, we'll need to create a .cspell-project-words.txt and add there the words to ignore, i'll look on that later today.

Thanks @divyansh.gupta

I still see some issues when running the PHPUnit tests, could you check, please @divyansh.gupta ? https://git.drupalcode.org/issue/google_calendar_service-3495691/-/jobs/...

I'll add the styling for Sidebar Menu and the Events Page (DO-19 and DO-21) to avoid creating unnecessary issues/merge requests:

https://www.drupal.org/project/bluecheese/issues/3495435 📌 UI Element: Sidebar navigation menu Active

danrod → created an issue.

danrod → created an issue.

I created a new release which works well for Drupal 10/11: https://www.drupal.org/project/languages_dropdown/releases/3.0.2 →

Moved it to RTBC and I'll close it.

danrod → created an issue.

danrod → created an issue.

I created a new stable release that works with D10/D11 and fixes the IEF compatibility, feel free to test and let me know if you find any issues: https://www.drupal.org/project/google_calendar_service/releases/3.0.2 →

I created a new stable release that works with D10/D11 and fixes the IEF compatibility, feel free to test and let me know if you find any issues

This is related with the issue: https://www.drupal.org/project/google_calendar_service/issues/3460498 🐛 Update IEF ^1.0 || ^3.0 Active

I was able to make the module work with IEF 3.x, did you run into any issues?

I tested this in Drupal 10 and works as expected, the module inline_entity_module 3.x-dev was installed and worked fine with the module, I created a DEV release for this and I'll create a new release soon once I apply some changes to make it work with Drupal 11: https://www.drupal.org/project/google_calendar_service/releases/3.0.x-dev →