This is a critical issue and it will be my priority tomorrow morning.
I'll merge it 2.0.x branch for now, if anyone finds any issue with this solution, please let me know and I'll reopen the task.
I'll close this since this module is deprecated (please see the project's main page for more information) and we don't plan to remove the color options for now, since many sites using this module still use it.
I added the composer.libraries.yml
file and some edits in the README.md
files, I'll move it to "Needs Review" just in case anyone wants to review the changes.
I added some styling to make the font family dropdown menu scrollable, but I also set the font family dropdown menu to have a max height of 400px because I don't want the menu to expand into the whole editor, screenshots:
I'll merge both branches and mark this as "Fixed", if anyone finds any issues, please let me know and I'll open the task again.
I moved this issue to "Needs Review", just in case anyone wants to review them, but looks pretty clear to me.
I created the MR for the 2.0.x branch, I'll create the MR for the 8.x-1.x branch.
I'll merge the MRs to the 2.0.x and 8.x-1.x branches then, hope anyone doesn't mind.
Please note that this module is deprecated, and it's better to use the https://www.drupal.org/project/ckeditor5_plugin_pack → instead, but I'm doing some work on this because I'll be supporting a few old sites that rely on this module and need to do some refactor a bit on this.
Any questions or concerns, I can re-open the task.
danrod → created an issue.
It's all green in the 8.x-1-x MR now, I had to disable the PHPSTAN checks because of some issues that I couldn't figure it out how to fix (and it is almost the same code base as the 2.0.x).
It is up for "Needs Review" now.
The stages "build" and "validate" are green now, the "tests" stage needs some working but I'll address that in another issue, I think these tasks didn't work at all since they were implemented.
I'll create another MR for the 8.x-1.x branch.
danrod → created an issue. See original summary → .
Merged !
If anyone doesn't mind, I'll merge the MRs to their corresponding branches and close this as "Fixed", if questions, let me know and I'll re-open the issue.
Thanks @kiwad , I noticed it.
I'll find some time today to update some pages: https://www.drupal.org/documentation/modules/domain →
The pipeline ran with no problems in the 8.x-1.x branch: https://git.drupalcode.org/project/ckeditor_font/-/merge_requests/26
Also CSPELL / PHPSTAN / PHPCS issues to fix that I'll address in other issue.
For now I'll leave this to "Needs Review" just in case some has any suggestion on this.
The pipeline execution passed with no problems: https://git.drupalcode.org/project/ckeditor_font/-/pipelines/482109
There's still a lot of PHPSTAN / CSPELL / ESLINT / .. issues that I'll address in another issue.
I create a separate MR for the 8.x-1.x branch.
Some screens:
I'll update the README.txt to add these extra instructions, for now I'll close this as "Fixed".
Please note that this module is deprecated in favour of the ckeditor5_plugin_pack → module
I got this resolved by following all the instructions in the README.txt file:
Local installation (non-composer):
1. Download the CKEditor font plugin (v4.13.x to be compatible with Drupal
9) from http://ckeditor.com/addon/font.
2. Place the plugin in the root libraries folder (/libraries or
/libraries/ckeditor/plugins).
3. Install as you would normally install a contributed Drupal module. Visit
https://www.drupal.org/node/895232/ for further information.
Composer installation:
1. CKEditor Font Size and Family's composer.json will automatically install
the library into `base_path()/libraries/font`. To add the library,
type `composer require drupal/ckeditor_font` at your Drupal project root.
Create a config.js
file in the modules/contrib/ckeditor/vendor
and add this line:
config.extraPlugins = 'font';
And then add the font families (at /admin/config/content/formats/manage/full_html
) and font sizes as instructed in the examples:
Verdana, Geneva, sans-serif| Verdana Font
Lucida Console, Courier New, monospace|Lucida Font
Times New Roman, Times, serif|Times Font
10px|Normal Size
20px|Medium Size
30px|Whopper Size
123px|Size label
Hi @myDrupal2014_846824658246
I hope you are ok and sorry this answer comes a bit late, I am cleaning up the issue board. The way you are setting the font is correct:
Verdana, Geneva, sans-serif| Verdana Font
Lucida Console, Courier New, monospace|Lucida Font
Times New Roman, Times, serif|Times Font
The problem is that font doesn't come with CKEditor4 and you will need to do something extra, here's some information for you: https://stackoverflow.com/questions/1398342/adding-font-face-to-ckeditor
I'll mark this issue as "Fixed" since information was provided, but I can re-open it if needed, the module is deprecated anyways.
This MR worked as well:
daniel@drupal:/var/www/html$ composer require "infusion/infusion"
./composer.json has been updated
Running composer update infusion/infusion
Loading composer repositories with package information
Updating dependencies
Lock file operations: 1 install, 0 updates, 0 removals
- Locking infusion/infusion (4.8.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
- Installing infusion/infusion (4.8.0): Extracting archive
Generating autoload files
94 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
phpstan/extension-installer: Extensions installed
Found 8 security vulnerability advisories affecting 1 package.
Run "composer audit" for a full list of advisories.
Using version ^4.8 for infusion/infusion
daniel@drupal:/var/www/html$ cd web/libraries/
daniel@drupal:/var/www/html/web/libraries$ ls
bootstrap-languages infusion jonthornton-jquery-timepicker jquery-timepicker-addon jquery-ui-timepicker
daniel@drupal:/var/www/html/web/libraries$ cd ..
daniel@drupal:/var/www/html/web$ cd ..
daniel@drupal:/var/www/html$ cat composer.json | grep core
"drupal/core-composer-scaffold": "^10.2",
"drupal/core-dev": "^10.4",
"drupal/core-project-message": "^10.2",
"drupal/core-recommended": "^10.2",
"drupal/core-composer-scaffold": true,
"drupal/core-project-message": true,
"web/core": [
"type:drupal-core"
"drupal-core-project-message": {
" composer remove drupal/core-project-message"
daniel@drupal:/var/www/html$
I'll merge this to the 2.0.x branch and update the <code>README.md
files on both branches to indicate the user that they can download the library from this alternative way.
For now I'll mark this as "Fixed" unless someone has any issues, I can re-open it of course.
I'll merge it to the 3.0.x branch and open a new MR for the 2.0.x branch.
I added the library in the main composer.json
file and I was able to download it with no issues:
daniel@drupal:/var/www/html$ composer require "infusion/infusion"
./composer.json has been updated
Running composer update infusion/infusion
Loading composer repositories with package information
Updating dependencies
Lock file operations: 1 install, 0 updates, 0 removals
- Locking infusion/infusion (4.8.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
- Downloading infusion/infusion (4.8.0)
- Installing infusion/infusion (4.8.0): Extracting archive
Generating autoload files
96 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
phpstan/extension-installer: Extensions installed
> composer/composer: installed
> composer/pcre: installed
> mglaman/phpstan-drupal: installed
> phpstan/phpstan-deprecation-rules: installed
> phpstan/phpstan-phpunit: installed
No security vulnerability advisories found.
Using version ^4.8 for infusion/infusion
Thanks a lot @avpaderno
Merged to 8.x-1.x now, I'll mark this as "Fixed", I won't include tests here because the Drupal Core version is not compatible with the Gitlab CI/CD configuration.
All jobs are green now, so I'll merge it to the 8.x-1.x branch now: https://git.drupalcode.org/project/many_selects/-/merge_requests/10
I added the .gitlab-ci.yml file and ran with no issues, there's some addtional PHPCS and CSPELL issues that I'll fix in another branch: https://git.drupalcode.org/project/many_selects/-/merge_requests/9
danrod → changed the visibility of the branch 3520879-add-.gitlab-ci.yml-file to hidden.
I'm afraid I will need set this issue aside, I need to do a lot of changes in the module (changing links in the entity files, plugins, etc) and I'm afraid I'll break things up if I continue to work on this one. If anyone wants to take this, be my guest-
I was able to reproduce this, I installed a Drupal instance in a subdirectory (http://subsite.ddev.site/maresmuseum/) and I can see the issue you saw.
1. In the http://subsite.ddev.site/maresmuseum/en/calendar/1/events page, the link of the button "Add Event" must go to http://subsite.ddev.site/maresmuseum/admin/calendar/1/event/add instead the link is http://subsite.ddev.site/admin/calendar/1/event/add
2. Same situation in the http://subsite.ddev.site/maresmuseum/en/calendar/events page , the "List Calendars" button should go to http://subsite.ddev.site/maresmuseum/admin/calendar , instead the button link is http://subsite.ddev.site/admin/calendar
I'll create a MR to address this.
I'll move it to "Fixed" for now, as always, any issues and please let me know and I'll re-open the task.
I'll leave this task to "Needs Review" just in case anyone wants to do extra testing (for credits!)
Added the file composer.libraries.json
in the 8.x-1.x branch and tested it ok, merging.
I fixed the composer.libraries.json file and It downloads the correct library version:
daniel@drupal:/var/www/html$ composer require "rubentd/radios-to-slider"
./composer.json has been updated
Running composer update rubentd/radios-to-slider
Loading composer repositories with package information
Updating dependencies
Lock file operations: 1 install, 0 updates, 0 removals
- Locking rubentd/radios-to-slider (0.2.2)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
- Downloading rubentd/radios-to-slider (0.2.2)
- Installing rubentd/radios-to-slider (0.2.2): Extracting archive
Generating autoload files
98 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
phpstan/extension-installer: Extensions installed
No security vulnerability advisories found.
Using version ^0.2.2 for rubentd/radios-to-slider
I'll merge this branch and I'll use the same file in the 8.x-1.x branch
danrod → created an issue.
Good Morning, I'll be looking into this today.
I also made the same fix in the 8.x-1.x branch.
I think I'm ready to create two tagged releases after fixing a lot of issues with the module, will do that tomorrow. Closing this to "Fixed"
I also changed the installer from tar.gz to zip and it seems to work now:
ddev composer require "rubentd/gifplayer"
./composer.json has been updated
Running composer update rubentd/gifplayer
Loading composer repositories with package information
Updating dependencies
Lock file operations: 1 install, 0 updates, 0 removals
- Locking rubentd/gifplayer (0.3.7)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
- Installing rubentd/gifplayer (0.3.7): Extracting archive
Generating autoload files
98 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
phpstan/extension-installer: Extensions installed
No security vulnerability advisories found.
Using version ^0.3.7 for rubentd/gifplayer
Seems that all the tests have passed, and tested locally and the module works as usual. Moved to "Fixed" for now.
Merged.
I committed the file and I can see that the pipelines are being executed with no problems: https://git.drupalcode.org/project/gifplayer/-/merge_requests/12
I'll create another issue to fix the ESLINT / PHPCS / PHSTAN issues.
I'll merge this to the 8.x-1.x branch and mark this as "Fixed"