🇨🇦Canada @danrod

Done @Duwid

Do you have more more details about the spam that you are getting? I'll look into this tomorrow.

Could we have a patch for this instead, for now?

I'll move this to "Fixed" for now, I believe these functional tests will do just fine for now, if anyone has more suggestions of other tests that can/need to be implemented, please let me know, I plan to write another batch of issues in the next release.

Thanks !

Thanks a lot for this, did another round of testing and worked fine, I'll move this to "Fixed".

This looks good, I tested this and I added the user_register_form id in the Excluded form IDs field and the form was indeed excluded from the antibot protection:

danrod → made their first commit to this issue’s fork.

Did another round of testing, I'll close this, I will create a new release shortly.

Thanks a lot to everyone involved !

This is a duplicate of https://www.drupal.org/project/antibot/issues/3419789 🐛 TypeError: implode() RTBC

I'll mark this as Closed (duplicated)

Thanks a lot @pyxio, I tested it and worked ok, I'll move it to RTBC.

Thanks @BenStallings , could you create a MR against the 2.0.x branch please? I need to set that branch as the default one and not the the 8.x-1.x.

Hi @Pawelgorski87 how's this going? are you going to create a merge request for it?

I created a functional (basic) test for testing the google calendar service configuration, this could be a good start, I'd like to write tests for the calendar entity creation/edit/deletion in the near future, but I believe this is a good start and can be reviewed now:

Attached a patch to make the drush wxt-cex command to work under WxT 5.2-dev, needs further testing.

danrod → created an issue.

danrod → created an issue.

I was able to apply the patch #20 with no issues, I'll test the functionality

Patch #2 applied ok on my side, still need to do some extra testing to see if the updated module actually works for D10, if not, we might need to consider rewriting this in a new custom module.

Thanks @rclemings , I'll move this back to "Fixed" for now, let me know you findings on that, I can always look back on this issue.

Hi @rclemings I did some test on a branch new and I didn't see this issue again, maybe the JS files of your site are being cached externally somewhere (Varnish/Cloudflare..)? Is anyone else having the same issue?

Thanks for reporting this @rclemings , I didn't see this problem myself, reviewing now.

Committed to the 7.x-1.x branch and created a new release: https://www.drupal.org/project/antibot/releases/7.x-1.3 →

Thanks a lot to everyone involved.

Thank you !
I'll move this to RBTC and commit this patch to the 7.x-1.x branch.

Merged to the 2.0.x branch, thanks !

Makes sense, I'll push this to the 2.0.x branch.

Thanks for the patch !

I tested this and works as expected, I was able to do a webform submission (the webform was set to use an AJAX request for all submissions) and worked fine, no errors seen in the browser console.

There are some issues when running the tests on this module (mentioned in the comment #6), but I'll address these issues in a separate issue: https://www.drupal.org/project/antibot/issues/3392673 🐛 Fatal error when running tests Needs work

I'll commit this to the 2.0.x branch.

Moving this to "Fixed"

I am getting this error when trying to run the tests, does anyone have any idea what is triggering this error?

$  ../vendor/bin/phpunit -c core modules/contrib/antibot
PHPUnit 9.6.15 by Sebastian Bergmann and contributors.

Testing /var/www/html/web/modules/contrib/antibot
..E                                                                 3 / 3 (100%)

Time: 00:10.177, Memory: 4.00 MB

There was 1 error:

1) Drupal\Tests\antibot\FunctionalJavascript\AntibotJavaScriptTest::testJavaScript
TypeError: trim(): Argument #1 ($string) must be of type string, bool given

/var/www/html/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverCurlService.php:120
/var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:125
/var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/WebDriver.php:66
/var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:335
/var/www/html/vendor/behat/mink/src/Session.php:77
/var/www/html/vendor/behat/mink/src/Session.php:172
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:281
/var/www/html/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:88
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:251
/var/www/html/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:54
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

ERRORS!
Tests: 3, Assertions: 15, Errors: 1.

HTML output was generated
https://web/sites/simpletest/browser_output/Drupal_Tests_antibot_Functional_AntibotCacheTagsTest-9-45696184.html
https://web/sites/simpletest/browser_output/Drupal_Tests_antibot_Functional_AntibotCacheTagsTest-10-45696184.html
https://web/sites/simpletest/browser_output/Drupal_Tests_antibot_Functional_AntibotCacheTagsTest-11-45696184.html
https://web/sites/simpletest/browser_output/Drupal_Tests_antibot_Functional_AntibotCacheTagsTest-12-45696184.html
https://web/sites/simpletest/browser_output/Drupal_Tests_antibot_Functional_AntibotNoJavascriptTest-5-20380071.html
https://web/sites/simpletest/browser_output/Drupal_Tests_antibot_Functional_AntibotNoJavascriptTest-6-20380071.html

I'll try to investigate this today, meanwhile I'll move this to "Needs Work"

Thanks @Jay Jangid, committed and attributed !

Created a new release with this patch: https://www.drupal.org/project/antibot/releases/2.0.3 →

Thanks a lot to everyone involved, and let me know if there are still issues with this.

Moving this to "Fixed" for now.

Thanks everyone for the feedback, I just committed the patch to the 2.0.x branch, I'll release a tag version shortly.

I'll work towards creating a similar patch to the 7.x-1.x branch.

I think It can be reviewed again now, applied some flexbox to move the footer to the end of the page: https://dev-d10-sshop.pantheonsite.io/about-us

I applied the patch #14 with no issues, tested this on a DEV site exposed to the internet and haven't got any spam for now (again, it is a dev site so it isn't getting a lot of requests).

Please let me know how this is working on your end (not getting spam after applying the patch) and I'll commit this to the 2.0.x branch.

I'll try to create a patch for the 7.x-1.x version.

Fixed it, I added an extra media query for removing the space if screen width is less than 992px, please review: https://dev-d10-sshop.pantheonsite.io/about-us

Thanks a lot !.
Committed and attributed.

Created a MR to review this, I added a min-height property in the node div class, please review: https://dev-d10-sshop.pantheonsite.io/about-us

Created a MR for this, please review.

Thanks a lot @gaurav.kapoor !

Thanks !, moved to "Fixed":

This seems to work well for the 3.0.x-dev release (attached screen), I'll cherry-pick the same changes to the 8.x-2.x branch, I'll move this to "Fixed" for now:

Hello !
I'd like to be a co-maintainer on this, I maintain over 50 projects and I fix/review issues on a day-to-day basis, here's my Drupal.org profile: https://www.drupal.org/u/danrod →

I'm seeing the same issue here, it looks like the *.map files are being invoked from these files:

./html/libraries/wet-boew/js/wet-boew.js line 1456:

//# sourceMappingURL=purify.js.map

And

./html/profiles/wxt/modules/custom/wxt_ext/wxt_ext_editor/css/cke5-theme-gcweb.css line 19436:

/*# sourceMappingURL=cke5-theme.css.map */

Can we try to re-build the assets and include the map files? I tried to do this myself but I couldn't find the cke5-theme.sass file for that.

I merged all the fixes to the 3.0.x branch for testing, please look for instructions in the README.md file on how to install the JS libraries with composer, I also removed the dependency drupal:libraries in the *.info.yml file since it was causing some issues documented here: https://www.drupal.org/project/libraries/issues/3367706 💬 Drupal\Component\DependencyInjection\ReverseContainer::generateServiceIdHash(): after installing libraries module Postponed: needs info

https://www.drupal.org/project/timepicker/releases/3.0.x-dev →

I am having the same issue if I list the libraries module as a dependency in my custom module *.info.yml file.

danrod → changed the visibility of the branch 3346567-js-libraries to active.

danrod → changed the visibility of the branch 3346567-js-libraries to hidden.

danrod → changed the visibility of the branch 3346567-js-libraries to active.

danrod → changed the visibility of the branch 3346567-js-libraries to hidden.

This seems to work now:

I am closing this for now.

I think I've found a way to implement this, I'll move this to "Active"

Moving this to "Fixed" for now, thanks for pointing this out, credited.

danrod → created an issue.

I can see that the pipelines worked ok, can be moved to "Needs Review" for now:

danrod → created an issue.

Updated both 8.x-2.x and 3.0.x branches with the new download link, and also updated the project's page, please review, otherwise I'll move this to "Fixed" since it is small documentation change.

This is correct, and the Download URL is https://github.com/fgelinas/timepicker/archive/refs/heads/master.zip , I'll update the doc files