- Issue was unassigned.
- last update
almost 2 years ago 29,374 pass - 🇮🇳India ravi kant Jaipur
Patch #27 is working as accepted. Attaching screenshot.
- Status changed to Needs review
almost 2 years ago 1:29am 12 May 2023 - Status changed to Needs work
almost 2 years ago 8:22am 12 May 2023 - 🇺🇸United States dcam
The patch in #27 was converted to an MR. I also added a test.
- 🇮🇳India Sivaji_Ganesh_Jojodae Chennai
Interesting issue. The bug indeed is still around. I can reproduce the issue with the attached test module.
Attached are the screenshots of before and after the MR.
The patch looks straightforward and pipeline looks good as well.
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Test looks solid, I think that's good. I wonder if we need a change record for this, but I don't think we do. RTBC++
- 🇺🇸United States dcam
I updated the docblock, but I put the reason why I wrote it the way that I did in an MR comment.
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
While I agree that adding more functional tests is not great for the total test time duration, having them well documented is important.
We can always change the documentation when we want to add more testing to this.To me, this change seems like it answers the question by @nod_.
- 🇺🇸United States dcam
I copied and pasted the
$next_row
variable name from elsewhere in the test class. I forgot to change it and that name isn't relevant to the new test. It bothered me, so I updated it. This is a minor change that doesn't really affect anything, so I'm leaving the issue at RTBC. Automatically closed - issue fixed for 2 weeks with no activity.