- Issue created by @alberto56
### Issue: Fix List Definition Issue
This patch resolves the issue where the list definition was incorrect.### Steps to Reproduce the Issue:
1. Navigate to the affected page in the admin panel.
2. Observe that the incorrect list structure causes an error.### Steps Taken to Fix the Issue:
- Adjusted the array structure to match Drupal's expected format.
- Ensured compatibility with other list-based components.### How to Test the Patch:
1. Apply this patch using `git apply myfix-3436243-1.patch`.
2. Clear the cache using `drush cache:rebuild`.
3. Verify that the issue is resolved by checking the affected page.### Next Steps:
Please review this patch and provide feedback. ๐- First commit to issue fork.
- ๐จ๐ดColombia juandhr Manizales
juandhr โ changed the visibility of the branch 11.x to hidden.
- ๐จ๐ดColombia juandhr Manizales
juandhr โ changed the visibility of the branch 11.x to active.
- ๐จ๐ดColombia juandhr Manizales
juandhr โ changed the visibility of the branch 11.x to hidden.
- Merge request !11416Issue #3511434 by juandhr: Remove reference in DocBlocks to non-existent... โ (Closed) created by Unnamed author
- ๐จ๐ดColombia juandhr Manizales
Hi @alberto56,
I've updated the docblock in Drupal\Core\TypedData\ListInterface and Drupal\Core\TypedData\DataDefinitionInterface interfaces with the existing Drupal\Core\TypedData\ListDataDefinitionInterface interface, please check.
- ๐ณ๐ฟNew Zealand quietone
Thanks for working on this!
The "proposed resolution" section should be complete and explain the actual change to help the reviewer and committer. Also, this should have some research to support that the change is correct. That is, what is the issue that replaces \Drupal\Core\TypedData\ListDefinitionInterface with something else. Using git blame should make it simple to identify when the changes was made.
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies โ .
- ๐ณ๐ฟNew Zealand quietone
This needs confirmation that the class name change is correct, as stated in #10.
What should happen is to find the commit where the old name was changed and read that commit. This command should help find the commit,
git log -S"\Drupal\Core\TypedData\ListDefinitionInterface"
.I have restored the 'remaining tasks' to add this point.
- ๐ฎ๐ณIndia Sivaji_Ganesh_Jojodae Chennai
I don't find reference to original interface name change. However I can see usage change in issue #2002134 โ commit id f6161fad
- ๐บ๐ฆUkraine quadrexdev Lutsk
Yep, it was changed within #2002134
We may see the change here -> https://git.drupalcode.org/project/drupal/-/commit/f6161fadb069ac3cb260c...
- Status changed to RTBC
4 days ago 7:13pm 5 May 2025 - ๐จ๐ฆCanada Charlie ChX Negyesi ๐Canada
It's worth noting how this came to be because, well, it's not like this code is AI written to hallucinate interfaces and yet a web search quickly shows this interface only seems to exist in these comments. How odd. Is there perhaps more to this? No:
ListDefinitionInterface
was added in 2013 in #2047229: Make use of classes for entity field and data definitions โ and got renamed toListDataDefinitionInterface
in 2014 in #2002134: Move TypedData metadata introspection from data objects to definition objects โ still within the 8.x development cycle. -
longwave โ
committed c5aac176 on 10.4.x
Issue #3511434 by juandhr, dimpalmangrulkar20@gmail.com,...
-
longwave โ
committed c5aac176 on 10.4.x
-
longwave โ
committed 297b9806 on 10.5.x
Issue #3511434 by juandhr, dimpalmangrulkar20@gmail.com,...
-
longwave โ
committed 297b9806 on 10.5.x
-
longwave โ
committed 8c7ffa56 on 11.1.x
Issue #3511434 by juandhr, dimpalmangrulkar20@gmail.com,...
-
longwave โ
committed 8c7ffa56 on 11.1.x
-
longwave โ
committed 1935c084 on 11.x
Issue #3511434 by juandhr, dimpalmangrulkar20@gmail.com,...
-
longwave โ
committed 1935c084 on 11.x
- ๐ฌ๐งUnited Kingdom longwave UK
Backported down to 10.4.x as a docs-only fix.
Committed and pushed 1935c084986 to 11.x and 8c7ffa560b6 to 11.1.x and 297b980640b to 10.5.x and c5aac1766a7 to 10.4.x. Thanks!