🇺🇦Ukraine @quadrexdev

In case someone needs a re-rolled patch for Drupal Core 11.2

In case someone needs a re-rolled patch per 3.0.0-alpha1

Created a merge request with all the required fixes per Drupal 11, please review

quadrexdev → made their first commit to this issue’s fork.

This is a duplicate of https://www.drupal.org/project/file_management/issues/3436827 🐛 error on file validation Needs review

quadrexdev → created an issue.

Please review

quadrexdev → created an issue.

Prepared the MR with a fix; I think it can now be reviewed, as the errors/warnings in the pipeline are not related to the changes made.

quadrexdev → created an issue. See original summary → .

@raginit, @mt-i-1

It looks like you're using an outdated version of the module that may have this issue. Tested on 4.0.1 and everything works as expected, imported images are linked to media entities.

@c-logemann I re-checked this issue, reproduced this problem again, and the changes from MR are fixing the problem. Also, this one - https://www.drupal.org/project/linkchecker/issues/3247070 🐛 TypeError in LinkStatusHandle.php Needs work is about the same problem, so we may close it as a duplicate, no changes required.

P.S. I see that the cspell job is failing now due to the updated cspell.json file from the gitlab templates. Since it will be necessary to update config props/schema -> it is an API change that should be handled in the next major release. Moved it here - https://www.drupal.org/project/linkchecker/issues/3531794 📌 Fix cspell issues Active for 3.0.x.

I can't merge it for some reason, dealing with this

quadrexdev → created an issue.

I'll take a look, thanks @c-logemann for putting your effort to improve this

quadrexdev → created an issue.

Put everything under MR

quadrexdev → made their first commit to this issue’s fork.

quadrexdev → made their first commit to this issue’s fork.

quadrexdev → made their first commit to this issue’s fork.

Thanks for the feedback, @smustgrave

I added a simple test to verify that the new permission is added by the post update hook, just in case

Yep, it was changed within #2002134

We may see the change here -> https://git.drupalcode.org/project/drupal/-/commit/f6161fadb069ac3cb260c...

Updated the issue branch with changes from 11.x, added post_update hook to grant the new permission

The errors in the pipeline look to be unrelated to this issue, so I would assume MR could be reviewed now

quadrexdev → made their first commit to this issue’s fork.

Updated @return docs; probably just got random failures in the pipeline

quadrexdev → made their first commit to this issue’s fork.

Applied patch from #7 + fixed phpcs issues + added DI when using html_title.filter service

Pushed everything under the merge request for easier review by mainainers.

It still requires test coverage, though

quadrexdev → made their first commit to this issue’s fork.

Please review

quadrexdev → created an issue.

I have added a fix in the merge request -> https://git.drupalcode.org/project/ckeditor5_premium_features/-/merge_re...

Please review

quadrexdev → created an issue.

quadrexdev → made their first commit to this issue’s fork.

Thanks everyone for putting some effort here. I have created a merge request with changes from the attached patches.

We have some failing jobs and appropriate issues to resolve:

1. Drupal 11 compatibility (PHPUnit) - https://www.drupal.org/project/domain_path/issues/3429923 📌 Automated Drupal 11 compatibility fixes for domain_path Needs review
2. Validation jobs (PHPUnit, phpcs, eslint) - https://www.drupal.org/project/domain_path/issues/3409106 🐛 Resolve phpcs failing test Active

Those two should be resolved first

Let's fix all the failing validation stuff over there :)

quadrexdev → made their first commit to this issue’s fork.

Actually, we noticed that it was related to a contrib module - https://www.drupal.org/project/multiple_fields_remove_button →

So I guess nothing to fix in the Tagify module. Probably could be closed (works as designed)

I can confirm that this issue is reproducible. My setup: Drupal core 10.3.1, tagify - 1.2.20.

I'll try to investigate and resolve it

+1 to RTBC, I just tested it and it worked pretty well!

quadrexdev → created an issue.

It could be reviewed now.

Please note that this task uses changes from 📌 Add queue processing for nodes/terms/routes similarly to views Needs review so the parent issue should be merged first.

I have finished this issue, please review :)

quadrexdev → made their first commit to this issue’s fork.

quadrexdev → made their first commit to this issue’s fork.

Re-checked and committed on 2.0.x, thanks everyone for your contribution ❤️

Double-checked, seems to be fine.

Committed on 2.0.x.

Committed on 2.0.x, thanks everyone for your contribution!

Merged in 2.0.x

Thanks for reporting, this one was already resolved within this issue - https://www.drupal.org/project/linkchecker/issues/3465025 📌 Fix cspell, upgrade status and phpstan issues Fixed

Alright, everything seems to be resolved.

Thanks @eiriksm for reviewing the merge request!

Alright, the tests are fixed. Remaining stuff:

a) cspell issues
b) eslint issues
c) phpstan issues
d) upgrade status issues
e) revert allow_failure for the cspell, eslint, phpstan, upgrade status so it should be equal to false

1) We'll allow failing for such jobs as phpstan, cspell, and upgrade status so it won't prevent us from further dev release updates.

@todo - revert it once this issue is fixed.

2) Still, some tests failed within the PHPUnit job so it should be fixed too.

quadrexdev → created an issue.

Okay, so I added two base fields: parent_entity_id and parent_entity_type_id instead of using DER field or a link field.

Adding two base fields for storing entity_type_id and entity_id looks like a simpler and more reliable solution for me.

I'll spend some more time testing this one. If someone else can test it and/or provide some feedback - feel free :)

I have started working on this and I hope to finish it within the next few days

Thanks for your quick reply!

Contacted you in Slack for further communication :)

Thanks @vladimiraus → !

I also contacted @c-logemann → to speed up the process.

Created a MR with a fix, which works for me with D10.3 && advagg 6.0.0-alpha1

quadrexdev → created an issue.

Yep, It would be nice to have this feature

Looks good to me

Added some suggestions

Just updating the status of the issue: Contacted @ eiriksm → via contact form today (26.06.2024). Waiting for some reply

Done and ready to be reviewed :)

quadrexdev → created an issue.

Prepared a merge request with a config form. Please review.

It could be reviewed now :)

We used the patch from #9 in our project and it worked fine except for supporting the includes tree.

Our case:

Node with layout builder, inside layout builder layout added some blocks with paragraphs (just a basic block type with a paragraph field) -> paragraphs were not included even after configuring default includes.

What helped:

Adding "include" parameter before

    $this->rootParser->parse($response);

Attaching patch file

a) Removed core key from info.yml file since it is deprecated starting from 8.7.7 (and D8 already reach EOL)
b) Added minimum core_version_requirement to 9.2 (so we can use new once approach)
c) Updated js behavior to use drupal/once library instead of jquery/once

quadrexdev → created an issue.

quadrexdev → created an issue.

quadrexdev → created an issue.

quadrexdev → created an issue.

Implemented and ready for review

After a short talk with a maintainer - we are adding 📌 Configuration form with a list of content types and taxonomy vocabularies Active as a related issue because we want to use the result of this task here.

Fixed everything and prepared MR. All green now, please review.

quadrexdev → created an issue.

It could be reviewed now.

quadrexdev → created an issue.

It could be reviewed now

quadrexdev → created an issue.

Maybe there could be a more elegant solution to this problem, but this one at least resolves the issue for my project.

Please review.

quadrexdev → made their first commit to this issue’s fork.

"isset" check should be enough even though

$variables['breadcrumb']

is supposed to be an empty array by default. Please see

template_preprocess_breadcrumb()

quadrexdev → made their first commit to this issue’s fork.

Whoops, forgot that it's already fixed within this issue - https://www.drupal.org/project/html_title/issues/3416142 📌 Tests pass but with warnings Needs review

quadrexdev → created an issue.

Moved the changes from #2 in a merge request, and all tests passed.

quadrexdev → made their first commit to this issue’s fork.

So I managed to reproduce the issue and created a merge request with a fix + simple test that fails without adding cache tags for rendered titles.

Please review.

All green now, please review

Applied patch from #4 + fixed tests + fixed some changes from the patch -> moved all these in the MR.

Please review.

quadrexdev → created an issue.

quadrexdev → made their first commit to this issue’s fork.

quadrexdev → created an issue.