- Issue created by @joelpittet
- π¨π¦Canada joelpittet Vancouver
MR has my proposed solution which is just check if it's numeric.
- Status changed to Needs review
8 months ago 10:53pm 18 April 2024 - last update
8 months ago 86 pass - πΊπ¦Ukraine quadrexdev Lutsk
I'm wondering why \Symfony\Component\HttpFoundation\Response::$statusTexts is not being used instead of \Drupal\linkchecker\LinkCheckerResponseCodes::$responseCodes
The Symfony response class has a 418 status code as an allowed response code so using it should resolve the problem of this issue.
- π¨π¦Canada joelpittet Vancouver
@quadrexdev good to know there is duplicate, maybe a separate issue to replace that? I just created a separate MR for the missing 308 issue that might be a better place for that fix β¨ Status code 308 for Permanent Redirect Needs review
I am hoping with this change that we don't even validate it so we can allow non-standard codes to be ignored like LinkedIn's 999 for example.
- π¨π¦Canada joelpittet Vancouver
Retitled to better indicate the proposed solution's intent
- πΊπ¦Ukraine quadrexdev Lutsk
@joelpittet Yep, sounds reasonable to work on replacement in #2958196