- Issue created by @boulaffasae
I also added view permission, it should be a custom permission instead of true by default :)
- Status changed to Needs work
about 1 year ago 6:28am 2 December 2023 - 🇳🇴Norway eiriksm Norway
Awesome 👍 Thanks for the patch!
Would be nice to have:
- The changes in a merge request
- some tests for this - First commit to issue fork.
- last update
8 months ago 86 pass, 1 fail - Status changed to Needs review
8 months ago 4:10pm 9 April 2024 - last update
8 months ago 85 pass, 1 fail - last update
8 months ago 86 pass - 🇺🇦Ukraine quadrexdev Lutsk
Added a merge request with the changes from #3 + added a simple Kernel test to verify it's working.
Please review
- Status changed to Needs work
8 months ago 4:11pm 9 April 2024 - 🇺🇦Ukraine quadrexdev Lutsk
Oops, changed status to needs review before tests passed so reverting it back
- last update
8 months ago 87 pass - Status changed to Needs review
8 months ago 8:16am 10 April 2024 - 🇺🇦Ukraine quadrexdev Lutsk
Ok, now it's passing.
So after applying a patch from #3 all the users had access to view the linkchecker entity (and that was the issue why LinkCheckerLinkAccessTest was failing). I reverted this part cuz the viewing operation is not supposed to be allowed for all the users, right?
Please review
-
quadrexdev →
committed 0c9a37f1 on 2.0.x
#3405194 Support JSON:API
-
quadrexdev →
committed 0c9a37f1 on 2.0.x
- Status changed to Fixed
4 months ago 7:53am 5 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.