@boulaffasae

New patch for 10.2.0 (correct lines number)

Hi !

I have an Image field

When I click on "Add media", everything work fine. (AJAX method:POST, +body)
Yet, when I click on 2 page, some CSS files get duplicated (AJAX method:GET, /views/ajax?ajax_form=1&_wrapper_format=drupal_ajax&media_library_opener_id=media_library.opener.field_widget&media_library_allowed_types%5Bimage%5D=image&media_library_selected_type=image&media_library_remaining=1&media_library_opener_parameters%5Bfield_widget_id%5D=field_header_image&media_library_opener_parameters%5Bentity_type_id%5D=node&media_library_opener_parameters%5Bbundle%5D=landing_page&media_library_opener_parameters%5Bfield_name%5D=field_header_image&media_library_opener_parameters%5Bentity_id%5D=61&media_library_opener_parameters%5Brevision_id%5D=602&hash=UKwOcmFbHRZjHy8K2RGIpvoJ470tuc09Sqv-J-z3q4k&_wrapper_format=drupal_ajax&view_name=media_library&view_display_id=widget&view_args=image&view_path=%2Fnode%2F61%2Fedit&view_base_path=admin%2Fcontent%2Fmedia-widget&view_dom_id=33bbb2ceb9faf3a9cfafa5af89dff0d0bd09bf0616791c92f9ac57209695b194&pager_element=0&ajax_form=1&_wrapper_format=drupal_ajax&media_library_opener_id=media_library.opener.field_widget&media_library_allowed_types%5Bimage%5D=image&media_library_selected_type=image&media_library_remaining=1&media_library_opener_parameters%5Bfield_widget_id%5D=field_header_image&media_library_opener_parameters%5Bentity_type_id%5D=node&media_library_opener_parameters%5Bbundle%5D=landing_page&media_library_opener_parameters%5Bfield_name%5D=field_header_image&media_library_opener_parameters%5Bentity_id%5D=61&media_library_opener_parameters%5Brevision_id%5D=602&hash=UKwOcmFbHRZjHy8K2RGIpvoJ470tuc09Sqv-J-z3q4k&page=1&_drupal_ajax=1&ajax_page_state%5Btheme%5D=claro&ajax_page_state%5Btheme_token%5D=idizCV_HO1lV4Z6IJOQkPtrXzf9q0EQhfp4qAw0QE6g&ajax_page_state%5Blibraries%5D=eJx9k212pSAMhjeEsoZZiSdCqsxFwgnB1ll9oxXveDvTPxieN5gPAvglpEGI4ghsz28vjGjgv1I_04ockmCSu9vxLZdzcJTMGKYhh4y2GWass3UUibsc3APZuAhM1nPNEPsEaycwlpNOkUaIXZEthjSdcEEfYIhhZOCtlxkXPJVEHrs34sW4pQwaf09yKFtyVo0g2ynuwodUiC3sk3Qa6FF-djkrVCfGJoOTsOJx-s6rkKMlRxS8CdqDCLncYREQLDek3YjoGabvlLFkSkXjfmlJi4MY_qDxuKJmvq9Xtm8Box_m4D2m9pu_mTpEfAoRza3RtoYX8B78hKIw1aGGdvLcmv0urltV22TQIhjyXBp-kqN9WsrPTmfADDI_VZkPsPe5ZcSaJqOT5tT2_TGupszE4uolt70p5ALEoVWpc2C_o3PghB7axmM1L8_kdd9jcZDx1xFcqO5CZVMLcktht48HU8wa8L3YY-3hN3zcwEK-6sVsBEXnGsle1vBV27-UfTY-ARLshj4)

While debugging, I found that $ajax_page_state is NULL :/

class AjaxResponseAttachmentsProcessor implements AttachmentsResponseProcessorInterface {
  ..
  protected function buildAttachmentsCommands(AjaxResponse $response, Request $request) {
    $ajax_page_state = $request->get('ajax_page_state');

Hello,

Issuer shoudn't have a trailing slash at the END

https://www.linkedin.com/oauth/.well-known/openid-configuration
"issuer" : "https://www.linkedin.com",

https://accounts.google.com/.well-known/openid-configuration
"issuer": "https://accounts.google.com",

In our case

      'issuer' => trim(Url::fromUri('internal:/')->setAbsolute()->toString(), '/'),

should be replaced with

      'issuer' => trim(Url::fromUri('internal:/')->setAbsolute()->toString()),

Also, jwks_uri should be accessible to Anonymous users but settings _access: 'TRUE' is not enought. We need to alter some code in the Controller handle() function

if (!$this->user instanceof TokenAuthUser) {
throw new AccessDeniedHttpException('This route is only available for authenticated requests using OAuth2.');
}

should be removed

boulaffasae → created an issue. See original summary → .

Hi Chetan,

Unfortunately, your commit removed the fix :/

      if (count($display_id) !== count($count_view)) {

This should be replaced by

      if (count($display_id) !== $count_view) {

We are already have count in the Controller which call the Service

# src/Controller/ViewsAutocompleteApiController.php
    $display_ids = $this->viewsAutocompleteManager->getViewsDisplayId($display_id, count($view_name));

# /Service/ViewsAutocompleteApiManager.php
  public function getViewsDisplayId($display_id, $count_view) {
    if (!empty($display_id)) {
      $display_id = explode(',', $display_id);
      if (count($display_id) !== count($count_view)) {

I also added view permission, it should be a custom permission instead of true by default :)

boulaffasae → created an issue.

Hi everyone, I would suggest the following hook to update your database

** you should replace N by 8002, 9002
** after adding ->setRevisionable(TRUE), old users must re-install the module :/ which is not good (data loss). We should't add a hook to update table for old users

function translatable_menu_link_uri_update_N() {
  $database = \Drupal::database();

  $columns_schema = [
    'link_override__uri' => [
      'type' => 'varchar',
      'length' => 2048,
      'not null' => FALSE,
      'description' => 'The URI of the link.',
    ],
    'link_override__title' => [
      'type' => 'varchar',
      'length' => 255,
      'not null' => FALSE,
      'description' => 'The link text.',
    ],
    'link_override__options' => [
      'type' => 'blob',
      'not null' => FALSE,
      'size' => 'big',
      'description' => 'Serialized array of options for the link.',
    ],
  ];

  foreach ($columns_schema as $field_name => $column_schema) {
    // Create fields if they don't already exist.
    if (!$database->schema()->fieldExists('menu_link_content_field_revision', $field_name)) {
      $database->schema()
        ->addField('menu_link_content_field_revision', $field_name, $column_schema);
    }
  }
}

boulaffasae → created an issue.

DamienMcKenna → credited boulaffasae → .

hi FMB,

Good patch ^^

Luke.Leber → credited boulaffasae → .

Hi Julien,

No there is currently nothing that helps disabling tarteaucitron.js

Yeah, I will be happy to include this in the contrib module. Thank you ^^

boulaffasae → created an issue.

boulaffasae → created an issue.

Hi again !

You are right ^^, can you please go to TacJS services settings.

Under Youtube service, you have a checkbox called "needConsent" you need to mark it

The banner consider that the user doesn't need to configure any service and that all services are already consent. Which is not right, but the maintainers added a new option called needConsent that ovveride tarteaucitron.js default configuration

Hi brulain,

can you please re-configure the settings, you might need to enable the showIcon

Hello brulain,

Do you have any errors in the Console ? I used the 6.4-alpha4 (in a new installation) and I didn't had any prb

You also don't have the lock icon in the right side of your screen ?

Hi Kakoum,

Frank Mably fixed this issue in the pre-release version /
https://git.drupalcode.org/project/tacjs/-/commit/ecc5ec7c17c45ee13cdf3a...

You can create a patch to resolve the issue in your current version