- Issue created by @boulaffasae
- Merge request !9Issue #3469637: Enable typography plugin using `plugins` query parameter → (Merged) created by boulaffasae
- Issue was unassigned.
- Status changed to Needs review
4 months ago 9:24am 22 August 2024 - Status changed to Needs work
4 months ago 9:41am 22 August 2024 - 🇫🇷France G4MBINI Bègles
Hello @boulaffasae !
Souldn't you update also ui_suite_daisyui.info.yml file ?
libraries: - ui_suite_daisyui/daisy - ui_suite_daisyui/tailwind_typography
shouldn't be updated to :
libraries: - ui_suite_daisyui/daisy
now that you have updated ui_suite_daisyui.libraries.yml file ?
- Assigned to G4MBINI
- Status changed to Needs review
4 months ago 7:48am 23 August 2024 - 🇫🇷France G4MBINI Bègles
Thanks @boulaffasae modification are ok.
But I noticed that prose class applies styles differently.
With previous implementation of typography plugin max-widht was not applied and with new implementation yes ...
Which generate a very narrow div width.
See screenshot attached.
Previous implementation of plugin :
New implementation of plugin :
- Issue was unassigned.
- Status changed to Needs work
4 months ago 8:51am 23 August 2024 - Status changed to Needs review
4 months ago 7:32am 2 September 2024 Hi !
I was able to resolve the issue using the !important prefix for class "container", I updated the PR.
-
g4mbini →
committed b5fbb33c on 4.0.x authored by
boulaffasae →
Issue #3469637 by boulaffasae, g4mbini: Enable typography plugin using `...
-
g4mbini →
committed b5fbb33c on 4.0.x authored by
boulaffasae →
- Status changed to Fixed
4 months ago 2:16pm 4 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.