Redux Sync all single-value types in the SDC test all props form

@bnjmnm Let me know if there is a way to manually test this.

Refer to the new e2e tests in prop-types.cy.js and perform those steps manually
Itpretty much boils down to adding the sdc test all props component, and with the exception of the Media Library/Image widget at the bottom, making a change to each field and confirming there is no crash and the preview updates accordingly. See the e2e test file for limitations we are already aware of and note that no validation (min/max, required, regex) etc is currently in place. This will be added in a separate issue.

Thanks 🙏 I’ll see if someone can jump on this.

I posted an initial review, but I think this especially needs input from @jessebaker.

wim leers → credited jessebaker → .

This is a big leap forward! 👏

In manual testing, this AFAICT does work fine for type: string, enum: […] too? But I defer to @bnjmnm whether to include or exclude that here.

That'd allow 🐛 String props that are integer values aren't treated as strings Postponed to be closed too 🤞

Threads addressed, and I'll address #10 in a separate issue - moving off the string assumption requires additional logic not in this issue, and I think it's more likely to get a quality review if it isn't diluted by the many complex changes already in this issue's MR.

I have just tested this MR branch with our WIP updates from:

https://git.drupalcode.org/project/demo_design_system/-/merge_requests/53

and it doesn't fix the hanging props form (on components with images) that was reported in:

🐛 XBEndpointRenderer & processResponseAssets() do not support `ajaxPageState` ⇒ duplicate CSS/JS loading Fixed

Maybe it shouldn't fix it? There are so many issues bouncing around that it's hard to know.

I can confirm that this fixes the textarea props.

and it doesn't fix the hanging props form (on components with images) that was reported in:

Images are not single-value props (it is an object with path, alt, width, height) and not covered here. When in doubt (and the doubt is reasonable) look at the e2e tests and if you don't see tests added it's safe to assume it's not in the scope of the issue.

Thanks for the clarification and pointers 👍

Approved - and love that this resolves the flakey components-slots test!

-> @wim leers for backend review

Still needs approval from a semi-coupled theme engine code owner.

But given this is the #1 priority for 🌱 Milestone 0.1.0: Experience Builder Demo Active and that @bnjmnm is the primary author of that anyway … I think a +1 from @hooroomoo or @effulgentsia is overkill in this case.

Plus, per #16 the flakey components-slots E2E test, so … bypassing the need for that approval 🤓

Automatically closed - issue fixed for 2 weeks with no activity.