Adding a component with slots does not register the slots as children

grammar is hard when you are tired :D

🐛 [PP-1] Impossible to drop a component into an empty column of the two Active fixed a big problem with the Two Column component (and others that have slots with example content) — not sure if you had the chance to get the changes from that, the code just recently landed.

What I'm excited about is 🐛 Retain the placement of components within the preview when inserting a component Active , which I think introduces a major improvement on the drag & drop experience. There is still work to do, but I'm curious what you think!

Thanks 🙏 I found that issue earlier today and am following but didn’t try anything. Should I test?

I wonder if we should try to increase the size of the dropzone for empty slots with something like width: 100%; height: 100%.

This might actually be addressed by 📌 Improve UX of adding new sections Needs review .

So let's wait for 📌 Improve UX of adding new sections Needs review to land first.

📌 Improve UX of adding new sections Needs review displays a border around slots, which is nice, but it doesn't actually impact the dragging behavior.

🐛 Retain the placement of components within the preview when inserting a component Active tweaks the drag & drop thresholds, so I would like that to land first.

🐛 Retain the placement of components within the preview when inserting a component Active landed!

Is this unblocked now, or is it blocked on 📌 Improve UX of adding new sections Needs review ?

Assigning to @balintbrews to find out 😇

Hi everyone,

I might be wrong :) but I suppose One column / Two column don't work for now.

Only "Fake Section 2" works, you can drag & drop inside of it but you can't do the same inside a new One/Two column.

Record: https://www.loom.com/share/d567c2e86af54edea1e6c51b5e307476?sid=5ad28362...

** when I drag a component the left/right side of the new Two column, the sidebar on the left doesn't get updated. Which mean after the next change, everything will go back to normal.

Updating the title for better clarity. @jessebaker already tracked down the problem and created 🐛 Adding a component with slots does not show the slots in the layers view Closed: duplicate which was closed as duplicate. Quoting a relevant piece from that issue's description:

I believe that when adding a new component to the layout the layoutModel data for the new component does not have the slots added as children.

@boulaffasae Your description is accurate of the issue I've been addressing here and I believe that this is now fixed if you would like to try and re-test!

Hello, Thank you everyone for the fixe.

Yes, Drag & Drop work very good, I can put elements in One/Two columns with no issue.

Tested this and there are still some quirks but some may be with the components themselves:

https://www.youtube.com/watch?v=esII_juFxcE