- Issue created by @Kristen Pol
- Assigned to joshua1234511
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Assigning to Joshua to test out.
- 🇮🇳India joshua1234511 Goa
Tested the patch from issue https://www.drupal.org/project/gin/issues/3242554 🐛 contents of dropdown button go to the left and can be off the visible page RTBC
Patch tested from Merge Request https://git.drupalcode.org/project/gin/-/merge_requests/459Case tested for mention issues
Case 1: when the dropdown is at the top
Case 2: when the dropdown is somewhere in the bottom
@kristen-pol
Not sure of the status that needs to be set to this issue, As patch needs to be applied to the https://github.com/phenaproxima/starshot-prototype.git - Assigned to Kristen Pol
- Status changed to Needs review
5 months ago 11:02am 12 August 2024 I think we should integrate the patch for now, and follow the updates in the Gin issue.
I updated the docs: https://www.drupal.org/community-initiatives/starshot-demo-design-system... →
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Yeah… was just wanting to make sure it worked and add it to dev guide 👍
- Assigned to joshua1234511
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Joshua, if you could review the docs change, that would be great
- Assigned to Kristen Pol
- Status changed to RTBC
5 months ago 9:31am 13 August 2024 - 🇮🇳India joshua1234511 Goa
I reviewed the document changes, updated the wording, and added a reference to the ongoing issue with the Gin theme.
Reference: https://www.drupal.org/community-initiatives/starshot-demo-design-system... → - Status changed to Needs review
5 months ago 4:52am 20 August 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Thanks 🙏 I’ll see if someone will review the doc steps work.
- Issue was unassigned.
- 🇮🇳India annmarysruthy
Unable to review: Tried reviewing the changes in documentation https://www.drupal.org/community-initiatives/starshot-demo-design-system/sdds-development-guide → . Currently unable to setup the local due to InvalidComponentException.
Error :
Drupal\Core\Render\Component\Exception\InvalidComponentException: [props.properties.link.properties] Array value found, but an object is required/n[props.properties.image.properties] Array value found, but an object is required in Drupal\Core\Theme\Component\ComponentValidator->validateDefinition() (line 121 of core/lib/Drupal/Core/Theme/Component/ComponentValidator.php).
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Created new issue:
🐛 InvalidComponentException: [props.properties.link.properties] Array value found Active
- Status changed to RTBC
5 months ago 5:06am 21 August 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
I have confirmed that using the patch steps that were added to the dev guide fixes the issue.
We should get the Gin patch added to:
https://www.drupal.org/project/drupal_cms →
Leaving this RTBC until we have an issue for that.
- Status changed to Fixed
5 months ago 6:41am 21 August 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Since this is only needed for Paragraphs and Drupal CMS won't be using Paragraphs, let's not add this as an issue there.
Automatically closed - issue fixed for 2 weeks with no activity.