🇮🇳India @joshua1234511

gargsuchi → credited joshua1234511 → .

OEmbed (remote video) is already handled similarly to other media components, with:

civictheme_preprocess_media__civictheme_remote_video for Remote Video
civictheme_preprocess_media__civictheme_video for Video.

Is there a specific reason to use civictheme_media_get_variables() for this case?
In the current setup, this function is used only for attachments (Documents), and an image which always include an associated file.

Tested the patch provided in https://www.drupal.org/project/gcontent_moderation/issues/3464458#commen... ✨ Rework valid transitions to respect group scoped system Active
It fixes the issues but introduces a use case issue where the other user roles that are non group do not follow the permissions.

Added a patch for the fix.

Updated the MR with fixes for visually hidden text to read out on back-to-top button.

@sourojeetpaul Could you please test the same.

joshua1234511 → made their first commit to this issue’s fork.

Tested the patch provided, The patch fixes the issue.
Raised a MR and setting for code review.

Issue is related to https://www.drupal.org/project/domain_simple_sitemap/issues/3465449 🐛 Import failed: Deleted and replaced configuration entity sitemap.type Needs review

Standalone module has no issue, issue with Domain access feature.

Can be closed.

joshua1234511 → changed the visibility of the branch 3.0.x to hidden.

joshua1234511 → changed the visibility of the branch 3465449-import-failed-deleted to active.

joshua1234511 → made their first commit to this issue’s fork.

kristen pol → credited joshua1234511 → .

kristen pol → credited joshua1234511 → .

Issue is replicable on Latest 3.0.x-dev

@ richardgaunt

The issue more of global then civic theme specific. though the patch will fix the issue. But there might be more instances where getCreatedTime() is used.

https://www.drupal.org/project/drupal/issues/3453210 🐛 getCreatedTime returns string instead of integer Needs work

I suggest we keep track of the issue.

Submitted a merge request. Ready for review.

joshua1234511 → created an issue.

MR: https://git.drupalcode.org/project/demo_design_system/-/merge_requests/31

Task
Identified minimal amount of files/directories that are built with npm run build for base theme and subtheme
Updated .gitignore to not include these built files/directories
Update README and dev guide with correct steps to install base theme and subtheme

Reviewed and tested locally
Following steps from https://www.drupal.org/community-initiatives/starshot-demo-design-system... →

Update README and dev guide with correct steps to install base theme and subtheme
- No update required as steps already added
https://www.drupal.org/community-initiatives/starshot-demo-design-system... →
Step 3: Configure and enable base theme
Step 5: n addition to enabling the base civictheme theme, we have a subtheme with the custom branding and components for Drupal CMS, so we need to configure and enable that too

joshua1234511 → made their first commit to this issue’s fork.

Issue fixed in https://github.com/civictheme/uikit/pull/346

Proof of Concept (PoC) for content provisioning with Content & Callout Component.

If we are going with the module then it's just adding the steps in the document.
The module is updated with latest CivicTheme components which will create random content for various components.

Investigated the pending issues. It's a similar case.
Reference - https://www.drupal.org/project/drupal/issues/3176461 🐛 The "extra_field_block:node:recipe:content_moderation_control" was not found Needs work - Needs work
The provided patch does not solve the issue, it just removes the section listing the issue, which is incorrect.
Its due to the point when the installation happens the layout builder is not aware of the fields .

Looking into a way to suppress the warnings.

I reviewed the document changes, updated the wording, and added a reference to the ongoing issue with the Gin theme.
Reference: https://www.drupal.org/community-initiatives/starshot-demo-design-system... →

Fixed wording

Added Reference to the Issue requiring a contrib patch

I did play around with the code and could think of two approaches and a blocker

Creating a Demo Page: programmatically create a page that shows all components by adding paragraphs for each component. However, this approach requires creating an actual page with these paragraphs, which would need default content.

Alternative Using Views: Another approach could be to create a view that lists all paragraphs. If each field in the paragraph has a default value, you can list them directly in the view. This could serve as a dynamic display of components, though it still relies on having those paragraphs with default content in place.

In both cases the blocker: overriding the paragraph templates to embed/include the SDC components.
Needs to be done manually as done here https://www.drupal.org/project/demo_design_system/issues/3465043#comment... 📌 Create automated script for converting components to SDC Fixed
-- Once all components are updated paragraph templates to embed/include the SDC components. ie : reference https://git.drupalcode.org/project/demo_design_system/-/merge_requests/3...

The warning related to [warning] The "block_content:50c52459-c100-4e4d-92a4-9c4c77d8f8d0" was not found
block_content not found is in know issue in CivicTheme.
The scenario
- The blocks are created during config import on theme install.
- Default site block are placed within the layout with predefined content.
- Block content at this point is not available, it is created only after the provision of content.

Block content cannot be created before the install of the block types.
After the provision of content blocks the blocks are correctly assigned.
These warning can be ignored

field_block Issue
- Needs more debugging.

Tested the patch from issue https://www.drupal.org/project/gin/issues/3242554 🐛 contents of dropdown button go to the left and can be off the visible page RTBC
Patch tested from Merge Request https://git.drupalcode.org/project/gin/-/merge_requests/459

Case tested for mention issues
Case 1: when the dropdown is at the top

Case 2: when the dropdown is somewhere in the bottom

@kristen-pol
Not sure of the status that needs to be set to this issue, As patch needs to be applied to the https://github.com/phenaproxima/starshot-prototype.git

Kristen Pol → credited joshua1234511 → .

@alexskrypnyk

Tested the issue in two scenarios:

Test 1
Without running the necessary Drush command:
Components field was missing due to an incomplete installation process.

Test 2
With running the necessary Drush command:
Components field was added correctly, and everything worked as expected.

Solution:
Ensure that the installation steps are followed correctly, including running the essential Drush command to enable the required modules.
Related to
Please do not submit issues if your installation finished with WSOD - this means that you are using CivicTheme that was not fully installed. Install a patch mentioned above and restart your installation from scratch.

Steps Taken to Debug:
Fresh Installation:
Downloaded CivicTheme as an archive.
Extracted it to the themes directory.
Ran the sub-theme script and followed the instructions in the project/readme.

Scenario 1: Missing Components Field
Did not run the necessary Drush command:
drush ev "require_once dirname(\Drupal::getContainer()->get('theme_handler')->rebuildThemeData()['civictheme']->getPathname()) . '/theme-settings.provision.inc'; civictheme_enable_modules();"
Result: The field components were missing due to an incomplete installation process.

Scenario 2: Successful Installation
Followed the latest installation steps from CivicTheme Drupal project page.
Ran the necessary Drush command & followed the Patch installation.
drush ev "require_once dirname(\Drupal::getContainer()->get('theme_handler')->rebuildThemeData()['civictheme']->getPathname()) . '/theme-settings.provision.inc'; civictheme_enable_modules();"
Result: All components were added correctly, and everything worked as expected.

Conclusion:
The issue of missing components field in the node form display was due to not running the required Drush command during the installation process. https://docs.civictheme.io/development/drupal-theme#usage

Testing Notes

- Switched to tag 1.7.1
- Build Drupal site (New Build)
- Switch to branch `feature/3458260-missing-update-hooks`.
- Update/ Build child theme code.
- Clear Cache
- Review the site and validate that the issues exist.
- Run update DB code.
- Review the site and validate that the issues have been fixed.

Before

After

Test Result: Reviewed the site and validated that the issues have been fixed.

The above issue is related to https://www.drupal.org/project/civictheme/issues/3415665 ✨ Utilize Focal Point module Active
As a sub task of above related issue is to fix
- Update code to use existing image styles.

@sonamchaturvedi
Test: When we update focal point of an image used in an existing component : Updated Focal point should be reflected for the component.
Resolution
The change to be reflected cache needs to be cleared.
As the image styles are generated and cached.

@alexskrypnyk
Related issue on DO: https://www.drupal.org/project/focal_point/issues/2906631 🐛 After changing focal point, image doesn't change until you click preview Needs review
Even though the patch solves one issue, it still does not solve the cache issue. Still needs work.
Please suggest.

alex.skrypnyk → credited joshua1234511 → .

alex.skrypnyk → credited joshua1234511 → .

alex.skrypnyk → credited joshua1234511 → .

alex.skrypnyk → credited joshua1234511 → .

alex.skrypnyk → credited joshua1234511 → .

@alexskrypnyk

The wrapper https://github.com/civictheme/uikit/blob/main/components/02-molecules/fo...
for radios and checkbox need to be 'flex'

  &ct-form-element--radio,
  &ct-form-element--checkboxes {
    display: flex;
  }

Reason: https://github.com/civictheme/uikit/blob/main/components/02-molecules/fo...
Label is not printed within the input element but rather outside.

Content is never passed to https://github.com/civictheme/uikit/blob/main/components/02-molecules/fo...
rather label has its own component 'form-element-label'

joshua1234511 → created an issue.

alex.skrypnyk → credited joshua1234511 → .

alex.skrypnyk → credited joshua1234511 → .

alex.skrypnyk → credited joshua1234511 → .

alex.skrypnyk → credited joshua1234511 → .

alex.skrypnyk → credited joshua1234511 → .

alex.skrypnyk → credited joshua1234511 → .

Followed the steps to reproduce

1. Installed civictheme
2. Build theme assets
3. Opened built storybook and observed if the property knobs have disappeared.
4. Did the same for a new sub-theme

visited the storybook on the below build storybook
themes/custom/civictheme_demo/storybook-static/index.html
themes/contrib/civictheme/storybook-static/index.html

Issue No longer exists.

alex.skrypnyk → credited joshua1234511 → .

alex.skrypnyk → credited joshua1234511 → .

alex.skrypnyk → credited joshua1234511 → .

@alexskrypnyk

Tried to replicated the issue using latest 1.6.x version

Results

Test 1
Issue is replicable if
- Install Drupal 10
- Install Components beta 3
- Install the CivicTheme
- Enable the required modules
- Enable the theme via the Appearance admin UI screen
Clear cache is not done after the Theme download/ or added via composer. ( https://www.drupal.org/project/civictheme/issues/3401376 🐛 Twig template is not defined Closed: won't fix )

Test 2
Issue Non Replicable
- Install Drupal 10
- Install Components beta 3
- Install the CivicTheme
- Clear Cache
- Enable the required modules
- Enable the theme via the Appearance admin UI screen

@alexskrypnyk

Not sure if an issue. Related to https://www.drupal.org/project/civictheme/issues/3401376 🐛 Twig template is not defined Closed: won't fix

Steps to reproduce
- Install D10
- Download via composer/ or manual
- Enabled all dependencies

- Clear Cache (Skipping this steps results in Break in the install)

- Install CivicTheme
- Enable Watchdog
- Load the homepage
- View the watchdog log

Results
- With out Clear Cache
- Results in Some pending installations, ex, views & webforms.

- With Clear Cache after theme downloaded
- Installation Completed properly.
- All views installed with no errors.

alex.skrypnyk → credited joshua1234511 → .

Updated the configuration to display the column title.
PR: https://github.com/civictheme/monorepo-drupal/pull/1209

PR raised: https://github.com/civictheme/monorepo-drupal/pull/1206

Implemented:

1. Created Media tags (civictheme_media_tags) vocabulary.
2. Added permissions for the Content author and Site administrator roles to perform CRUD operations on terms (but not the vocabulary).
3. Added Behat tests for permissions.
4. Added entity reference Media tags ( field_m_media_tags ) field to each media entity.
5. Updated existing Behat tests for fields on media entities.
6. Created a clone of vanilla Drupal Media view and store it as optional config in theme (named with civictheme prefix ). Adjust filters to show the Media tags filter and allow to match on partial tag matches.
7. Implemented an additional settings provisioning option to replace Media view with the one shipped in CT configuration.
8. Added a Behat test that would be checking that a Content->Media page has the required filters and can be searched through.

Not Implemented/ Questions

• Create a clone of vanilla Drupal Media library view and store it as optional config in theme (leave the name as-is). Adjust filters to show the Media tags filter and allow to match on partial tag matches.
• Cloning is not enough, there are theme template and preprocessing required to obtain the look na feel of existing view
• https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/media...
• https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/media...
• https://git.drupalcode.org/project/drupal/-/tree/11.x/core/modules/media...
• One way can be update the exiting view add it to optional and load as single import via content provisions.

Investigated the issue.

Steps used to reproduce the issue.
- Created a new content with having Manual list with various cards ie: event card, promo card etc.
- Added text which will follow full text search 'textwithsummary'
- Searched the content with the text
- Search Result Displayed the result.

Summary
- Issue no longer replicable.

Pull Request https://github.com/civictheme/monorepo-drupal/pull/1205

alex.skrypnyk → credited joshua1234511 → .

fionamorrison23 → credited joshua1234511 → .

fionamorrison23 → credited joshua1234511 → .

fionamorrison23 → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

JoiGarrett → credited joshua1234511 → .

Kristen Pol → credited joshua1234511 → .

dan2k3k4 → credited joshua1234511 → .

joshua1234511 → made their first commit to this issue’s fork.

quietone → credited joshua1234511 → .

Kristen Pol → credited joshua1234511 → .

Kristen Pol → credited joshua1234511 → .