civictheme_media_get_variables not returning correct "created" value

Open on Drupal.org →

Created on 2 September 2024, 18 days ago

Updated 5 September 2024, 14 days ago

Problem/Motivation

The helper utility function civictheme_media_get_variables returns 1 Jan 1970 as the Created date.

This seems to be because $media->getCreatedTime() returns a String, and civictheme_format_datetime requires an Int.

Proposed resolution

themes/civictheme/includes/utilities.inc
On line #136
Change from:

'created' => civictheme_format_datetime($media->getCreatedTime(), 'civictheme_short_date'),

to

'created' => civictheme_format_datetime((int) $media->getCreatedTime(), 'civictheme_short_date'),

🐛 Bug report

Status

Needs review

Version

1.8

Component

Code

Created by

🇦🇺Australia Toby Wild

Live updates comments and jobs are added and updated live.

civictheme-release-1.9

Sign in to follow issues

Comments & Activities

Issue created by @Toby Wild
Comment 16 days ago →
🇦🇺Australia RichardGaunt Melbourne
Comment 16 days ago →
🇦🇺Australia RichardGaunt Melbourne
Assigned to joshua1234511
Status changed to Downport 16 days ago8:30am 4 September 2024
Comment 16 days ago →
🇦🇺Australia RichardGaunt Melbourne
Comment 15 days ago →
fionamorrison23
Comment 15 days ago →
🇮🇳India joshua1234511 Goa
@ richardgaunt

The issue more of global then civic theme specific. though the patch will fix the issue. But there might be more instances where getCreatedTime() is used.

https://www.drupal.org/project/drupal/issues/3453210 🐛 getCreatedTime returns string instead of integer Needs work

I suggest we keep track of the issue.
Status changed to Needs review 14 days ago11:14pm 5 September 2024
Comment 14 days ago →
🇦🇺Australia RichardGaunt Melbourne

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024